Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-28 14:39:28 +02:00
Code Issues Releases Wiki Activity
7,326 Commits 23 Branches 23 Tags
Commit Graph

1054 Commits

Author SHA1 Message Date
Paul Licameli
26b94a447b change a variable name 2016-08-22 21:45:54 -04:00
Paul Licameli
39df8d0b51 Don't use conversion of sampleCount to bool 2016-08-22 21:45:54 -04:00
Paul Licameli
a6de680cdb use std::min and std::max 2016-08-22 21:45:54 -04:00
Paul Licameli
2be2e73e66 LadspaEffect::mSampleRate has type double, like other plug-in effects 2016-08-22 21:45:54 -04:00
Paul Licameli
1189cfd62a Identify the few unsafe narrowing conversions from sampleCount... 
... I believe this list of four places is exhaustive.

There are many, many more safe narrowings that I examined.

This resulted from changing the definition of sampleCount in my builds so that
narrowing conversions failed to compile without some fixes, and I examined and
fixed every place.

The rest of that work is not yet shared.
 2016-08-21 15:28:32 -04:00
Paul Licameli
56586770e0 EffectClientInterface::SetSampleRate takes double... 
... All the overrides (except Ladspa) were casting it to floating poing anyway
 2016-08-21 09:51:32 -04:00
Paul Licameli
49e699b1df Remove overloads for sampleCount from ConfigInterface... 
... The value was always cast to int anyway when writing, and it was used
only for one value in VST effect, which did not need 64 bits
 2016-08-21 09:11:44 -04:00
Paul Licameli
2a7d8dca77 time warper bug 2016-08-21 08:59:48 -04:00
James Crook
b1526fbdc8 Change strings for clarity/consistency. 
Changes suggested by (translator) scootergrisen
 2016-08-19 19:30:21 +01:00
Paul Licameli
a0a76e86d1 Remove naked new and delete in effect preview 2016-08-16 13:30:26 -04:00
Steve Daulton
7b14e68b37 Pass name of proxy effect to EffectSBSMS 
Allows progress bar to show meaningful title when using SBSMS
time stretching in Change Pitch/Tempo.
 2016-08-16 14:54:34 +01:00
David Bailes
19fa6d2833 Improvements to accessibility names in Change Tempo effect. 
The change tempo effect was modified in commit 8e0089c.
The most significant change is to include the "from" length in the accessibility name of the "to" length textctrl. (The nvda screen reader cannot access the value of the "from" length textctrl, and it's not straightforward using Jaws. Note that this issue existed before the recent change of Change Tempo.)

There remains a minor issue of Jaws, but not NVDA reading the names of wxStaticBoxes, and so some repetition in what is read by Jaws.
 2016-08-16 13:57:19 +01:00
Steve Daulton
8e0089c552 Add SBSMS option to Change Tempo effect 
Thanks to Clayton Otey for his help and patience.
 2016-08-15 12:33:33 +01:00
Paul Licameli
32f24eabb2 Review uses of safenew... 
... add comments and assertions, and use make_unique instead where possible
 2016-08-13 23:16:05 -04:00
Steve Daulton
90e400b0a7 Add SBSMS option to Change Pitch effect 2016-08-13 17:28:49 +01:00
Paul Licameli
e412c13e78 Fix crash at program exit after use of Stereo to Mono 2016-08-13 10:39:56 -04:00
Paul Licameli
e599cfa6fa Effect::mOutputTracks is managed by smart pointer 2016-08-13 10:37:51 -04:00
Paul Licameli
cb48ca2b91 Use arrays of smart pointers to WaveClip 2016-08-12 20:53:38 -04:00
Paul Licameli
a400a7408c Distinguish whether clip ptr arrays own; vector; const-correctness 2016-08-12 20:53:38 -04:00
Paul Licameli
b548e641ae Simplify iterations over WaveClips outside of WaveTrack/WaveClip; ... 
... also add some const qualifiers
 2016-08-12 20:53:37 -04:00
James Crook
8089bd484a (Cosmetic) added 'final' to class definition. 
Putting the word 'final' is a bit like adding a comment that nothing is derived from this effect.
 2016-08-10 18:25:07 +01:00
Paul Licameli
14c23803ac Various uses of make_unique 2016-08-10 11:05:52 -04:00
Paul Licameli
11305b956f Use make_unique for wxMenu objects 2016-08-10 11:05:52 -04:00
Paul Licameli
4045d96a58 Fix a memory leak I introduced in Truncate Silence ... sorry 2016-08-10 11:05:52 -04:00
Paul Licameli
6e4e710d3b Remove seeming naked new and deletes in comments and uncompiled code 2016-08-10 11:05:51 -04:00
Paul Licameli
fec4069d9d Some uses of Destroy_ptr let us remove some naked news 2016-08-10 11:05:51 -04:00
Paul Licameli
384fc4a4ae Prefer Destroy() to deleting a window 2016-08-10 11:05:50 -04:00
Paul Licameli
a52f7f8410 new -> NEW in comments, so text search for naked new excludes them 2016-08-08 10:07:37 -04:00
Paul Licameli
0bb17c174e Do CFRelease only inside destructors, in AudioUnitEffects.cpp ... 
... may fix a memory leak in AudioUnitEffect::SupportsAutomation
 2016-08-08 07:51:26 -04:00
Paul Licameli
eb6ba1ed7a Remove some naked new amd delete in: Plug-in effects 2016-08-08 07:51:26 -04:00
Paul Licameli
6fec00149b Remove some naked new amd delete in: Built-in Effects 2016-08-08 07:51:25 -04:00
Paul Licameli
942c62b6f6 Remove some naked new amd delete in: various 2016-08-08 07:51:24 -04:00
Steve Daulton
fd2c65d5d2 Set Compressor effect ratio slider page size to 5 
to provide more appropriate PgUp/PgDn for new 'Ratio' range.
 2016-08-03 00:40:21 +01:00
rickst29
f8a439f389 Compressor.cpp: Allow higher-precision 'Ratio' 
This enhancement allows the User to set 'Ratio' to a between 1.1 and 10, with 0.1 precision.
Formerly, the minimum was 1.5, and the smallest increment was 0.5.
 2016-08-01 09:42:20 -07:00
Paul Licameli
e0f1e9a5ff Redo previous, not breaking Mac build if wxWidgets is not rebuilt 2016-07-31 14:53:05 -04:00
Paul Licameli
c8e570797f Bug1338 fixed again, with fewer Mac busy-waits; CHANGES WX BUILD... 
... Busy-waiting will happen on Mac when modal dialogs are open, and a LADSPA,
VST, or AudioUnits effect is also open with "fancy" interface.

Busy-waiting will not happen for modal dialogs at other times.
 2016-07-31 12:46:03 -04:00
windinthew
e24d6d825f Bug 858: Update recording error message too 
Also remove redundant 'while' in the messages
 2016-07-27 16:48:30 +01:00
Steve Daulton
8f016b0c1c Increase latency in Distortion effect 
to reduce skipping, which has been reported with some
settings on Windows.
 2016-07-25 13:18:52 +01:00
Steve Daulton
6629733d35 Bug 858 - Update error message 
Trying Gale's suggestion from
http://bugzilla.audacityteam.org/show_bug.cgi?id=858#c2
 2016-07-24 16:35:17 +01:00
Steve Daulton
ab135ff478 Disallow enabling RT preview when setting invalid 2016-07-24 15:41:15 +01:00
Steve Daulton
5412eab040 Distortion presets for remainder of 'Types' 2016-07-18 12:06:42 +01:00
James Crook
d092fe0e4b Review and fix CaptureMouse (per Bug 1204 commit comment) 
This is using the same idiom of only capturing if not capturing already.  These cases in AutoDuck, Resizing, Grabber and TQP might have been latent ASSERTs.  This based on precedent rather than actual elicited buggy behaviour.
 2016-07-17 09:38:23 +01:00
James Crook
163063f516 Merge pull request #143 from RaphaelMarinier/remove-old-fft2 
Code cleanup: removed the old real FFT code not used for a long time
 2016-07-13 18:32:42 +01:00
Steve Daulton
b3c7f37aba Merge pull request #141 from WaveMotion/changepitchparam 
Correctly load parameters for Change Pitch effect
 2016-07-12 19:51:08 +01:00
Gale Andrews
5648023cf3 Further fix for Windows build 2016-07-11 18:45:47 +01:00
Paul Licameli
84c0337aba Fix TAB key navigation on Mac for all dialogs (not only for panels) 2016-07-10 17:12:27 -04:00
James Crook
763485b0dc Add error check comments. 
These are places where we don't properly handle error returns.
 2016-07-10 21:40:48 +01:00
Steve Daulton
673aecf05d Remove Leveller effect from Linux build 2016-07-01 16:49:49 +01:00
Steve Daulton
7c8d8b64d3 Distortion effect, 'Hard Clip' to 'Hard Clipping' 2016-07-01 11:27:23 +01:00
Paul Licameli
2a6a1b2679 Revert "Bug1329, partial: Enter invokes OK button again for effects on Mac"... 
... because other fixes for Mac keyboard navigation have made this unnecessary.
 2016-06-28 12:04:49 -04:00