Paul Licameli
70d9e4bdc7
GetMinMax, GetRMS functions take a mayThrow argument, return numbers
2017-03-21 14:19:02 -04:00
Paul Licameli
22a12c6852
Exception safety in: some effects and generators...
...
... Those that directly call WaveTrack functions in their Process() routines,
which might throw exceptions for disk space exhaustion.
2017-03-21 14:11:25 -04:00
Paul Licameli
1fad6292a2
Exception safety in: overrides of ShowInterface
2017-03-21 14:11:24 -04:00
Paul Licameli
79c3bef2ce
Exception safety in: general effect performing functions
2017-03-21 14:11:24 -04:00
Paul Licameli
464828d88f
Exception safety in: batch processing
2017-03-21 14:11:21 -04:00
Paul Licameli
82dd7545c9
Reviewed uses of release(); prefer Destroy_ptr to hold window objects
2017-03-21 14:11:18 -04:00
Paul Licameli
d38dde213e
Revert "Fix compilation of EXPERIMENTAL_EFFECTS_RACK"
...
This reverts commit 9842d0742f95dafc9949c775506d2f96c4ac3256.
2017-03-19 10:51:00 -04:00
Paul Licameli
9842d0742f
Fix compilation of EXPERIMENTAL_EFFECTS_RACK
2017-03-19 10:49:23 -04:00
James Crook
e94fa1d65e
Fix compilation on MSVC2013 Express.
...
MSVC2013 Express does not support some initialisation syntax for structs and instead gives error C2905.
This workaround to get us compiling again may need revisiting.
2017-03-18 16:07:15 +00:00
Paul Licameli
3bb04245c5
Strong exception safety in all uses of XMLFileWriter...
...
... Strong, meaning that the file at the specified path is created or modified
only if all write operations complete without exceptions, barring one very
unlikely possibility that a final file rename fails, but even in that case the
output is successfully written to some path.
This commit does not add throws, but changes the type thrown to a subclass of
AudacityException, so that GuardedCall will cause the user to see an error
dialog in all cases.
Duplicated logic for making temporary files and backups is now all in one
place, the class XMLWriter.
There may be more new GuardedCalls than necessary -- the catch-all for the
event loop, AudacityApp::OnExceptionInMainLoop, might be trusted instead in
some cases -- but they are sufficient.
2017-03-18 11:45:33 -04:00
Paul Licameli
b81cdee7e3
Comment where xml writing functions may throw
2017-03-18 11:45:05 -04:00
Paul Licameli
8e5975b10d
Report read exceptions met in SBSMS and Nyquist callbacks to user...
...
... without letting them propagate through the libraries.
2017-03-17 17:53:03 -04:00
Paul Licameli
6525bb18cf
Translate exceptions to error codes in callback functions...
...
... That is what the library protocols allow, and libraries may be written
in C and might corrupt their state if C++ exceptions pass through them.
2017-03-17 17:53:01 -04:00
Paul Licameli
576d3e3013
Don't let the catch-all block in Effect intercept the new exception
2017-03-17 17:53:01 -04:00
Paul Licameli
cab99f7234
Remove naked malloc (or similar) and free in: other effects
2017-03-17 17:52:53 -04:00
Paul Licameli
0c7e467a08
Remove naked malloc (or similar) and free in: reverb
2017-03-17 17:52:53 -04:00
Paul Licameli
03809532ca
Remove naked malloc (or similar) and free in: Equalization48x
2017-03-17 17:52:53 -04:00
Paul Licameli
58574f2f78
Redo type HFFT as a smart pointer, remove malloc and free
2017-03-17 17:52:51 -04:00
Paul Licameli
6ca89c28ff
Remove naked new[] in: builtin effects
2017-03-17 17:52:49 -04:00
Paul Licameli
cb05476c45
Remove naked new[] in: effects plug-ins
2017-03-17 17:52:48 -04:00
Paul Licameli
a4c7d37d3e
Remove naked new[] in: effects framework
2017-03-17 17:52:48 -04:00
Paul Licameli
aebaaf46a0
require unsigned arguments for Array(s)Of::reinit
2017-03-17 17:52:43 -04:00
Paul Licameli
38236a807c
More new -> NEW, delete -> DELETE in comments
2017-03-17 17:52:41 -04:00
Paul Licameli
ec0297ec28
more safenew
2017-03-17 17:52:41 -04:00
Paul Licameli
ac246d0468
Fix bug 1566 differently (signed/unsigned comparison)
2017-03-17 17:52:37 -04:00
Paul Licameli
37e7b5704a
a null check
2017-03-17 17:52:36 -04:00
Paul Licameli
2c0cdda353
Fix dangling pointer bug in lv2 effects
2017-03-17 17:52:35 -04:00
Paul Licameli
7dbb946d29
Propagate progress bar cancellation correctly in Normalize
2017-03-17 17:52:33 -04:00
Paul Licameli
08b99c533b
Remove Effect::mWarper, and stack-allocate warpers instead
2017-03-17 17:52:32 -04:00
Paul Licameli
b9e4aa01eb
Simplify Normalize by removing needless member variables
2017-03-17 17:52:31 -04:00
Paul Licameli
0af9b46eac
Move many fields out of Envelope that are needed only during editing
2017-03-17 17:52:31 -04:00
Paul Licameli
004df48438
Make Effect::mTracks private
2017-03-17 17:52:25 -04:00
Paul Licameli
aa0d55ac83
Use enum class ProgressResult, don't interconvert with int or bool
2017-03-17 17:52:24 -04:00
Paul Licameli
5036583549
Fewer inclusions of AudacityApp.h
2017-03-17 17:52:24 -04:00
Paul Licameli
81285ee0c1
More const and override
2017-03-17 17:52:20 -04:00
Paul Licameli
4913b124b2
Correct the argument passed to OnEffect by EffectRack
2017-03-17 17:52:19 -04:00
Paul Licameli
4c6306e6d6
Fix compilation of old NoiseRemoval
2017-03-17 17:52:17 -04:00
Paul Licameli
dbb2f04def
Incomplete fixes for compilation of EXPERIMENTAL_EQ_SSE_THREADED
2017-03-17 17:52:16 -04:00
Steve Daulton
b66675d71c
Restore legacy Nyquist plug-in PEAK-LEVEL property
2017-03-01 18:14:30 +00:00
Steve Daulton
f19b79f5c3
Consistency: 'plug-in' not 'plugin'
...
but retain deprecated / legacy form in code for compatibility.
2017-03-01 18:14:30 +00:00
Steve Daulton
7517b2653e
Set minimum size of EditCurvesDialog (bug 470)
2017-02-24 18:52:25 +00:00
Steve Daulton
a80556df2f
Bug 1574 - Built-in generators may generate wrong length
2017-02-24 18:52:03 +00:00
Steve Daulton
d9f7b3605f
Bug 1576 - Assert when New Length is zero in Change Speed effect
2017-02-24 18:51:39 +00:00
Steve Daulton
67810d35bf
Bug 1573 - Multi-line SAL scripts fail in Nyquist Prompt
2017-02-24 18:51:17 +00:00
Steve Daulton
81dd23bd16
Bug 1566 - Incorrect error message if Nyquist returns mono sound as an array
...
and quieten a load of compiler warnings.
2017-02-24 18:50:30 +00:00
Steve Daulton
1a5a025b70
Update Nyquist v4 property lists and comments
...
Comments added where documentation is required.
2017-02-24 18:50:28 +00:00
Paul Licameli
7808033421
Fix crash opening menu in some AU effects
2017-02-23 22:52:17 -05:00
James Crook
085489f7e2
Don't scan AudioUnits in fast check of plug-in validity.
2017-02-07 11:57:44 +00:00
Paul Licameli
e84a5b66ba
Fix Mac build after commit e4260e9581facc288be40d9ca84f98d52ec724b1
2017-02-06 20:31:51 -05:00
James Crook
e4260e9581
Bug 1587 - Mac: Ghost duplicate Nyquist effects after upgrade
...
Fix removes ghost Nyquist effects from the effects menu and generators from generate menu.
2017-02-05 20:27:56 +00:00
