"Velocity" is the technical term, and it's the term that's used everywhere.
"Gain" was probably only used because "gain" is used on wave tracks; since
note tracks aren't wave tracks (and shouldn't be treated as them) the
corresponding variables should be named velocity.
The compilation was broken in 67cec5a but fixed in ed8c7fd. However, the warnings weren't fixed. The same general sign-related changes from 67cec5a were applied, fixing several warnings.
This also changes the arguments for NoteTrack's label click handler, to match the ones found in TrackPanel. That's needed to handle some other const-related changes.
Additionally, EXPERIMENTAL_MIDI_PLAYBACK was changed to EXPERIMENTAL_MIDI_OUT in the documentation, as that is the correct name.
No ellipses in title bar of file open/import dialogs
Auto Recovery Discard dialogs say only recoverable projects are discarded
Capitalised button in Dependency dialogue per MS guidelines.
Group "cursor to project start / end" with other "Cursor to" commands.
Move remaining two "Skip to" commands to View menu (subject to change).
Access keys to be decided.
... Specifying non-throwing in some places wehre WaveTracks are read;
on failure, substitute zeroes instead and continue.
What remains is to rewrite operations in classes Sequence, WaveClip, and
WaveTrack with appropriate exception-safety guarantees; and then, to enable
new throw statements.
... by default, yes; as in effects or export or other editing.
But no, for mere display operations, or playback, or sample hit test. In such
cases, substitute zeroes for unavailable data.
By stipulating no-throw in such places, there are fewer places that require
scrutiny for exception-safety.
The default exception handling would also be undesirable, because we don't want
such operations to cause repeated error dialogs.
... so that AudacityProject::AudacityProject no longer has a path in the
static call graph that reaches block file write operations that might throw.
So it is easier to prove that other functions, calling that, don't throw.
Also delay the possibly thowing save of the import until after certain other
steps in the file opening procedure.