In commit 89e33da, the override of AcceptsFocus() was removed from the ToolBarResizer class so that ESC could cancel resizing. However this meant that the toolbar resizers were included in the tab traversal of the toolbars.
The fix is the same one that was used to fix the problem with the toolbar grabbers being in the tab traversal: override AcceptsFocusFromKeyboard(), rather than AcceptsFocus().
This happens on Windows 7 if the display scaling factor is set to 125% (and probably higher). This also happens on Windows 10, but only if in addition to the high scaling factor, the display scaling at high DPI is disabled on the compatibility tab of audacity.exe's properties dialog. (The behaviour on Windows 8.1 wasn't checked.) The effect of the toolbar becoming higher, is that on a row of a tooldock, no other toolbar can be in front of the Device toolbar.
In void DeviceToolBar::RepositionCombos(), the desired size of the combo boxes was set to the best size.
The fix is only use the x value of the best size, and leave the y value unchanged. Note that this may not be the only problem in the code which causes this problem, and so this problem may resurface in the future.
... Also for the pin/unpin button on the ruler.
Exceptions: scrubbing toolbar; transcription play does not mention shift
and ctrl modified versions.
Note too that on Mac, the special characters are used to indicate modifiers.
Faster building of release builds on Windows. This force-includes AudacityHeaders.h too. We didn't used to do this because it could hide include file mistakes which would break the build on Linux. We could build the Windows release version to check that includes hadn't been missed out. Now that we have automated Travis builds on Linux we have a better way to check Linux builds aren't broken, and can have faster Windows building of release.
Remove scrolling left of zero check mark from Tracks menu...
May always scroll before zero during transport when head is pinned...
Pinned playhead for recording is once again always center, not right
... Less need now to make it more discoverable, because we override an "off"
setting during transport with a pinned play head, thus removing some
inconsistency and confusion.
