Adds include for copy_n in AColor.cpp to fix issues with
compiling on some Linux-based systems.
Signed-off-by: akleja <storspov@gmail.com>
Reference-to: https://github.com/tenacityteam/tenacity/pull/663
The original workflow that we ended up using for skipping
CI runs whenever a person proposed a change that only
affected documentation straight up broke. So, we might as
well just remove it from our codebase.
Signed-off-by: Emily Mabrey <emabrey@tenacityaudio.org>
Reference-to: https://github.com/tenacityteam/tenacity/pull/637
Backport track affordance and label patches from upstream Audacity.
When the fork was originally started, we ended up carrying over a couple
of features that were half- or unfinished to our fork. This merge is meant
to make up for that.
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
Reference-to: https://github.com/tenacityteam/tenacity/pull/515
Subclasses should provide instances instead
(cherry picked from audacity commit bc8c6d4ccc6ffffa1fb1b30f3a9a5fe578f74ec1)
Signed-off-by: akleja <storspov@gmail.com>
LinkType replaces old boolean 'linked', mostly for WaveTrack display purposes
Track::GroupChannels splitted into Track::UnlinkChannels and Track::MakeMultiChannelTrack (which is also aware of new LinkType)
LinkConsistensyCheck made virtual to allow Track subclasses to perform type-specific consistensy checks.
Introduces some corner-cases with copy-pasting/old project importing/file importing..., which are handled
(cherry picked from audacity commit 607961da70968c179b60a811ce084b55a94438ec)
Signed-off-by: akleja <storspov@gmail.com>
Time Shift left/right commands do not work on the right hand channel of a stereo track when clips are not aligned.
This has been a problem since 3.3.0. Between 2.3.1 and 2.4.2 they moved a clip in the right hand channel more than they should, so moving the clip more than the cursor.
Problems and fixes, both in DoClipMove():
1. The reason for the commands not working at all was the track rather than the channel was been passed in the call MakeTrackShifter::Call( *channel, project )
2. The reason for the clip being moved more than it should, was the left hand channel always being passed as the captured track in the call:
state.Init( project, pShifter->GetTrack(), hitTestResult, std::move( uShifter ),
t0, viewInfo, trackList, syncLocked )
(cherry picked from audacity commit 405847092231f2cf1ddaec25855daa2feeccc566)
Signed-off-by: akleja <storspov@gmail.com>
... with some reinterpretation of what it means to "set the height" of a track.
Changing height allocation for a reduced separator between panels may also
be done, but that logic should also be localized in TrackPanel.cpp.
(cherry picked from audacity commit 5f7f180a6a0e05ea5543fe6b713c2a3740c95734)
Signed-off-by: akleja <storspov@gmail.com>
... Move them to new header TrackPanelConstants.h, to be used only by TrackPanel
and some closely cooperating classes, but not known to the track view, controls,
vertical ruler, or affordance classes.
Also distinguish track from channel separator thickness though these remain
equal.
(cherry picked from audacity commit fba2ef009ebff6c1c43101faca6d2cb07efb83df)
Signed-off-by: akleja <storspov@gmail.com>
... It only needs their sum, which it will assume is the constant amount of
padding always between tracks (not channels of a track).
(cherry picked from audacity commit 058c729ea544e326938b9473e7b9a5cd5ecc6ab5)
Signed-off-by: akleja <storspov@gmail.com>
... implemented simply and more correctly (though not efficiently), hiding
details about the method of rectangle subdivision, and allowing for multiple
sub-views.
This function can be exercised by choosing Boxes in the Track Info item of
Extra > Scriptables II
This commit leaves one fewer call to each of TrackView::GetY() and
TrackView::GetHeight()
(cherry picked from audacity commit 1880c14f112e3f38214f8517e6b9f8c6359a0171)
Signed-off-by: akleja <storspov@gmail.com>
Using mTextEditIndex for tracking active text box index, and mNavigationIndex used to track selection for keyboard navigation purposes See #1195
(cherry picked from audacity commit b90b5cfd47552711e048661c0c44a6d7af7e56d4)
Signed-off-by: akleja <storspov@gmail.com>
Changing bar size between label handles, minor refactoring (making named constants, which should ease changing drawing geometry, without necessety to make changes to internals)
(cherry picked from audacity commit 17a7de639f3fad18123769e2c38d710a953e05e4)
Signed-off-by: akleja <storspov@gmail.com>
Initially attempt to find tags excluding "Audacity-" and "DarkAudacity-"
Allow graceful fallback case for "Audacity-" tags
Add logic to remove "DarkAudacity-" tag prefix to match "Audacity-" tag behavior
Signed-off-by: Emily Mabrey <emabrey@tenacityaudio.org>
We have recently switched to rDNS schema. A little part was left out.
This change was merged ASAP, bypassing the normal review process,
because it is a follow up for a change that inadvertently resulted in
our Flatpak builds breaking.
Follow-up of 198d49b773ffbe42de619c626fbfb77fe56566c0.
Signed-off-by: TheEvilSkeleton <theevilskeleton@riseup.net>
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
Reference-to: https://github.com/tenacityteam/tenacity/pull/647
Based on the suggestion made by Mart Raudsepp.
"Regular installs should have reverse DNS notation desktop and
metainfo files as well. This becomes important if we ever make use
of things like dbus service activation further down the line. And
renaming it then will break peoples app shortcuts and other things."
Signed-off-by: Leon Marz <main@lmarz.org>
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
Helped-by: Mart Raudsepp <leio@gentoo.org>
Reference-to: https://github.com/tenacityteam/tenacity/pull/642
Although we expect that this change will probably put off long-time Audacity
users, we believe that it's easier to reach the buttons that are used the
most if they are placed on the right.
Controversial change is controversial, but better now than later.
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
Reference-to: https://github.com/tenacityteam/tenacity/pull/402
Doesn't change anything functionality-wise for now, particularly because of
my hesitation with this change as far as hard-coding the version again as a
fallback is concerned.
Audacity's version variable was also reverted in contrast to
56c953a14d343d77f9bf9abb5a6775add50a185a for compatibility reasons with older
project files or for project file compatibility with newer versions of
Audacity.
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
