1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-16 08:09:32 +02:00

137 Commits

Author SHA1 Message Date
Paul Licameli
b81cdee7e3 Comment where xml writing functions may throw 2017-03-18 11:45:05 -04:00
Paul Licameli
cb05476c45 Remove naked new[] in: effects plug-ins 2017-03-17 17:52:48 -04:00
James Crook
e4260e9581 Bug 1587 - Mac: Ghost duplicate Nyquist effects after upgrade
Fix removes ghost Nyquist effects from the effects menu and generators from generate menu.
2017-02-05 20:27:56 +00:00
Paul Licameli
5d5edecca5 Remove unnecessary semicolons 2016-09-18 10:36:53 -04:00
Paul Licameli
ad04187a41 Change sampleCount arguments, variables, return values to size_t...
... whenever they really describe the size of a buffer that fits in memory, or
of a block file (which is never now more than a megabyte and so could be fit in
memory all at once), or a part thereof.
2016-09-15 21:03:17 -04:00
Paul Licameli
67cec5ad83 Make many counts of tracks and channels unsigned...
... And in some places where a library uses signed types, assert that
the reported number is not negative.

What led me to this, is that there are many places where a size_t value for
an allocation is the product of a number of channels and some other number.
2016-09-07 10:11:41 -04:00
Paul Licameli
79c79f9cd3 Remove many mentions of sampleCount with auto and decltype...
... This makes much code agnostic about how other things (functions and
arguments) are typed.

Many of these neeed to become size_t instead of sampleCount.
2016-08-24 14:50:45 -04:00
Paul Licameli
a6de680cdb use std::min and std::max 2016-08-22 21:45:54 -04:00
Paul Licameli
56586770e0 EffectClientInterface::SetSampleRate takes double...
... All the overrides (except Ladspa) were casting it to floating poing anyway
2016-08-21 09:51:32 -04:00
Paul Licameli
49e699b1df Remove overloads for sampleCount from ConfigInterface...
... The value was always cast to int anyway when writing, and it was used
only for one value in VST effect, which did not need 64 bits
2016-08-21 09:11:44 -04:00
Paul Licameli
14c23803ac Various uses of make_unique 2016-08-10 11:05:52 -04:00
Paul Licameli
eb6ba1ed7a Remove some naked new amd delete in: Plug-in effects 2016-08-08 07:51:26 -04:00
Paul Licameli
e0f1e9a5ff Redo previous, not breaking Mac build if wxWidgets is not rebuilt 2016-07-31 14:53:05 -04:00
Paul Licameli
c8e570797f Bug1338 fixed again, with fewer Mac busy-waits; CHANGES WX BUILD...
... Busy-waiting will happen on Mac when modal dialogs are open, and a LADSPA,
VST, or AudioUnits effect is also open with "fancy" interface.

Busy-waiting will not happen for modal dialogs at other times.
2016-07-31 12:46:03 -04:00
Paul Licameli
84c0337aba Fix TAB key navigation on Mac for all dialogs (not only for panels) 2016-07-10 17:12:27 -04:00
James Crook
763485b0dc Add error check comments.
These are places where we don't properly handle error returns.
2016-07-10 21:40:48 +01:00
Paul Licameli
2d7e21536e Sweep for filename copying: prefs and effects 2016-04-10 22:25:49 -04:00
Paul Licameli
e0476b5e71 Module interfaces managed by smart pointers 2016-04-06 16:06:30 -04:00
Paul Licameli
a9afad17ca Plugin instances managed without naked new and delete 2016-04-06 16:06:27 -04:00
Paul Licameli
f87433ac53 Bug1084: Restore the fix, while also keeping the crash bug 1242 fixed. 2016-03-22 13:21:36 -04:00
Paul Licameli
6f4c198771 Bug1242: fixed crash using VST plugin Ambience...
... Problem was a mismatch between a chunk retrieved for program only, but
then copied to slave effect as for a bank.  Plug-in choked on the GIGO.

Fix makes chunk for bank both ways.
2016-03-22 12:39:34 -04:00
Paul Licameli
12adba0c1d Merge pull request #116 from ThomasFeher/fix_warnings_uninitialized
fix -Wmissing-field-initializer (3 occurences)
2016-03-01 17:19:14 -05:00
Thomas Fehér
7e0eb8683c fix -Wmissing-field-initializer (3 occurences) 2016-03-01 20:54:52 +01:00
Paul Licameli
0c9deb398c Fix mac build. No standard headers in Audacity.h. 2016-03-01 12:22:37 -05:00
Paul Licameli
a8652c5e74 uses 2016-02-25 20:18:31 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
99f161c36c Sweep unnecessary wxString copies: effects 2016-02-22 22:31:47 -05:00
Paul Licameli
1c07741d57 Sizers are owned by wxWindow objects when added, so use safenew, or...
... use unique_ptr in the interim between building them and adding.

This checks eliminates some naked news, which were not paired with deletes.
2016-02-18 18:58:38 -05:00
Paul Licameli
4d78e353c3 Revert "sizers"
This reverts commit 84c0a0b6663a1210be502a76ab9c48dd330b3919.
2016-02-18 14:50:52 -05:00
Paul Licameli
84c0a0b666 sizers 2016-02-18 02:54:50 -05:00
Paul Licameli
dbaa811577 Stack-allocate where possible! ...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
df6a7c5464 More uses of safenew for classes we derive from wxWindow classes...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
3f237daddc Use macro safenew for many allocations of wxWindow subclasses 2016-02-14 20:20:19 -05:00
Paul Licameli
7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Kylie McClain
409ebb9a03 Fix building on musl libc 2015-11-21 17:04:43 -05:00
Leland Lucius
00015d4598 Fix for bug #1084
Can you believe I had to change a "0" to a "1"???
2015-08-27 01:55:55 -05:00
Leland Lucius
7414b000c2 More version checks for opcodes added at or above VST 2 2015-08-01 03:49:48 -05:00
Leland Lucius
6a95aae8b3 Better fix for bug #1083
I realized after the last commit that it was probably just a VST
version issue.  The effCanBeAutomated opcode was only added for
VST version 2 and, at least the steroizer effect attached to the
but, was built for a VST version before that.
2015-08-01 01:40:15 -05:00
Leland Lucius
0251dc54e0 Fix for bug #1083 2015-08-01 01:31:26 -05:00
Leland Lucius
b193033d9e Fix Linux build that I broke when I fixed the Windows build 2015-07-29 09:16:32 -05:00
Leland Lucius
e3f1c40c30 Fix Windows Release build 2015-07-29 02:49:45 -05:00
Leland Lucius
ed419f1917 Round 10 of wx3 changes
configure script now auto detects whether wxWidgets was built using
gtk2 or gtk3, so there's no longer a need to specify which one when
running configure.

VST support updated for wx3 under GTK.
2015-07-18 01:22:05 -05:00
Leland Lucius
47f8d10de3 Round 9 of wx3 changes
VST GUI handling greatly simplied on OSX
2015-07-17 23:18:55 -05:00
Leland Lucius
ac4c4faadc Round 8 of wx3 changes
VST control working on Windows...further changes will be required
2015-07-16 14:30:04 -05:00
Leland Lucius
2f760c4bac Round 4 of wx3 changes
This gets FileDialog updated and working on Windows.  It also
removes removes the "wx3" build configurations and makes the default
Debug and Release builds wx3-only.

Still need to get VSTs updated.
2015-07-13 16:38:24 -05:00
Leland Lucius
b8872a4a02 Round 2 of wx3 changes on OSX
Main change is that VST GUI support is now integrate with new Cocoa
views.  Direct support for VST Cocoa views (via Cockos extensions:
http://www.reaper.fm/sdk/vst/vst_ext.php) has been added.
2015-07-11 19:33:04 -05:00
Leland Lucius
a9184af222 Merge remote-tracking branch 'upstream/master' into wx3 is necessary, 2015-07-11 19:23:49 -05:00
Leland Lucius
22c8f7fb76 Pretty sure this is the fix for the crashing VSTs 2015-07-05 13:48:59 -05:00
Leland Lucius
d1f66d768f Updates for wx3
A long way to go yet, but many OSX issues fixed including
conversion of Audio Unit effects.
2015-06-30 11:25:32 -05:00
Leland Lucius
60f4ae1941 Fixing some i18n issues with the plugin settings file 2015-06-05 18:56:24 -05:00