* Revert "AUP3: Don't delete sample blocks prematurely"
This reverts commit c1884349d595a2fb889c90f209ea4af3d1c70e1d.
* "Don't delete sample blocks prematurely" fixed otherwise...
... and very simply.
Problem was that, only for an interactive effect (like Bass and Treble), the
save point was created, rolled back, created again, then committed.
But (unlike with the non-savepoint commands, even if savepoint is outermost),
rolling back a savepoint really just rewinds it without removing it -- therefore
the second savepoint was inner, but the first (outer) was never committed, so
some changes failed to persist.
Solution: add a commit after rollback of savepoint to implement destructor
of AutoCommitTransaction.
The reversion of c188434 also leaves AutoCommitTransaction as a better RAII
style operation. Rollback changes by default -- keep changes only if
success is explicitly indicated.
* Rename AutoCommitTransaction as TransactionScope...
... More appropriately, since it's now the rollback that is automatic but
the commit that must be explicit
Cliff reported that if you apply a macro to "Files" and you had
a "saved project" open at the time, you would get the "not saved
properly" dialog when you next open that "saved project".
This should correct it...
... All old contents of audacity.dox moved to audacity.dox.in;
audacity.dox includes it and changes some options, to be run in nightly updates
of web pages;
nograph.dox also includes it, and is now fit for local usage by the developer,
generating only the same information as audacity.dox before (in only half a
minute on my machine), but easily editable to turn on selected graphs.
... Comments and indentation changes only, with a small bit of code movement to
improve the sequence of items on the Doxygen page.
Comments some obscurities of template usage and of iterators (TrackIter and
TrackNodePointer).
* Don't need TrackFactory to make LabelTrack
* Don't need TrackFactory to make NoteTrack
* Don't need TrackFactory to make TimeTrack, or ZoomInfo in the factory
* Remove some forward declarations
* Rename TrackFactory as WaveTrackFactory, move it out of Track.cpp
Removed redundant OK button.
Also improved positioning of buttons.
Also fixed issue where canceling change appeared to not be respected. (It was being respected, but display was not being refreshed)
At this time it's really just a debugging aid for us. It should
make it easier for us to better understand timing of various
commands.
Tracing is enabled by setting the "/EnableMacroTracing" preference
to 1 and disabled by setting it to 0.
Since the tracing is written to the log, this also adds a "SaveLog"
command that takes a filename. It can be used from within the macro
being traced to preserve the log in case the script intended to
exit Audacity.
Aside from the breakage I added to it during the AUP3 conversion,
there was several other issues discovered in regards to how the
export paths were being handled.
