I've added the comment 'REVIEW:' where I have some concern that
the database and our copy of it could get out of step, or simply that
we fail to report a problem to the user.
I'd like these reviewed and turned into comments that make it
easier to check for correctness, for example saying where an
error is reported, or why it is OK to do no further recovery action.
* Update windows build instructions
* Update download link for VS 2019
* One more 2017 > 2019 text change
* Remove errant dots from a list
* Specify CMake variable name
... The break was caused by ffa67d2 which split the base class AudioIoCallback
out of AudioIO.
This change only demotes some member declarations from AudioIO into
AudioIoCallback, and changes the qualified names of function definitions.
So now you can eliminate #define MIDI_THREAD in AudioIO.h and rebuild.
... This only cuts and pastes some functions from FileNames to another new file
and namespace, and changes namespace qualifiers where they are called.
The cycle resulted because of the need to include widgets/ErrorDialog.h
This is only for information gathering. I don't believe that
simply allowing the use of these two menu items is sufficient.
I believe more work will need to be done, but I wanted to get
it in the QA hands.
If a TAG with Unicode characters outside the normal ASCII
range were saved to an AUP3, you would not be able to reopen
it and you'd receive the following error:
Unable to parse project information.
This changes the way the decimal point is specified in the
PO files...uses '<' for "," and ">" for ".".
By doing this the translator is free to use "." or "," in the
digits fields as their language requires.
... guarantee the gap between producer and consumer is more than one grain, so
that the consumed entry is not still being produced.
Fixes small errors in positioning of the green play head line.
Somewhere along the line the 'rect' passed in to DrawTrackName()changed
from being for the track area to being for the name area. Accordingly
the track rect now has to be explicitly accessed from the track to get
its height, from which the transparency is then derived.