Fix off by one error in size.
Git-bisect indicated a problem (on Mac only) caused by a change in an image file.
It's possible that this is an error in code that we have 'got away with' until now.
We always have an extra zero on the end of the image data and included it in the count of the
size of stream to unpack. For a particular image this may have triggered a memory corruption
problem.
... This required a separate set of changes and testing for the VST version of
SPAN, another for the AU version.
see commit c8e570797f1e7c76750b4a8f24d4fb97c612f7e6
... It made it possible to get into a state where some of the toolbars
stopped responding.
This reverts commit 67b858ed3ff1c6c84fdb1b505e6ccb882471d6f6.
Works by using the newer and better logic of ToolManager for remembering which
window to focus.
It seems, at least on Windows, that when the toolbar with the focused control
is docked after the end of a docking (of itself or another bar), then focus
remains.
If the bar with the focus is undocked and another bar docks or undocks, focus
is still lost.
I think the colours got faded because of colour blending when working with the images,
but I am not 100% sure. Colour blending should be off when doing such work. I recaptured
the unfaded colours from an older png.
The other themes seemed to have OK (unfaded) colours.
... Only the case that you click the grabber and release, or you drag the
toolbar ending in a docked position.
Doesn't work yet when drag ends un-docked.
Necessitated by MIDI support, as many people's local portaudio libs will not be patched.
This also solves some issues with building with lv2 and ffmpeg on some Ubuntu systems.
... I can't reproduce the symptoms on my Mac, but the stack trace supplied by
Gale shows an infinite recursion overflowing the stack.
I see that at commit d1f66d768ffd3823757d2746388074eca95ec138 "Updates for wx3"
by Leland, he saw the need to set a guard against infinite recursion in another
window resizing callback. He tested that guard, but did not set it, in two
other places. I speculate that the cycle can be entered from those other
places, bypassing where the guard was set. So I set the guard in more places.
Developers Brian Armstrong, Henric Jungheim
Updated some library URLs; don't use https:: which causes a crash when you
click the link
Add link for portmidi
... This is distinct from Command, and it abbreviates as the caret ^ character.
Also: show caret instead of "Control" in toolbar button tips, though that
is not done for any default key bindings.
