1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-11-08 06:03:49 +01:00
Commit Graph

1136 Commits

Author SHA1 Message Date
Paul Licameli
6ca89c28ff Remove naked new[] in: builtin effects 2017-03-17 17:52:49 -04:00
Paul Licameli
cb05476c45 Remove naked new[] in: effects plug-ins 2017-03-17 17:52:48 -04:00
Paul Licameli
a4c7d37d3e Remove naked new[] in: effects framework 2017-03-17 17:52:48 -04:00
Paul Licameli
aebaaf46a0 require unsigned arguments for Array(s)Of::reinit 2017-03-17 17:52:43 -04:00
Paul Licameli
38236a807c More new -> NEW, delete -> DELETE in comments 2017-03-17 17:52:41 -04:00
Paul Licameli
ec0297ec28 more safenew 2017-03-17 17:52:41 -04:00
Paul Licameli
ac246d0468 Fix bug 1566 differently (signed/unsigned comparison) 2017-03-17 17:52:37 -04:00
Paul Licameli
37e7b5704a a null check 2017-03-17 17:52:36 -04:00
Paul Licameli
2c0cdda353 Fix dangling pointer bug in lv2 effects 2017-03-17 17:52:35 -04:00
Paul Licameli
7dbb946d29 Propagate progress bar cancellation correctly in Normalize 2017-03-17 17:52:33 -04:00
Paul Licameli
08b99c533b Remove Effect::mWarper, and stack-allocate warpers instead 2017-03-17 17:52:32 -04:00
Paul Licameli
b9e4aa01eb Simplify Normalize by removing needless member variables 2017-03-17 17:52:31 -04:00
Paul Licameli
0af9b46eac Move many fields out of Envelope that are needed only during editing 2017-03-17 17:52:31 -04:00
Paul Licameli
004df48438 Make Effect::mTracks private 2017-03-17 17:52:25 -04:00
Paul Licameli
aa0d55ac83 Use enum class ProgressResult, don't interconvert with int or bool 2017-03-17 17:52:24 -04:00
Paul Licameli
5036583549 Fewer inclusions of AudacityApp.h 2017-03-17 17:52:24 -04:00
Paul Licameli
81285ee0c1 More const and override 2017-03-17 17:52:20 -04:00
Paul Licameli
4913b124b2 Correct the argument passed to OnEffect by EffectRack 2017-03-17 17:52:19 -04:00
Paul Licameli
4c6306e6d6 Fix compilation of old NoiseRemoval 2017-03-17 17:52:17 -04:00
Paul Licameli
dbb2f04def Incomplete fixes for compilation of EXPERIMENTAL_EQ_SSE_THREADED 2017-03-17 17:52:16 -04:00
Steve Daulton
b66675d71c Restore legacy Nyquist plug-in PEAK-LEVEL property 2017-03-01 18:14:30 +00:00
Steve Daulton
f19b79f5c3 Consistency: 'plug-in' not 'plugin'
but retain deprecated / legacy form in code for compatibility.
2017-03-01 18:14:30 +00:00
Steve Daulton
7517b2653e Set minimum size of EditCurvesDialog (bug 470) 2017-02-24 18:52:25 +00:00
Steve Daulton
a80556df2f Bug 1574 - Built-in generators may generate wrong length 2017-02-24 18:52:03 +00:00
Steve Daulton
d9f7b3605f Bug 1576 - Assert when New Length is zero in Change Speed effect 2017-02-24 18:51:39 +00:00
Steve Daulton
67810d35bf Bug 1573 - Multi-line SAL scripts fail in Nyquist Prompt 2017-02-24 18:51:17 +00:00
Steve Daulton
81dd23bd16 Bug 1566 - Incorrect error message if Nyquist returns mono sound as an array
and quieten a load of compiler warnings.
2017-02-24 18:50:30 +00:00
Steve Daulton
1a5a025b70 Update Nyquist v4 property lists and comments
Comments added where documentation is required.
2017-02-24 18:50:28 +00:00
Paul Licameli
7808033421 Fix crash opening menu in some AU effects 2017-02-23 22:52:17 -05:00
James Crook
085489f7e2 Don't scan AudioUnits in fast check of plug-in validity. 2017-02-07 11:57:44 +00:00
Paul Licameli
e84a5b66ba Fix Mac build after commit e4260e9581 2017-02-06 20:31:51 -05:00
James Crook
e4260e9581 Bug 1587 - Mac: Ghost duplicate Nyquist effects after upgrade
Fix removes ghost Nyquist effects from the effects menu and generators from generate menu.
2017-02-05 20:27:56 +00:00
James Crook
53c3adfbe7 Bug 1577 - Application configuration file location incorrect on Linux/case-sensitive Macs
On windows the capitalisation does not matter.
On Mac/Windows we use 'audacity' in path names, even if the directories wxWidgets suggests have 'Audacity'.
2017-01-25 22:15:03 +00:00
James Crook
389b0f197e Improve source for xgettext
1: Mark % as not being treated as print formatting.
2: i18n hint fix.
2016-11-21 10:31:52 +00:00
Steve Daulton
a9d7b6d480 Add Sample Data Import generator 2016-11-20 16:01:59 +00:00
Steve Daulton
52b1c6e00f Update and rename Click Track as Rhythm Track 2016-09-29 21:03:27 +01:00
windinthew
acedbb8640 Fix missing/conflicted access keys 2016-09-27 19:22:00 +01:00
David Bailes
6261bb5a9a Equalization effect: revert one of the changes in commit fcb6221
Revert change in commit fcb6221 which affected behaviour in draw mode.
2016-09-26 09:03:54 +01:00
David Bailes
fcb6221b2c Fix for bug #1517 - Equalization sliders bug
The bug was that when the Equalization effect opens in Graphics mode, the sliders are set to zero, and don't do the right thing. This was caused by my incorrect fix for bug #1346.

Fix is to call UpdateGraphic to set the sliders up. Call to UpdateDraw also added, which includes the appropriate calls to Show, rather than have these in PopulateOrExchange.
2016-09-24 09:26:46 +01:00
David Bailes
3bb2a8b170 Fix for bug #1346 - Equalization effect always opens in draw mode 2016-09-23 13:53:47 +01:00
Paul Licameli
f993f1eadf Regularize casts as (int), so they are easier to find and review 2016-09-20 08:42:11 -04:00
Paul Licameli
b17a14ccc2 Nested loop should use a different index variable...
... but there was not a bug here, because of the return.
2016-09-20 06:32:45 -04:00
Paul Licameli
9310c8ae9b Fix warning about missing field initializers 2016-09-19 11:47:48 -04:00
Paul Licameli
412e4955af Put braces around sub-object initializers 2016-09-19 11:47:47 -04:00
Paul Licameli
53936ac970 Fix some warnings for unused variables and labels...
... But not in cases where a return status is ignored.
2016-09-19 11:47:47 -04:00
Paul Licameli
5d5edecca5 Remove unnecessary semicolons 2016-09-18 10:36:53 -04:00
Paul Licameli
5d102136a2 Fix noise reduction 2016-09-17 15:38:55 -04:00
Paul Licameli
ad04187a41 Change sampleCount arguments, variables, return values to size_t...
... whenever they really describe the size of a buffer that fits in memory, or
of a block file (which is never now more than a megabyte and so could be fit in
memory all at once), or a part thereof.
2016-09-15 21:03:17 -04:00
Paul Licameli
078ff056e2 Make many conversions sampleCount->size_t are explicit and checked...
... with run-time assertions.

I examined each place and reasoned that the narrowing was safe, and commented
why so.

Again, there are places where the sampleCount variable will later be changed
to have a different type, and they are not changed here.
2016-09-15 21:02:32 -04:00
Paul Licameli
78be459fa1 Convert sampleCount <-> floating or -> long long explicitly ...
... A non-narrowing conversion out to long long is a necessity, but the
conversions to float and double are simply conveniences.

Conversion from floating is explicit, to avoid unintended consequences with
arithmetic operators, when later sampleCount ceases to be an alias for an
integral type.

Some conversions are not made explicit, where I expect to change the type of
the variable later to have mere size_t width.
2016-09-15 21:02:31 -04:00