1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-18 00:50:05 +02:00

136 Commits

Author SHA1 Message Date
Paul Licameli
d783762737 Remove unnecessary std::move in return statements...
... and comment where it is necessary.
2016-09-15 07:39:46 -04:00
Paul Licameli
debe935099 Bug1482: fix hangs caused by 8b72bd2f92b27b60a3e631dab53b16750228ea59 2016-08-17 16:49:55 -04:00
Paul Licameli
8b72bd2f92 Manage block files with std::shared_ptr, BlockHash stores weak_ptr 2016-08-16 12:29:59 -04:00
Paul Licameli
84ccdca5c3 Gather balance info hashes into one struct guarded by an accessor...
Doing BalanceInfoDel in this delayed fashion will be needed when the other
call to it is eliminated, as shared_ptr simplifies the management of BlockFile
and makes the many calls to Ref and Deref disappear.
2016-08-16 12:29:59 -04:00
Paul Licameli
cde61edbf4 Don't assume BlockHashes contain non-null pointers ...
... They won't always, when they become weak pointers.
2016-08-16 12:29:59 -04:00
Paul Licameli
e7b4d935a5 Hide the use of new in factory functions for BlockFiles 2016-08-16 12:29:59 -04:00
Paul Licameli
2ede67be96 Use type alias for pointer to BlockFile, which is still a dumb pointer 2016-08-16 12:29:59 -04:00
Paul Licameli
46f38708ed Dir manager uses std::shared_ptr 2016-08-13 12:23:05 -04:00
Paul Licameli
3d102a3390 Access BlockFile::mFileName without copying, with proper multithreading cautions 2016-04-17 13:58:21 -04:00
Paul Licameli
3e6f0bed78 fix bugs in previous 2016-04-17 13:58:21 -04:00
Paul Licameli
b6fdffbab2 Don't copy wxFileName often, it's not lightweight! Use wxFileNameWrapper...
... which is a new class that defines moves.
2016-04-16 11:57:39 -04:00
Paul Licameli
6c2773cb0b This really fixes a bug, but only with certain Experimentals enabled...
... and certain other changes too.  It is involved in code that makes sure
the save of a file with incomplete on-demand loads properly waits for them
to finish.  It should not really affect production.

The experimentals are EXPERIMENTAL_OD_FLAC and EXPERIMENTAL_OD_FFMPEG.
2016-04-11 14:04:55 -04:00
Paul Licameli
df28289058 Avoid repeated calls to BlockFile::GetFileName...
... because wxFileName is not a featherweight.
2016-04-11 09:46:00 -04:00
Paul Licameli
f94b3b3afa Add some const qualifiers to BlockFile methods 2016-04-10 21:05:20 -04:00
Paul Licameli
0c9deb398c Fix mac build. No standard headers in Audacity.h. 2016-03-01 12:22:37 -05:00
Paul Licameli
1398d1a953 Fix warnings for ambiguous else 2016-02-26 14:56:29 -05:00
Paul Licameli
a8652c5e74 uses 2016-02-25 20:18:31 -05:00
Paul Licameli
9bf098c7d9 Sweep unnecessary wxString copies: rest 2016-02-23 02:15:56 -05:00
Paul Licameli
dbaa811577 Stack-allocate where possible! ...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343 "delete"->"DELETE" in comments, easier to find remaining naked operator delete 2016-02-14 18:50:45 -05:00
Paul Licameli
38ba19183d One less indirection accessing SeqBlock 2016-02-03 22:17:07 -05:00
Leland Lucius
7bc176f5ac Just adding some comments for later work 2015-08-14 18:40:29 -05:00
Paul Licameli
d39eaa4e65 Remove WaveTrack.h from other headers 2015-07-28 10:02:05 -04:00
Paul Licameli
7b01339e51 Future subclasses of PrefsDialog may choose the preferred page by other means. 2015-07-26 19:53:15 -04:00
Daniel Winzen
759ff8cd0d Performance improvements 2015-04-23 16:07:25 +02:00
lllucius
09c213feed Applying Paul's fix for bug #818
While I didn't see the crash in action, the patch definitely
fixes the possibility of one.
2015-01-20 06:34:55 +00:00
lllucius
f60afbb8da Fix disk space checking to prevent error message
The error message only happens in debug builds, but the cause of
the message still happens in release builds.  Basically, the temporary
project directory may not yet be created if the person is only monitoring.
2015-01-06 16:16:01 +00:00
james.k.crook@gmail.com
8a9987a0d9 From: martin@steghoefer.eu [PATCHES 02-15 of 15] Fix runtime problem with wxWidgets 3.0:
Correct string formatting for:
2/15  %d + enum => %d + int
3/15  %lld + int64_t => %lld + long long
4/15  %d + int64_t => %lld + long long
5/15  %d + double => %f + double
6/15  %d + int32_t => %d + int
7/15  %d + intptr_t => %p + void*
8/15  gint, guint
9/15  %d + long => %ld + long
10/15 %n + int => %d + int
11/15 %x + int => %x + unsigned int
12/15 %f + int => %d + int
13/15 %S + wxChar* => %s + wxChar*
14/15 %d + size_t => %d + int
15/15 %d + size_t => %lld + long long

"The functions wxString::Format, wxString::Printf (and others indirectly) have become stricter about parameter types that don't match (format specifier vs. function parameters). So the bugs (that were already present in audacity before) become visible in wx3.0 as error message dialogs. I've checked all occurrences of Printf, wxPrintf, PrintfV, Format, FormatV, wxLogDebug and wxLogError systematically and made the type match."

Note (9/15): In TrackPanel.cpp, ExportMP2.cpp and CompareAudioCommand.cpp this patch supersedes related change done in r13466 because the new solution requires fewer casts and therefore simplifies the code.

Note: Many .po files are affected, and we need to be very careful about this.  Incorrect "%d" and similar in translation files may lead to crashes in those languages (only).  This is something we should actually have been more careful about in the past.  We need to write a script to check that the "%d" and similar format specifiers match between English and translation.
2014-11-08 16:42:34 +00:00
benjamin.drung@gmail.com
277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
v.audacity
cc876ce7be just some cleanups on FIXMEs and unused method parameters 2013-08-31 05:57:48 +00:00
v.audacity
c7daafede2 In off-list discussion, Steve mentioned that kdevelop / kate highlighting recognizes "FIXME", but not "FIX-ME", which has been the Audacity convention. This commit changes Audacity code to use the "FIXME" convention (though I've never known it as convention and MSVC doesn't recognize it).
Also, minor change in WaveTrack.cpp in the effort on bug 641. Should have no functional difference.
2013-08-24 20:30:47 +00:00
v.audacity
9d0daf8662 Campbell Barton's patch to turn many, many tabs to our 3-space convenbtion 2013-02-20 23:42:58 +00:00
v.audacity
a42f5b45cb http://bugzilla.audacityteam.org/show_bug.cgi?id=545 (P2)
Remove crash-prone "Audio Cache" feature.
2012-07-18 01:18:59 +00:00
james.k.crook@gmail.com
dd97cae3d9 Removed some (hidden) Cleanspeech cruft that had been used to disable effects. Made some static text open to translation. Added more i18n hints (thanks Thomas Breinstrup). 2012-04-05 11:21:15 +00:00
james.k.crook@gmail.com
69476e785c Fixed more internationalisation hints. 2012-03-20 15:36:02 +00:00
v.audacity
7a57f8efce Fix overlong string in dialog. 2011-12-12 22:35:57 +00:00
v.audacity
618df78900 "Blockfile" -> "Block File" in interface. 2011-11-16 01:12:35 +00:00
v.audacity
2bac0a07ed rewordings per http://bugzilla.audacityteam.org/show_bug.cgi?id=451#c21 2011-11-15 04:03:01 +00:00
v.audacity
75ab958ef9 rewordings per Martyn's suggestions regarding test project for bug 451, where conversion from 1.2 format says save will make it permanent and irreversible, but DirManager::ProjectFSCK() was not making it clear when choices make a Save. 2011-10-28 02:29:15 +00:00
v.audacity
04d3e77632 Rewording and re-ordering of orphan blockfiles alert, per Martyn's suggestion.
Add project data folder name to most ProjectFSCK alerts.
2011-10-28 01:32:47 +00:00
v.audacity
4e81f0ed5a Change "blockfile" to "block file" consistently in log and error dialogs. 2011-10-16 23:12:00 +00:00
v.audacity
3d39a8d560 rewording per Gale's suggestion re bug 451 2011-10-16 23:10:55 +00:00
v.audacity
1f352b0157 (bug 451, P2) Add more error checking and increase specificity of Sequence-reading code.
Add wxLogWarning messages to AudacityProject::OpenFile()

Fixed correction for "A linked track's partner should never itself be linked" to remove the link from the partner, not the original (left).

Fix possible NULL pointer dereference in previous commit.
2011-10-13 22:52:55 +00:00
v.audacity
4d1e18d8fd In DirManager.cpp, probably fixed bug 451, by not deleting over-long blockfile.
Made Sequence::HandleXMLEndTag log errors more specific.

Differentiated "Gap detected in project file" error messages.
2011-10-12 05:40:23 +00:00
mchinen
7b04d6518d comments - explanation of blockfile filename/dir structure 2011-10-11 19:24:47 +00:00
v.audacity
3a1d4334f2 Make wxLog* calls consistently not have \n at the end. Turn some wxLogWarning calls to wxLogError. Put some periods at the ends of sentences. 2011-10-09 21:14:03 +00:00
v.audacity
63c2698b70 Change wordings per http://wiki.audacityteam.org/wiki/Bug:137#Wording_and_Options_in_Dialog. 2011-09-15 23:54:23 +00:00
martynshaw99
9d77cd4638 Don't delete the _data dir - simplified version of Ed's patch. 2011-06-27 23:18:33 +00:00
v.audacity
fb5e062c42 Responding to suggestion at http://bugzilla.audacityteam.org/show_bug.cgi?id=20#c46, changed it to "current" rather than "existing." 2011-06-20 21:16:46 +00:00