1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-25 08:58:06 +02:00

471 Commits

Author SHA1 Message Date
Paul Licameli
c438925a22 Use Destroy_ptr for the toolbars 2016-08-10 11:05:51 -04:00
Paul Licameli
fec4069d9d Some uses of Destroy_ptr let us remove some naked news 2016-08-10 11:05:51 -04:00
Paul Licameli
13e056de43 More uses of safenew 2016-08-08 10:07:37 -04:00
Paul Licameli
a52f7f8410 new -> NEW in comments, so text search for naked new excludes them 2016-08-08 10:07:37 -04:00
Paul Licameli
52d12c6913 Remove some naked new amd delete in: toolbars 2016-08-08 07:51:25 -04:00
Steve Daulton
976a5eb5ec Fix bug 1466
Display just the button name in tooltip when no shortcut.
2016-08-03 00:28:00 +01:00
Gale Andrews
e05d8aedd5 Corrected missing closing period 2016-07-27 18:21:59 +01:00
windinthew
e24d6d825f Bug 858: Update recording error message too
Also remove redundant 'while' in the messages
2016-07-27 16:48:30 +01:00
Steve Daulton
6629733d35 Bug 858 - Update error message
Trying Gale's suggestion from
http://bugzilla.audacityteam.org/show_bug.cgi?id=858#c2
2016-07-24 16:35:17 +01:00
Steve Daulton
d655ea1c81 Fix bug 1449
Reduce height of Device ToolBar required by Gnome.
2016-07-17 22:23:16 +01:00
James Crook
d092fe0e4b Review and fix CaptureMouse (per Bug 1204 commit comment)
This is using the same idiom of only capturing if not capturing already.  These cases in AutoDuck, Resizing, Grabber and TQP might have been latent ASSERTs.  This based on precedent rather than actual elicited buggy behaviour.
2016-07-17 09:38:23 +01:00
Paul Licameli
84c0337aba Fix TAB key navigation on Mac for all dialogs (not only for panels) 2016-07-10 17:12:27 -04:00
Steve Daulton
4c019a2b03 bug 1415 Display device toolbar on Linux Xfce
Please check on other platforms, including re-launching with
floating toolbars.
2016-07-03 23:43:32 +01:00
James Crook
c93cb1b445 No return value for ClearBar() 2016-07-03 14:39:45 +01:00
Paul Licameli
9dfa646221 Bug1430: Don't crash resetting toolbars with legacy .cfg files 2016-07-03 05:05:01 -04:00
Paul Licameli
db2ee75c0a Fix docking of, e. g., scrubbing toolbar right of device 2016-07-02 13:14:14 -04:00
Paul Licameli
37798bfa6b But don't let that safety negate the fix now! 2016-07-02 13:14:14 -04:00
Paul Licameli
63f9875066 Make previous fix safer 2016-07-02 11:11:41 -04:00
Paul Licameli
28011280d0 Tool bar resizes orig focus at mouse up or ESC key, at least on Mac 2016-07-02 10:48:07 -04:00
Paul Licameli
625584d99a Bug1431: Undocked toolbars should hide when project window minimizes 2016-06-29 15:13:38 -04:00
Paul Licameli
b29cc8ae48 Class ToolFrame is defined in a header, methods out of line 2016-06-29 13:44:59 -04:00
Paul Licameli
7315af547f Bug1424: Better positioned scrubbing tool bar with legacy .cfg file 2016-06-25 23:36:40 -04:00
Paul Licameli
107507e125 Revert "fix mac build"
This reverts commit 2910cc2a6f1ad91c0aa5c63fa6c5f9e940107bdd.
2016-06-25 22:17:24 -04:00
Paul Licameli
2910cc2a6f fix mac build 2016-06-25 22:15:45 -04:00
Paul Licameli
4739f3e27b Compensate for wxW 3 tab navigation deficiencies on Mac...
... using char hook event handlers.  We don't need to go the extreme length
of patching wxWidgets source.
2016-06-25 19:14:05 -04:00
Paul Licameli
ae14cb0dbc Allow tabbing to the button on the time ruler...
... by making the ruler and the upper tool dock part of one panel
2016-06-25 16:08:38 -04:00
Paul Licameli
fe509ed412 Fix drawing of focus rectangles in buttons, meters, sliders on Mac 2016-06-25 16:08:37 -04:00
Paul Licameli
6a4d6ceeda Separate source files for ScrubbingToolBar 2016-06-25 15:05:17 -04:00
Paul Licameli
de9579dbe9 Bug1193: Mac font sizes as in 2.1.1 for ruler, sel toolbars 2016-06-22 14:21:04 -04:00
Paul Licameli
21ea9a5ead Bug1201: Be sure tool tips show for toolbar grabbers and resizers 2016-06-22 14:00:30 -04:00
Paul Licameli
d6187f6972 Ensure correct update of Selection bar tooptips for language change 2016-06-21 00:15:37 -04:00
Paul Licameli
07cf46826a Scrub bar tooltips mention shortcut keys 2016-06-15 23:26:35 -04:00
Paul Licameli
8cba525b6c No more separate start/stop button on Scrubbing toolbar...
... This finalizes (I hope) the set of buttons, but maybe not their left to
right order.

Behavior of the scrub bar is still not settled.
2016-06-15 21:20:40 -04:00
Paul Licameli
8b966ae2c1 Merge branch 'master' of github.com:audacity/audacity 2016-06-15 07:19:09 -04:00
Paul Licameli
b1ca48c23e Scrub bar show/hide button on Scrubbing toolbar 2016-06-15 01:11:42 -04:00
David Bailes
b011fc4c6b Fix toolbar resizers being in tab traversal
In commit 89e33da, the override of AcceptsFocus() was removed from the ToolBarResizer class so that ESC could cancel resizing. However this meant that the toolbar resizers were included in the tab traversal of the toolbars.

The fix is the same one that was used to fix the problem with the toolbar grabbers being in the tab traversal: override AcceptsFocusFromKeyboard(), rather than AcceptsFocus().
2016-06-14 14:18:44 +01:00
Paul Licameli
2a075558ce Suppress duplicate tool dock points that don't give distinct results 2016-06-13 19:15:43 -04:00
Paul Licameli
4aa380f82a Don't narrow toolbars on Windows when they re-dock 2016-06-13 14:46:19 -04:00
David Bailes
72c397112f Fix that the Device toolbar can be higher than it should be.
This happens on Windows 7 if the display scaling factor is set to 125% (and probably higher). This also happens on Windows 10, but only if in addition to the high scaling factor, the display scaling at high DPI is disabled on the compatibility tab of audacity.exe's properties dialog. (The behaviour on Windows 8.1 wasn't checked.) The effect of the toolbar becoming higher, is that on a row of a tooldock, no other toolbar can be in front of the Device toolbar.

In void DeviceToolBar::RepositionCombos(), the desired size of the combo boxes was set to the best size.

The fix is only use the x value of the best size, and leave the y value unchanged. Note that this may not be the only problem in the code which causes this problem, and so this problem may resurface in the future.
2016-06-13 17:50:12 +01:00
Paul Licameli
c3437b1d6e Fix Windows build, and some compilation warnings 2016-06-13 09:42:24 -04:00
Steve Daulton
78e16f6e20 include <algorithm> to fix Linux build 2016-06-13 08:38:54 +01:00
Paul Licameli
c101f4acdb Enable yet more docking positions by wrapping the cofiguration 2016-06-12 20:21:09 -04:00
Paul Licameli
de17c1ac3a Toolbar placements can push other bars down as well as right 2016-06-12 20:21:09 -04:00
Paul Licameli
37962dd9a8 Visitors unify layout routines; now any bar can stick at lower left 2016-06-12 20:20:51 -04:00
Paul Licameli
3df50f8184 Define the default toolbar configuration (as a tree) 2016-06-12 19:32:52 -04:00
Paul Licameli
65b3d32894 Tool bar configuration stores a tree structure, not a simple sequence 2016-06-12 19:18:56 -04:00
Paul Licameli
7f920ecd0d Starting to make ToolBarConfiguration::Position more general 2016-06-12 12:41:52 -04:00
Paul Licameli
ffb681e658 Delegate reading and writing of toolbar configuration to new class 2016-06-12 10:55:47 -04:00
Paul Licameli
3c13c6eaa6 ToolDock::OnPaint assumes less about configuration details 2016-06-12 10:29:45 -04:00
Paul Licameli
b46e263afb Abstract ToolBarConfiguration further, with an iterator class 2016-06-12 10:27:54 -04:00