Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-03 14:13:11 +02:00
Code Issues Releases Wiki Activity
7,430 Commits 23 Branches 23 Tags
Commit Graph

179 Commits

Author SHA1 Message Date
Paul Licameli
d783762737 Remove unnecessary std::move in return statements... 
... and comment where it is necessary.
 2016-09-15 07:39:46 -04:00
Paul Licameli
39d514b183 Some more const, some stl idioms, remove unused declaration 2016-09-13 22:03:58 -04:00
James Crook
65c7e8051a ThomasFeher - Unused parameters clean up. 2016-09-11 20:31:49 +01:00
Paul Licameli
67cec5ad83 Make many counts of tracks and channels unsigned... 
... And in some places where a library uses signed types, assert that
the reported number is not negative.

What led me to this, is that there are many places where a size_t value for
an allocation is the product of a number of channels and some other number.
 2016-09-07 10:11:41 -04:00
Paul Licameli
8e42f8a61a Fix progress indicator again: must do a floating-point division... 
... or else just get zero!
 2016-08-26 12:42:22 -04:00
Paul Licameli
fd2b050d6f Type agnosticism for some other variables that were not sampleCount... 
... in some cases, this fixes narrowings.
 2016-08-24 14:50:45 -04:00
Paul Licameli
b5e410d987 Fix Windows build differently 2016-08-24 12:13:53 -04:00
James Crook
781de82d02 Workaround build breakers. Needs review. 
These changes fix a broken build in Windows.
#include <algorithm> needed for min/max to be in std.
decltype(+name) was declaring a const variable, that could not be incremented.  Changed to auto.
 2016-08-23 21:46:12 +01:00
Paul Licameli
1281f1b14b Common function limits buffer size to sampleCount known to be small 2016-08-23 12:46:10 -04:00
Paul Licameli
2969336258 Fix bug in update of progress in CompareAudioCommand 2016-08-21 09:52:10 -04:00
Paul Licameli
41efaeeef0 Fix Windows build 2016-08-14 09:35:04 -04:00
Paul Licameli
b6241c46d3 Remove a few more naked new in CommandManager.cpp 2016-08-13 10:37:52 -04:00
Paul Licameli
57afa1399e Remove some naked new amd delete in: commands 2016-08-08 07:53:29 -04:00
Paul Licameli
c3e53ea26e Remove some naked new amd delete in: overrides of CommandType::BuildSignature 2016-08-08 07:53:29 -04:00
Paul Licameli
81228eac0e Improve the fix for the Ctrl+F6 cycle 2016-06-30 11:00:56 -04:00
Paul Licameli
e9cf0a8335 Bug1252: Ctrl-f6 cycle works on Mac even when combo has focus 2016-06-23 10:35:45 -04:00
James Crook
6bc7924b16 Bug 1378 - Screenshot Tools images are mostly white background only. 
Use 24 bit bitmap rather than default which is 32 bit.  Seems to be a wxWidgets 3.0.2 bug with ScreenDC.
 2016-06-23 11:33:58 +01:00
Paul Licameli
8dfaa4dcf8 Implement translation of shortcut key names to Mac special chars 2016-06-11 20:31:03 -04:00
Paul Licameli
f5c4c85653 New scrubbing toolbar; remove ruler pushbuttons. 2016-06-05 01:03:24 -04:00
Paul Licameli
0d9d8a057d Revert "Disable scrubbing when pause button is down." 
This reverts commit 97fdce5f85e884cbe6f161963789694015cdf328.
 2016-05-06 11:32:56 -04:00
Paul Licameli
97fdce5f85 Disable scrubbing when pause button is down. 2016-05-05 22:48:23 -04:00
Paul Licameli
014d5ab93c Type safety in the use of command flags, and make enum wide, allowing more bits 2016-05-05 20:02:13 -04:00
Paul Licameli
3d222bcd87 Context menu for scrubbing in the ruler 2016-04-26 12:12:06 -04:00
Paul Licameli
bc80ffe766 Windows build fixes 2016-04-24 01:12:42 -04:00
Paul Licameli
367b2c1011 Move command functors to a new header file, and generalize with templates... 
... so that member functions of other than AudacityProject may be called.

Will use this new generality soon for scrubbing menu items.
 2016-04-23 02:05:36 -04:00
Paul Licameli
ce95bce85a Bug991: Pause button and command should be disabled during scrubbing... 
... and they will be as soon as ctrl-mouse down.
 2016-04-18 21:49:27 -04:00
Paul Licameli
185d5e132d Avoid some wxString copies 2016-04-17 13:58:21 -04:00
Paul Licameli
f9da767cbd Remove a friend declaration from Project, privatize a pointer member... 
... and make implementation of that pointer a smart one.
 2016-04-11 14:42:57 -04:00
Paul Licameli
70bd46b8ad travis 2016-04-09 22:55:15 -04:00
Paul Licameli
fd8fa69c62 Singleton CommandDirectory used to leak! 2016-04-06 16:06:32 -04:00
Paul Licameli
3481e678ea Manage the members of CommandOutputTarget with smart pointers 2016-04-06 16:06:12 -04:00
Paul Licameli
e8ad90b3c9 Manage Commands and CommandOutputTarget objects with smart pointers 2016-04-06 16:05:28 -04:00
Paul Licameli
f4441d7476 Command validator cloners return smart pointers, and... 
... defined DefaultValidator so Validator can be abstract, as the comment for
Clone() stongly implies it should be.

But this is virtual is unused except in comments.
 2016-04-06 16:05:21 -04:00
Paul Licameli
83e9e7de97 Clone functions required by wxWidgets base classes can use safenew 2016-04-06 14:08:43 -04:00
Paul Licameli
de75a00c10 Define movable_ptr and make_movable, use __AUDACITY_OLD_STD__ in fewer places 2016-03-25 20:27:25 -04:00
Leland Lucius
9dc9348127 Fixes bug #1344 (mac build) 
In addition, the Xcode project can now build against the 10.6
or 10.7 SDKs.  All that is needed is to change the SDK version
and the other settings will change automatically.
 2016-03-07 00:29:26 -06:00
Paul Licameli
057ec565de Fix #includes 2016-03-04 14:32:24 -05:00
Paul Licameli
0c9deb398c Fix mac build. No standard headers in Audacity.h. 2016-03-01 12:22:37 -05:00
Paul Licameli
60bcd7aea2 Fix warnings for unused variables and functions 2016-02-26 14:56:26 -05:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual... 
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
 2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)... 
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
 2016-02-24 20:58:30 -05:00
Paul Licameli
0c182c3c0b Shrink the command functor objects by using more subclasses... 
... Let virtual function dispatch do the work, don't write our own dispatch!
 2016-02-24 15:17:06 -05:00
Paul Licameli
923a6ce4af Sweep unnecessary wxString copies: commands 2016-02-23 01:40:21 -05:00
Paul Licameli
cf3daebff6 Reviewed allocations of wxMenuBar items. 2016-02-20 20:23:54 -05:00
Paul Licameli
00db530c9b Don't eliminate indirection for CommandListEntry. Explain why. Use unique_ptr 2016-02-19 10:49:50 -05:00
Paul Licameli
d9c2ff6dc2 fix compilation 2016-02-19 01:39:44 -05:00
Paul Licameli
e0c88b1e53 Remove needless indirection for more little structures, in CommandManager... 
... Also use std::shared_ptr for functors to simplify resource management
 2016-02-18 20:19:27 -05:00
Paul Licameli
7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343 "delete"->"DELETE" in comments, easier to find remaining naked operator delete 2016-02-14 18:50:45 -05:00
Paul Licameli
12a2d066ba Bug1306: Kestroke shortcuts for sub-menu entries now work again... 
... for instance, Align sub-menu of Tracks.
 2016-01-27 16:10:46 -05:00