Paul Licameli
0d9972b3e0
Some member functions of AudioIO can be const
2018-08-10 22:58:33 -04:00
Paul Licameli
f036700b09
Make PlaybackSchedule::mTime atomic and rename some functions...
...
... The variable ought to be atomic because it is read and written by different
threads.
Use local variables to avoid repeated reads of the atomic.
2018-08-10 21:30:14 -04:00
Paul Licameli
8a78ae280c
Factor out a piece of the big callback
2018-08-10 17:33:18 -04:00
Paul Licameli
af81dfa10b
Bug1922: updating play indicator when looping with a time track
2018-08-09 13:18:53 -04:00
Paul Licameli
871bc65c8e
Fix loop play again (error introduced at 46d7804)
2018-08-09 11:39:51 -04:00
Paul Licameli
6f7eaf7746
Fewer calls to GetActiveProject() in AudioIO.cpp
2018-08-08 17:30:43 -04:00
Paul Licameli
2472b128d3
Fix compilation of EXPERIMENTAL_AUTOMATED_INPUT_LEVEL_ADJUSTMENT
2018-08-08 17:08:54 -04:00
Paul Licameli
197122c7d5
Collect initialization of playback schedule into a function
2018-08-08 16:36:42 -04:00
Paul Licameli
6e4d11e5af
Fix loop play
2018-08-08 14:26:32 -04:00
Paul Licameli
46d7804cdf
Group some of the fields of AudioIO into PlaybackSchedule
2018-08-08 14:10:21 -04:00
Paul Licameli
175a471261
Remove " == true"
2018-08-08 12:34:47 -04:00
Paul Licameli
fc8783bc74
Put callback in a member function, remove many more gAudioIO->
2018-08-08 12:30:10 -04:00
Paul Licameli
fc497368a5
Remove needless gAudioIO-> in member functions (AudioIO is singleton)
2018-08-08 12:30:10 -04:00
James Crook
f0637eeb85
Bug 1906 - Issues with dynamic Play-at-Speed (Play doesn't pop up)
...
Fixed issue 1, i.e. the play button does not pop up after play at speed completes.
2018-07-21 21:14:30 +01:00
Paul Licameli
2c7ca97095
Reimplement change of color of playhead after pre-roll, more simply
2018-06-11 18:27:18 -04:00
Paul Licameli
77779395c7
Revert "Play head is green during pre-roll, then turns red for real recording"
...
This reverts commit 8e51391b98ad7a98f49c98929a10322dd551391f.
2018-06-11 18:23:56 -04:00
Paul Licameli
8e51391b98
Play head is green during pre-roll, then turns red for real recording
2018-06-09 14:40:09 -04:00
Paul Licameli
c0fb140257
Fix crashes in resampling of capture during recording
2018-06-01 12:53:26 -04:00
Paul Licameli
a0256e935c
Recording options allow crossfade data for start of recording
2018-06-01 04:28:58 -04:00
Paul Licameli
f9cd5595d5
Stop playback of pre-rolled tracks at the right time
2018-06-01 04:28:57 -04:00
Paul Licameli
35c60ac96d
Allow for preRoll in start-stream options
2018-06-01 04:28:55 -04:00
Paul Licameli
20f3f76e2f
Correct limit of record duration when track rate differs from input
2018-06-01 04:28:54 -04:00
Paul Licameli
35a97e09e7
Group arguments to StartStream, and a bit less of #ifdef for MIDI play...
...
... And pull choice of tracks and options out of DoRecord
2018-05-29 00:22:12 -04:00
Paul Licameli
f355320e5d
Don't lose the fractional part of latency prefernce setting!
2018-05-28 16:13:45 -04:00
Paul Licameli
f32073412b
Fix precision of right edge of punch-in when not overdubbing too
2018-05-26 23:59:21 -04:00
Paul Licameli
a3abacd55d
Adjust for latency as you record, don't wait till after stopping...
...
... Adjust whenever recording, regardless whether there is any overdub
playback too.
May adjust by discarding samples when the Track Shift after Record preference
is negative (as by default); or, by inserting silence into the start of the
recording, when that preference is positive, though that may be less useful.
Perhaps the preference control should no longer be called "Track Shift after
Record."
2018-05-25 07:21:46 -04:00
Paul Licameli
0887d6d01e
When recording into region selection, stop it precisely
2018-05-24 17:05:44 -04:00
David Bailes
a22be24ae3
Bug 1863: Windows crash when resampling in WASAPI
...
Problem: soxr_process doesn't like being called with length of buffers equal to zero.
Fix: don't call it, when this is the case.
2018-05-22 11:34:12 +01:00
Paul Licameli
1269fff8e1
Ignore the time track during overdub recording.
2018-05-17 15:49:53 -04:00
James Crook
b60fae4470
Fix some warnings on mac
...
These are mostly missing 'overrides'
2018-04-07 20:28:27 +01:00
Paul Licameli
2ea5741e2e
Redo format setting choices in Quality preferences
2018-03-25 14:46:53 -04:00
andheh
3dd0ce0459
fixed a signed vs. unsigned warning in src/AudioIO.cpp
2018-03-06 20:54:06 +00:00
andheh
1efe69e8b9
fixed a initialization order warning in src/AudioIO.cpp
2018-03-06 20:54:06 +00:00
James Crook
6509947de8
Fix some MSVC warnings.
2018-03-02 12:04:37 +00:00
Steve Daulton
1ef4d73629
bug 1839 - Consistent recording behavior
...
Same behavior whether there is playback or not.
2018-02-28 21:20:06 +00:00
James Crook
11fa48d66f
Fix some warnings.
2018-02-27 22:26:23 +00:00
James Crook
636e137ee8
Merge pull request #257 from Polynomial-C/no_midi
...
Fix --without-midi build
2018-02-22 17:26:56 +00:00
Paul Licameli
8be1e8fdad
Remove wxArray(Int|Long|Double) except where wxWidgets fns need it
2018-02-21 19:33:31 -05:00
Paul Licameli
2fbe04eda0
Replace more Connect with Bind; needed redeclaration of custom events
2018-02-21 19:30:40 -05:00
Paul Licameli
12983e1685
Use wxWeakRef to avoid dangling pointer
2018-02-21 19:25:04 -05:00
Paul Licameli
c0f2782695
Fix interaction of recording and undo...
...
... in case you also do things, concurrent with the recording, that affect the
undo stack, either by pushing it (such as by changing the gain on one of the
playing tracks, or making a label) or by "Modifying state" without a new undo
item (such as when you change its size or mute or solo).
2018-02-21 19:21:00 -05:00
Paul Licameli
57ce726a25
Rename Meter as MeterPanel, and some DOxygen
2018-02-21 17:50:28 -05:00
Matt Whitlock
e1f0e974d0
Fix --without-midi build
...
See downstream bug: https://bugs.gentoo.org/637110
2018-02-21 12:19:19 +01:00
Paul Licameli
f78a418df8
An alpha-only toggle command for extra dropout detection; default off
2018-01-17 20:35:56 -05:00
Paul Licameli
81b22a2b2b
Reimplement the insertion of zeroes at drop-outs...
...
... and correct for latency only when there is at least one playback track
2018-01-17 12:56:35 -05:00
Paul Licameli
e066c4f38d
Insert zeroes only if dropout detection is enabled
2018-01-16 14:28:07 -05:00
Paul Licameli
130e55cdf5
Use WarningDialog for drop-outs, and change the wording
2018-01-16 13:56:44 -05:00
Paul Licameli
b0690a2a5c
Disable part of the drop-out detection...
...
... The part that checks the previously unused statusFlags argument of
audacityAudioCallback can make zero-length labels. I did provoke this into
happening repeatably on macOS using a debug build, zero buffer length in device
preferences, and a busy CPU running other programs, within just two minutes of
recording.
But close zooming in on the label, and listening, revealed nothing obviously
wrong, no click in the playback. So I consider that a false positive.
But the part of the drop-out detection that would make nonzero length
labels, because the other AudioThread is lagging in its writes to disk --
this part remains. Yet I have not yet provoked this into happening.
2018-01-15 19:33:54 -05:00
Paul Licameli
d2749068f1
Allow reporting of drop-outs to be turned off by Recording prefs...
...
... Just in case it turns out to make some false positives.
2018-01-15 18:48:44 -05:00
Paul Licameli
9777d3e880
Alert user to drop-outs during recording...
...
1) When the program detects this, insert zeroes into the recording to keep the
other good parts synchronized.
2) When recording stops, a message box alerts the user, and a label track is
added showing the lost parts, labelled with consecutive numbers.
3) A menu item visible in alpha builds only is added to Tools, to simulate
recording errors at random times and test the reporting feature.
2018-01-15 14:48:39 -05:00