Adding "apt-get update" to hopefully fix the Linux build. I thought
Github would "fix" the image, but it doesn't hurt to have the update
in there anyway.
And fix the Mac Info.plist version.
Forgot to actually exclude mod-null and mod-nyq-bench from the
build.
Fixed a few typos.
And removed "zip" from the package install on Ubuntu since it's
not needed anymore.
Restore the wxDEBUG_LEVEL defines for the module builds. It is
currently required (see explanation in CMakeLists.txt)
Add explanantion of why wxWidgets_USE_REL_AND_DBG=NO is needed
for the Github Windows build.
Further restrict the disabling dynamic loading for Windows and Mac
of the Lame and FFmpeg libs. Some corrections need to be made in
ExportMP3.cpp (and probably some for FFmpeg as well).
And don't build mod-nyq-bench or mod-null by default until they
can be fixed. (They fail to build.)
Visual Studio NuGet package handling was redone to correct a
chicken and egg situation. (See the nuget_package() function
in audacity/CMakeLists.txt.
Due to the change in NuGet handling, was finally able to make
the Audacity target dependent on several other targets. This
ensures the destination directory is populated correctly.
Library handling for system packages reworked to ensure the
correct libraries are used and to "workaround" an issue where
the libraries weren't being included in the link command...no
idea why. New way is better anyway.
Don't allow a system library for SBSMS since it seems we have
a unique (Audacity-only???) version.
Don't define wxDEBUG_LEVEL. It's not needed and causes duplicate
symbol warnings.
A couple of small changes to config files to remove libmad and
libsndfile warnings.
Do not include serdi.c and sordi.c in the LV2 build.
Fix handling of static Lame and linked FFmpeg libs.
Use cmake file() instead of gcc/awk to extract version information
from Audacity.h for the Mac Info.plist.
Use "cmake -E tar" to zip artifacts in github action.
Fix was provided by Hans Petter Selasky with the following comment:
This is a regression issue after:
Move the scrub mouse event handler into ScrubUI...
Where:
if (mWindow)
mWindow->PushEventHandler(&mForwarder);
was removed from the Scrubber() constructor function and
not from the ~Scrubber().
Problem:
Screen readers don't automatically read the units of the values in text boxes.
Fix:
Add units the the accessibility name of the text boxes.
Thanks to Paul for providing ShuttleGui::NameSuffix(), which makes the code neat and readable.
Problem:
If a new version of Audacity introduces a new default shortcut, or changes an existing one, then this may be the same shortcut as a user has previously assigned to another command. Both commands will have the same shortcut, and the shortcut will only execute one of those commands.
Fix:
Check for any such duplicates when a user opens a version of audacity using an audacity.cfg file which was created with a different version.
For each duplicate found, remove the shortcut from the command which has a new or changed default.
If duplicates where found, open a message box informing the user of the removed shortcuts.
... such as Nyquist Workbench.
I don't fully understand why, but destroying the menu registry items very late,
during the destruction of static objects, causes a crash in memory deallocation,
at least on Mac.
So destroy the menu registry explicitly in application shut-down.
- The TCP cursor is indicating both selection and dragability, so we use the arrow (as UI for tabs does, which are selectable and draggable).
- When actually dragging, we use the clenched fist icon, not the new clenched fist with the fingers cut off icon (aka snowball icon).
Big Thanks to Steve for finding this and writing clear steps to reproduce when logging this bug in Bugzilla. Also thanks to Peter for confirming the same bug is present on Windows, i.e. is all platforms, not just Linux.
