1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-05 06:09:47 +02:00

3507 Commits

Author SHA1 Message Date
Paul Licameli
c585bb16fb Move bounding times and minimum stutter length into ScrubOptions 2016-05-22 15:27:35 -04:00
Paul Licameli
ffe596c760 Move some fields into ScrubbingOptions 2016-05-22 15:27:35 -04:00
Paul Licameli
671f60492d Move some static functions into ScrubbingOptions 2016-05-22 15:27:35 -04:00
Paul Licameli
8ed93b8147 Fix conditional compilation branch 2016-05-22 15:27:35 -04:00
Paul Licameli
3dcf802bdc Have just one scrub enqueueing function: use options for distinctions 2016-05-22 15:27:35 -04:00
Paul Licameli
cdbdd6480b Define and pass around struct ScrubbingOptions, but nothing in it yet 2016-05-22 15:27:35 -04:00
Paul Licameli
36e5b4fbbc AudioIOStartStreamOptions includes the sample rate 2016-05-22 15:27:35 -04:00
Paul Licameli
5997beec9d Rename Scrubbber::mScrubHasFocues to mPaused, reverse its sense 2016-05-22 15:27:34 -04:00
James Crook
26fc69976c Merge branch 'Bug1279-VST' 2016-05-22 16:48:43 +01:00
Paul Licameli
e68cfc3a05 Restore the scrub alternative image for the play button 2016-05-22 11:34:05 -04:00
Tony Kirkland
9905652d5c Bug 1279: change VST host window parameters to prevent app freeze 2016-05-22 11:17:04 -04:00
Paul Licameli
aa9afb073e Show Actual Rate in status only if playing, recording, or monitoring 2016-05-22 10:44:18 -04:00
Paul Licameli
7e0de9a9bc Fix incidentals to Bug 1331, though not the bug itself...
... See comments #1 and #2 at
http://bugzilla.audacityteam.org/show_bug.cgi?id=1331

Don't make strange undo history if, e.g., R to record (or other keystroke
with undoable effects) interrupts a drag with undoable effects (like time
shift).  Ensure that by first simulating a mouse button up event to stop the
drag, before dispatching the keystroke.

Don't crash if certain other drags, that do not have undoable effects, such
as selection or vertical ruler drag -- are interrupted by a keystroke
command (Ctrl+C in particular could cause crash).  However, in these cases,
the drag is still allowed to continue.
2016-05-21 23:19:09 -04:00
Paul Licameli
079eb3e98e Bug1375: Fix sync-lock behavior ...
... which was broken by commit 3015a9c8d9229406f8c33fd32ffc64c11d77ca54
2016-05-21 02:04:12 -04:00
Paul Licameli
66c14c9940 Bug1390: Don't crash when SnapTo is not Off 2016-05-20 23:48:30 -04:00
Paul Licameli
6acb0f99b3 Fix minor error in some position to time calculations 2016-05-18 14:55:03 -04:00
Paul Licameli
9e2916a80b Better implementation of switch from scrub to quick play; ...
... also, don't ever draw the scrub handle while dragging the quick play
region.
2016-05-18 11:58:57 -04:00
Paul Licameli
de13e27cdd Correction: commit 465b743fd32bd431f2f69fc13a060d4e73f34fa9 fixes bug 1391 2016-05-18 11:11:23 -04:00
Paul Licameli
ed87d79133 Don't pop record up if you click it twice; also may fix moonphase... 2016-05-18 11:02:56 -04:00
Paul Licameli
da8973570b Don't pop record up if you click it twice; also may fix moonphase...
... reported by Peter:  sometimes stop button gets disabled during record
2016-05-18 10:59:38 -04:00
Paul Licameli
465b743fd3 Bug1365: Do not confuse Linux key event handling...
... So click on QP during scrub had to be implemented without relying on
SafeYield() when stopping play.
2016-05-18 10:08:46 -04:00
Paul Licameli
b0919ba44f Bug 1392: don't draw indicator over track control during quick play 2016-05-18 09:27:03 -04:00
Paul Licameli
e1f4ab6af6 Double-click record with overdub pins record head center not right 2016-05-17 13:21:39 -04:00
Paul Licameli
47efa2dbbc fix gcc build 2016-05-17 12:38:30 -04:00
Paul Licameli
c66262d790 Double click on Record button pins record head right, not center 2016-05-17 12:25:39 -04:00
Paul Licameli
c01e5dc6b8 Add a comment, pertinent to scrolling 2016-05-17 12:18:40 -04:00
Paul Licameli
95ccc417d8 Scrolling display for (append-) record, if you double click 2016-05-17 01:47:52 -04:00
Paul Licameli
acf16977be Fix deadlocks in scrubbing, again, and better... 2016-05-16 23:13:27 -04:00
Paul Licameli
9535dce82c Fix deadlocks in scrubbing, again, and better...
see eac6f98cbf97d9cdb240da978581ce21ec0d6f9c
2016-05-16 21:03:04 -04:00
Benjamin Drung
787f2afd10 Introduce end-of-line normalization
Ensures that all files that Git considers to be text will have
normalized (LF) line endings in the repository. When core.eol is set to
native (which is the default), Git will convert the line endings of
normalized files in your working directory back to your platform's
native line ending.

See also https://git-scm.com/docs/gitattributes
2016-05-17 01:05:05 +02:00
Paul Licameli
eac6f98cbf Avoid deadlocks that sometimes happened when starting a scrub...
... as a consequence of commit 52910f4f07d41904e5f8cc5fdc5e7f8484468a00
2016-05-16 18:20:43 -04:00
Steve Daulton
f1909cb88e Improve clarity of Append Record button icon (bug 1365) 2016-05-16 17:24:53 +01:00
Benjamin Drung
a20d7898f3 Fix redeclaration of isinf()
Commit 9e78a41 declared isinf() as std::isinf(), because isinf() was not
declared on Ubuntu 16.04. But now the builds fail on Ubuntu <= 15.10,
because isinf() is declared there:

effects/Contrast.cpp:61:12: error: ‘constexpr bool std::isinf(double)’ conflicts with a previous declaration
 using std::isinf;
            ^
In file included from /usr/include/features.h:364:0,
                 from /usr/include/assert.h:35,
                 from /usr/include/wx-3.0/wx/debug.h:14,
                 from /usr/include/wx-3.0/wx/defs.h:695,
                 from /usr/include/wx-3.0/wx/event.h:14,
                 from /usr/include/wx-3.0/wx/window.h:18,
                 from /usr/include/wx-3.0/wx/nonownedwnd.h:14,
                 from /usr/include/wx-3.0/wx/toplevel.h:20,
                 from /usr/include/wx-3.0/wx/dialog.h:14,
                 from effects/Contrast.h:12,
                 from effects/Contrast.cpp:13:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:201:1: note: previous declaration ‘int isinf(double)’
 __MATHDECL_1 (int,isinf,, (_Mdouble_ __value)) __attribute__ ((__const__));

Thus use std::isinf() directly instead of declaring isinf() as
std::isinf().
2016-05-16 13:33:22 +02:00
Paul Licameli
0602343a2d Make drag scrub less sluggish (do less redrawing) 2016-05-15 16:41:24 -04:00
Paul Licameli
c3246e3f7b Make scrubbing work when timer interval constant is shortened to 1 ms
* scrubbing:
  Allow scrub timer interval to be 1 ms, without bogus out-of-memory warnings.
  Less scrub lag: avoid redundant disk traffic in Mixer...
  Less scrub lag: don't poll for available data, get woken up directly
2016-05-15 16:18:43 -04:00
Paul Licameli
8247e87dbf Allow scrub timer interval to be 1 ms, without bogus out-of-memory warnings. 2016-05-15 16:18:00 -04:00
Paul-Licameli
6eaff838f2 Less scrub lag: avoid redundant disk traffic in Mixer...
Also improves performance in bug 860, but not as much as the special case
patch for that bug in Bugzilla
2016-05-15 16:18:00 -04:00
Paul Licameli
52910f4f07 Less scrub lag: don't poll for available data, get woken up directly 2016-05-15 16:18:00 -04:00
Benjamin Drung
9e78a41faf Use std::isinf() instead of isinf()
Audacity fails to build on Ubuntu 16.04 with g++ 5.3.1 (using C++11),
because isinf() is not defined. Thus use std::isinf() instead.
2016-05-15 09:04:35 +02:00
Paul Licameli
3792d18f2d Correct "scrub delay" for whatever scrub timer, so that the lag is right 2016-05-14 19:57:06 -04:00
David Bailes
c58d130c18 Bug fix for audio position
Fix for this bug: If the cursor/selection start is moved using the keyboard, then
audio position shows the previous cursor/selection start.

Simple fix in void AudacityProject::TP_DisplaySelection(). The play region is now updated
before its start is used for audio position.
2016-05-14 17:22:28 +01:00
David Bailes
76a53c43b2 Fix bug associated with the Cursor short/long jump left/right commands
Fixes the following bug: if the zoom level is such that the jump does not cause a visible
change in display of the tracks, then the selection in the selection bar, and the play
region are not updated.

The fix simply moves the location of the call to TP_DisplaySelection(), so that it is called
irrespective of whether the tracks are redrawn.
2016-05-14 15:53:11 +01:00
Paul Licameli
16d33c6005 Give the scrubber its own timer separate from TrackPanel's, so that...
... we can experiment with changing the interval.
2016-05-14 05:47:32 -04:00
Benjamin Drung
13630dc91d Use portable wxIsNaN() instead of isnan()
isnan() is not defined when compiling with g++ 5.3.1 on Ubuntu 16.04. It
is called std::isnan() in C++11 instead. Therefore use wxIsNaN() instead
which already defines the correct name.
2016-05-14 00:05:22 +02:00
Gale Andrews
5c9469a5e2 Added access key for "Scroll left of zero" 2016-05-13 02:00:07 +01:00
Paul Licameli
05fcf9cf82 Fix crashes (sometimes) when closing a project, due to overlays 2016-05-12 16:46:04 -04:00
Paul Licameli
fe11474219 Revert "Fix crashes (sometimes) when closing a project, due to overlays"
This reverts commit a33ca3ec3d1b129241745e278735415a1070e939.
2016-05-12 16:45:08 -04:00
Paul Licameli
31557defa7 Correct the focusing of buttons as mouse moves. Unify the context menu code. 2016-05-12 15:06:54 -04:00
Paul Licameli
a33ca3ec3d Fix crashes (sometimes) when closing a project, due to overlays 2016-05-12 15:04:48 -04:00
Paul Licameli
1bff08a75a Make drag-scrub seek, rather than playing at more than unit speed 2016-05-12 01:22:07 -04:00