1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-11 14:41:06 +02:00

114 Commits

Author SHA1 Message Date
Paul Licameli
5bb1152fe9 Separate ShuttleGuiBase::ApplyItem 2020-05-25 05:40:46 -04:00
Paul Licameli
7fb4652c88 Remove some unused functions and forward declarations 2020-05-23 05:16:59 -04:00
Paul Licameli
310b5dea30 Fix (again) calls to AddCheckBox...
... Force you to pass bool now.  Break compilation in case you pass literal
"false", rather than implicitly converting it to bool true !

See commit 7766d9a192a9d28f8207c95cdd7ce08464116525 which was in 2.3.2

But Max merged later at d9608cddea49cb33815fd9475f2b4f822913b772 in 2.4.0, with
his effect apparently written analogously with the old code in Normalize from
before that, and this quetly compiled with the wrong effects.
2020-03-01 22:17:20 -05:00
Paul Licameli
2570b56176 Rename Maybe and its members more like std::optional of C++17 2020-01-19 11:38:12 -05:00
Paul Licameli
416cdbefb6 ShuttleGuiBase::DoTieChoice is no longer needed 2019-12-26 15:33:47 -05:00
Paul Licameli
d396472c9f Rewrite overload of TieChoice that took wxString& instead of int& ...
... let it take TranslatableString& instead.

It was used only in AudioUnitEffect.cpp.
2019-12-26 15:33:47 -05:00
Paul Licameli
e7783f4fde Remove declaration of undefined function in ShuttleGui 2019-12-26 15:33:47 -05:00
Paul Licameli
8b65b1ae08 ShuttleGui::StartNotebookPage takes TranslatableString...
... and remove an unused overload
2019-12-26 15:33:47 -05:00
Paul Licameli
d1637c22c0 TranslatableString for explicit prompts and units in ShuttleGui 2019-12-23 19:22:03 -05:00
Paul Licameli
747c35645a TranslatableString for checkbox captions 2019-12-23 19:15:34 -05:00
Paul Licameli
c23451af9d TranslatableString for prompts of radio buttons 2019-12-23 19:02:21 -05:00
Paul Licameli
455d3185a8 TranslatableString for list control column headers, menus 2019-12-23 19:02:21 -05:00
Paul Licameli
6b235bdec5 TranslatableString for captions of sliders 2019-12-23 19:02:21 -05:00
Paul Licameli
13417b6d5b ShuttleGui::AddFixedText takes TranslatableString 2019-12-23 19:02:19 -05:00
Paul Licameli
acd1158e1b TranslatableString for titles, and spin control and combo prompts 2019-12-23 18:53:00 -05:00
Paul Licameli
707a069712 ShuttleGui::AddVariableText takes TranslatableString 2019-12-23 18:53:00 -05:00
Paul Licameli
5168d62e3d TranslatableString for captions of text entry boxes 2019-12-23 18:53:00 -05:00
Paul Licameli
b404eb7800 TranslatableString for static text box captions 2019-12-23 18:52:37 -05:00
Paul Licameli
21e7b9f2de TranslatableString for prompts of choice controls 2019-12-23 15:39:49 -05:00
Paul Licameli
1944ac2040 TranslatableString for labels of ShuttleGui buttons 2019-12-23 15:35:48 -05:00
Paul Licameli
75996a851c ShuttleGui::AddChoice and TieChoice take TranslatableStrings 2019-12-23 15:35:47 -05:00
Paul Licameli
0247329077 Remove eIs(Getting|Saving)ViaShuttle enum values...
... Because:

1 They weren't used

2 The branches selected by them were wrongly passing user-visible prompt strings
to DoDataShuttle, which elsewhere takes a preference path (this is an error that
could have been detected and avoided if there weren't naked wxString arguments)

3 Without those branches, the affected Tie... functions become more parallel to
other ShuttleGui member functions, which might later be unified into fewer
functions
2019-12-23 15:35:21 -05:00
Paul Licameli
027a5ca32e ShuttleGui static boxes can wrap long text 2019-12-18 10:43:15 -05:00
Paul Licameli
7d38500ecf ShuttleGui::AddSpace takes prop argument...
... This will be needed to rewrite EffectRack
2019-12-10 09:58:39 -05:00
Paul Licameli
f825c32a50 ShuttleGui can specify orientation and minimum size...
... This will be needed for rewrite of EffectUIHost dialog
2019-12-10 09:58:39 -05:00
Paul Licameli
3b69a038c8 Add ShuttleGui functions to make simple book controls...
... analogous to StartNotebook() and EndNotebook()

This will be needed to rewrite export dialogs
2019-12-10 09:58:39 -05:00
Paul Licameli
1802b9316e ShuttleGui::AddStandardButtons takes more general wxWindow *extra...
... This will be needed to rewrite the EffectUIHost dialog
2019-12-10 09:58:39 -05:00
Paul Licameli
930c21dc2a Define and use ShuttleGui::Size 2019-12-02 22:02:46 -05:00
Paul Licameli
96291c5476 Remove second argument of AddWindow(), use Position() instead 2019-12-02 22:01:22 -05:00
Paul Licameli
b5ee7676fd Rename ShuttleGui::SetSizeHints, chain-call it like other methods...
... And rewrite some other existing calls to SetMinSize
2019-12-02 19:35:06 -05:00
Paul Licameli
64a96e6f01 Define and use ShuttleGui::ConnectRoot...
... And corrected improper connections in HistoryWindow and ContrastDialog,
improper because they got called with the wrong this pointer, to
the control instead of the dialog.  But that was harmless anyway because the
handlers did not use this.
2019-12-02 19:35:01 -05:00
Paul Licameli
d98e41aad1 Define and use ShuttleGui::Disable; remove EnableCtrl 2019-12-02 17:54:07 -05:00
Paul Licameli
c72dbf5b51 Define and use ShuttleGui::Focus 2019-12-02 17:26:40 -05:00
Paul Licameli
30d375d6fa Remove style argument from ShuttleGui::AddCombo & AddListBox...
... use the Style() chain-call instead, as needed
2019-12-02 17:26:38 -05:00
Paul Licameli
1bfbfb9640 ShuttleGui::Style analogous to other functions 2019-12-02 17:23:34 -05:00
Paul Licameli
9eeef4713d Define and use ShuttleGui::Name and NameSuffix...
... For radio buttons, the name will default to the same as the prompt if not
otherwise specified
2019-12-02 16:55:46 -05:00
Paul Licameli
3ea0209e5c Define and use ShuttleGui::ToolTip 2019-12-02 11:41:51 -05:00
Paul Licameli
1d32824e02 Define and use ShuttleGui::Validator 2019-12-02 11:21:40 -05:00
Paul Licameli
8ea137e041 Define struct DialogDefinition::Item, to be filled in 2019-12-01 22:21:49 -05:00
Paul Licameli
b351eabf47 ComponentInterfaceSymbol contains TranslatableString 2019-12-01 18:08:56 -05:00
Paul Licameli
3704336a58 Fix dangling pointer bug, caused assertion opening Preferences 2019-12-01 13:50:36 -05:00
Paul Licameli
ae353fe61f Specify list control columns and styles all in one call 2019-11-28 14:24:44 -05:00
Paul Licameli
17ee2478bc An overload of AddChoice specifying selected as string value 2019-11-28 14:24:44 -05:00
Paul Licameli
089b46ab64 Specify initial radio button state in ShuttleGui method arguments 2019-11-28 14:24:44 -05:00
Paul Licameli
bca0afd52e ShuttleGui lets you specify whether a button is default. Use that. 2019-11-28 14:24:43 -05:00
Paul Licameli
cd4266792a Comment how AddStandardButtons sets default; remove redundant call 2019-11-28 14:24:43 -05:00
Paul Licameli
6bff718248 Comments about wxALL where there are position arguments in ShuttleGui 2019-11-28 14:24:43 -05:00
Paul Licameli
1cd795aadb Comments about the purpose of SettingName for radio buttons 2019-11-28 14:24:43 -05:00
Paul Licameli
43a8725044 comment 2019-11-28 14:24:43 -05:00
Paul Licameli
c67a47e3e6 ShuttleGuiBase::mpDlg is const 2019-11-28 14:24:43 -05:00