Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-03 14:13:11 +02:00
Code Issues Releases Wiki Activity

Fix (again) calls to AddCheckBox...

Browse Source 
... Force you to pass bool now.  Break compilation in case you pass literal
"false", rather than implicitly converting it to bool true !

See commit 7766d9a192a9d28f8207c95cdd7ce08464116525 which was in 2.3.2

But Max merged later at d9608cddea49cb33815fd9475f2b4f822913b772 in 2.4.0, with
his effect apparently written analogously with the old code in Normalize from
before that, and this quetly compiled with the wrong effects.
This commit is contained in:
Paul Licameli 2020-03-01 22:07:01 -05:00
parent 6c69484899
commit 310b5dea30
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/ShuttleGui.h
View File

@ -334,6 +334,14 @@ public:
wxGrid * AddGrid();
wxCheckBox * AddCheckBox( const TranslatableString &Prompt, bool Selected);
wxCheckBox * AddCheckBoxOnRight( const TranslatableString &Prompt, bool Selected);
// These deleted overloads are meant to break compilation of old calls that
// passed literal "true" and "false" strings
wxCheckBox * AddCheckBox( const TranslatableString &Prompt, const wxChar *) = delete;
wxCheckBox * AddCheckBox( const TranslatableString &Prompt, const char *) = delete;
wxCheckBox * AddCheckBoxOnRight( const TranslatableString &Prompt, const wxChar *) = delete;
wxCheckBox * AddCheckBoxOnRight( const TranslatableString &Prompt, const char *) = delete;
wxComboBox * AddCombo( const TranslatableString &Prompt,
const wxString &Selected, const wxArrayStringEx & choices );
wxChoice * AddChoice( const TranslatableString &Prompt,

4
src/effects/Loudness.cpp
View File

@ -329,12 +329,12 @@ void EffectLoudness::PopulateOrExchange(ShuttleGui & S)
mStereoIndCheckBox = S
.Validator<wxGenericValidator>( &mStereoInd )
.AddCheckBox(XO("Normalize stereo channels independently"),
mStereoInd ? wxT("true") : wxT("false"));
mStereoInd );
mDualMonoCheckBox = S
.Validator<wxGenericValidator>( &mDualMono )
.AddCheckBox(XO("Treat mono as dual-mono (recommended)"),
mDualMono ? wxT("true") : wxT("false"));
mDualMono );
}
S.EndVerticalLay();
}