Paul Licameli
412d651e6e
Bug1511, partial: fix crash using Quit from Mac tool dock, but...
...
... when multiple unsaved projects are open, there is still a prompt to save
only one of them. I don't yet know why.
2016-10-03 11:34:30 -04:00
Paul Licameli
ad04187a41
Change sampleCount arguments, variables, return values to size_t...
...
... whenever they really describe the size of a buffer that fits in memory, or
of a block file (which is never now more than a megabyte and so could be fit in
memory all at once), or a part thereof.
2016-09-15 21:03:17 -04:00
Paul Licameli
d783762737
Remove unnecessary std::move in return statements...
...
... and comment where it is necessary.
2016-09-15 07:39:46 -04:00
James Crook
4eeef25191
More unused parameters and local variables.
2016-09-12 12:33:44 +01:00
James Crook
545d741eb2
Make Audacity source more like DarkAudacity source.
2016-09-11 13:03:37 +01:00
Paul Licameli
67cec5ad83
Make many counts of tracks and channels unsigned...
...
... And in some places where a library uses signed types, assert that
the reported number is not negative.
What led me to this, is that there are many places where a size_t value for
an allocation is the product of a number of channels and some other number.
2016-09-07 10:11:41 -04:00
Paul Licameli
71efb13161
Remove some naked new amd delete in: widgets
2016-08-08 07:51:26 -04:00
James Crook
e056c23879
Bug 1234 - Enh: Name of Mixer Toolbar options/preferences
2016-07-15 10:18:19 +01:00
Paul Licameli
84c0337aba
Fix TAB key navigation on Mac for all dialogs (not only for panels)
2016-07-10 17:12:27 -04:00
Paul Licameli
4739f3e27b
Compensate for wxW 3 tab navigation deficiencies on Mac...
...
... using char hook event handlers. We don't need to go the extreme length
of patching wxWidgets source.
2016-06-25 19:14:05 -04:00
Paul Licameli
57788c8d7a
Fix Mac tabbing to sliders and meters, analogously to buttons...
...
... And make sure they don't steal focus when clicked or double clicked
2016-06-25 16:08:38 -04:00
Paul Licameli
fe509ed412
Fix drawing of focus rectangles in buttons, meters, sliders on Mac
2016-06-25 16:08:37 -04:00
Paul Licameli
db137ddf76
wxWindow takes ownership of its wxAccessible, so we can use safenew.
2016-05-06 21:03:37 -04:00
Paul Licameli
0a0cbbba20
Mousing over the menu button of device meters (combined or separate) highlights
2016-05-04 10:59:18 -04:00
Paul Licameli
7886464688
Bug1347: Need defense against bad values in .cfg file for meter refresh
2016-04-05 16:11:47 -04:00
Paul Licameli
59f08a6d97
Buig1351: Meter refresh preferences should not allow 0 refresh rate and crash
2016-04-05 15:59:08 -04:00
Paul Licameli
60bcd7aea2
Fix warnings for unused variables and functions
2016-02-26 14:56:26 -05:00
Paul Licameli
dbaa811577
Stack-allocate where possible! ...
...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
7c4c45a0d5
"new"->"NEW" in comments, easier to find remaining naked operator new
2016-02-14 18:52:41 -05:00
Paul Licameli
ad586b3e69
Bug36, partial: Redraw mixer board when meter range preference changes
2016-01-21 10:22:24 -05:00
Leland Lucius
48c5c47214
Fix for bug #1219
2015-10-05 23:43:00 +01:00
Leland Lucius
2f9c7d1567
Fix for bug #1190
2015-09-16 13:04:26 -05:00
Paul Licameli
1278b9644a
Uniform naming of symbols in Experimental.h
2015-08-31 17:55:56 -04:00
Leland Lucius
6a9dae20f5
Appearance on OSX is now back to normal or better
...
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Paul Licameli
e0621819ed
Move ENV_DB_RANGE out of Envelope.h; that file can be included in fewer places.
2015-07-28 11:55:52 -04:00
Paul Licameli
cab89f6fb4
Remove Envelope.h from other headers
2015-07-28 10:02:09 -04:00
Steve Daulton
df8ddde874
Added dB - linear amplitude conversion macros.
2015-07-24 21:59:34 +01:00
Paul Licameli
e70f91c64e
Removed ShuttleGui.h from other headers
2015-07-19 12:31:03 -04:00
David Bailes
d5ea9a678e
Fix for translations of strings for screen readers in MeterAx::GetName. The translations of strings which had a leading space did not always preserve this leading space, resulting in merged words. Therefore separate spaces were added, and the original strings left unchanged so that no new translation work is required.
2015-06-10 14:09:56 +01:00
David Bailes
cc9ac9804f
Meters: fix indication of clipping for screen readers.
2015-06-10 13:56:47 +01:00
David Bailes
f458df1c7b
Changes to a number of dialogs so that the NVDA screen reader can read the titles. Missed these in my last patch. The accessibility name of the dialog is set to the title.
2015-05-18 13:57:05 +01:00
Leland Lucius
8fbfa460c4
Migrating the remaining effects
...
This brings the builtin, LV2, and VAMP effects inline with the
Audio Units, LADSPA, and VST effects. All effects now share
a common UI.
This gives all effects (though not implemented for all):
User and factory preset capability
Preset import/export capability
Shared or private configuration options
Builtin effects can now be migrated to RTP, depending on algorithm.
LV2 effects now support graphical interfaces if the plugin supplies one.
Nyquist prompt enhanced to provide some features of the Nyquist Workbench.
It may not look like it, but this was a LOT of work, so trust me, there
WILL be problems and everything effect related should be suspect. Keep
a sharp eye (or two) open.
2015-04-16 23:36:28 -05:00
Leland Lucius
21c2e5f994
Meter refresh rate not updated when leaving preferences.
2015-04-08 03:03:44 -05:00
lllucius
3d420e019c
Applied accessibility patch from David that I missed.
...
From David's message:
"solution to the problem of getting jaws to read the updated
name after choosing start/stop monitoring on the menu"
2015-01-19 17:47:39 +00:00
lllucius
dbe7e0280c
Well r13875 was pretty dumb...try again
2015-01-10 20:41:49 +00:00
lllucius
e33cf84e35
Reduce accessibility chattiness in meters
2015-01-10 20:33:57 +00:00
lllucius
d87c6942cd
A couple more accessibility changes
2015-01-09 16:07:24 +00:00
lllucius
a6ace4a606
Ignore the key up events after showing the context menu (on Windows only)
2015-01-09 15:27:58 +00:00
lllucius
5e46430d80
Update keyboard and a11y usage based on DB's suggestions
2015-01-05 16:36:17 +00:00
lllucius
4e8b794452
Fix a conflict between the backported number validator and formatter
...
When building for wx3 on Linux, the backported number validators
and formatter conflicts with the wx3 version because I never
renamed them. Crashes during termination would occur because
the wx3 version and our version had different vtables.
I was thinking that we would just be able to delete the
backported version when upgrading to wx3, but since
we've made Audacity specific changes to them we can't
simply start using the real wx3 versions anymore.
Therefore, I needed to rename then to prevent the crashes.
2015-01-04 21:17:16 +00:00
lllucius
8bef14df36
Addresses meter accessibility mentioned in bug #33
...
And also corrects the missing focus rectangle display on
the toolbar buttons on Linux.
2015-01-04 09:24:26 +00:00
lllucius@gmail.com
3a23757e2e
All the menu to be opened from the keyboard on the Mac as well.
2015-01-04 02:25:56 +00:00
lllucius@gmail.com
e33723d0e4
Figures Linux uses a differnet keycode for the context menu
2015-01-04 01:05:23 +00:00
lllucius
c9cde48f21
Open popup menu under icon when using context menu key
2015-01-03 09:29:42 +00:00
lllucius@gmail.com
c3c458e3fa
Compact meters under GTK have same antialiasing issue as OSX
2015-01-03 07:00:39 +00:00
lllucius
bec5866653
Persist meter state across toolbar resets and fix clipping indicator
...
This will fix the clipping indicator turning on after a toolbar reset
and, as a bonus, the timers now only run if playing, capturing, or
monitoring. Will (slightly) reduce the CPU consumption.
2015-01-01 23:29:08 +00:00
lllucius
055b40c3f2
Fix wx3 build
2014-12-29 03:46:57 +00:00
lllucius
a30f8398aa
Let's try narrower icons...
...
...to see if it removes enough "gray" space on the left
of the vertical meter to be bareable.
2014-12-28 23:48:01 +00:00
lllucius
e47bb71b08
Re-adds the ability to reset peaks while recording
...
It also disables the "start/stop monitoring" menu item
while recording. Not really necessary, but...
2014-12-28 21:06:58 +00:00
lllucius
4126acac6b
Fixes missing recent peak value
...
And re-introduces double buffering on Windows.
2014-12-28 20:49:37 +00:00