1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-02 16:49:41 +02:00

10394 Commits

Author SHA1 Message Date
Paul Licameli
cb2ea25afc Define drawing function of CellularPanel, which visits nodes 2019-06-26 23:39:42 -04:00
Paul Licameli
040decf9e3 Commonly used rectangle calculations move into ViewInfo/ZoomInfo...
... reducing need for TrackPanel.h
2019-06-26 23:38:31 -04:00
Paul Licameli
868481b686 GetSceenEndTime out of TrackPanel 2019-06-26 21:25:15 -04:00
Paul Licameli
d29d10d712 GetTracksUsableArea() out of TrackPanel 2019-06-26 21:25:15 -04:00
Paul Licameli
f87dfd43c1 GetVRulerWidth, GetLabelWidth, GetLeftOffset out of TrackPanel.h...
... And some things demoted from ViewInfo to ZoomInfo, related to x coordinates
only
2019-06-26 21:25:15 -04:00
Paul Licameli
baf31dd72e TrackPanel copies its size, stores VRuler width in ViewInfo 2019-06-26 21:25:15 -04:00
Paul Licameli
5cd77187ef Fix TrackPanel rectangle calculations...
... There was an incorrect click-to-resize area active when the last track was
partly scrolled off the bottom

This big predated 2.3.3. development
2019-06-26 21:24:31 -04:00
Paul Licameli
349b882911 Fix failures to repaint track focus border caused by 25f4d6c 2019-06-26 10:03:07 -04:00
Paul Licameli
ef7068f46a Fix some failures to update the vertical scrollbar...
... Problem involves sequence in which event handlers are done, and started at
commit 278509a which updated track Y coordinates in a handler.

Solution is to delay the updating of scrollbars further, using CallAfter.

Also remove one unnecessary call to ProjectWindow::FixScrollbars() because
ProjectWindow::HandleResize follows it and includes scrollbar update already.
2019-06-25 17:41:29 -04:00
Henric Jungheim
b0ea6e274d Have AppVeyor's git fetch submodules in parallel. 2019-06-25 11:53:49 -07:00
Henric Jungheim
01c1b0b0a9 Avoid warning about forward declaration not matching definition. 2019-06-25 11:53:49 -07:00
Henric Jungheim
3b4250c3ae Base classes of AUDACITY_DLL_API classes also need AUDACITY_DLL_API. 2019-06-25 11:53:49 -07:00
Henric Jungheim
3e0475e740 Don't override build parameters in appveyor.yml.
Leave them as set by Directory.Build.props.
2019-06-25 11:53:49 -07:00
Henric Jungheim
799db937ef Remove AppVeyor branch filter. 2019-06-25 11:53:49 -07:00
Paul Licameli
dc870cf2c5 TrackPanelAx.cpp freed from cycles leaving 24 in largest s.c.c. 2019-06-25 11:25:07 -04:00
Paul Licameli
25f4d6cf8b TrackPanelAx does not depend on TrackPanel...
... TrackPanelAx now sends an event to the project when track focus changes,
and TrackPanel listens for it.

TrackPanel also initializes TrackPanelAx with a callback to do the details of
rectangle calculation.
2019-06-25 11:24:40 -04:00
Paul Licameli
2257fa642a Remove TrackPanel::EnsureVisible; TrackList sends an event instead 2019-06-25 10:54:55 -04:00
Paul Licameli
d236507682 Free CommonCommandFlags from cycles again, big s.c.c. is 25 2019-06-25 09:41:11 -04:00
Paul Licameli
baf4648621 Eliminate dependencies on the src/menus files...
... The declarations in namespaces in Menus.h are gone, the function
definitions moved elsewhere.

So there had been hidden dependencies on the src/menus files, that
scripts/graph.pl did not detect.  Now the lack of dependencies on those
files, according to the graph, is almost the reality.

EXCEPT that src/Menus.cpp still has extern declarations of functions defined
in src/menus/* that populate the menus, so things really are still tied up
in cycles.

Breaking that link dependency is one purpose of the future project of defining
a menu item registration system.

The graph as reported by scripts/graph.pl has only some minor changes.  The
big s.c.c. grows again to 26, two new files in it, one file
(CommonCommandFlags) trapped in it again.
2019-06-25 00:20:17 -04:00
Paul Licameli
7fc3c5e7a7 Move namespace TransportMenus into ProjectAudioManager.cpp ...
... not the best thing for the long term, but hidden dependencies on
TransportMenus.cpp are eliminated

Tying CommonCommandFlags again into the big component, which is now 26
2019-06-25 00:14:53 -04:00
Paul Licameli
c6478f43af Lower ViewActions as member functions of ProjectWindow 2019-06-25 00:14:53 -04:00
Paul Licameli
b6077fd3cd Lower DoReloadPreferences into PrefsDialog.cpp 2019-06-25 00:14:53 -04:00
Paul Licameli
8db51416bc Lower DoEditMetadata into Exporter 2019-06-25 00:14:53 -04:00
Paul Licameli
684a948fd2 Don't reuse EditActions::DoUndo...
... instead, when timer recording is cancelled, don't push state and pop it
at once, but just roll it back.
2019-06-25 00:14:52 -04:00
Paul Licameli
f8c40dc8e7 Move DoHelpWelcome out of HelpMenus 2019-06-25 00:14:52 -04:00
Paul Licameli
2d11e6bda9 Move DoImportMidi out of FileMenus 2019-06-25 00:14:52 -04:00
Paul Licameli
8eca219d57 Separate versions of DoImportMIDI that do and don't assume a project 2019-06-25 00:14:52 -04:00
Paul Licameli
ff2cf496cd Move DoEffect out of PluginMenus 2019-06-25 00:14:52 -04:00
Paul Licameli
691eee681c Move DoAudacityCommand out of PluginMenus 2019-06-25 00:14:52 -04:00
Paul Licameli
1c588fa014 Move enum into EffectManager...
... tying Effect into a cycle of 3 with EffectManager and EffectRack, which is
only revealing the true dependencies
2019-06-25 00:12:45 -04:00
Paul Licameli
d2f386a329 Move functions into new file TrackUtilities.cpp ...
... so that other files do not have link dependency on TrackMenus.cpp

The new project enlargest the big s.c.c. by 1, to 25
2019-06-24 23:13:22 -04:00
Paul Licameli
02e620d35f Move functions into new file SelectUtilities.cpp ...
... so that other files do not have link dependency on SelectMenus.cpp

The new file enlarges the big s.c.c. to 24
2019-06-24 23:06:44 -04:00
Paul Licameli
fab648e475 New files SelectUtilities, TrackUtilities 2019-06-24 22:50:35 -04:00
Paul Licameli
f1dcc156a0 Remove unnecessary inclusions of Menus.h 2019-06-24 22:45:33 -04:00
Henric Jungheim
1b9a5b4c15 Add "src" to MSVC include paths. 2019-06-24 13:44:31 -07:00
Steve Daulton
7787ea1fa9 Fix bug 2138
Control envelope should be at sound sample rate, even for fade-out.
2019-06-24 21:06:08 +01:00
Steve Daulton
7485d88bcd
Fix bug 2136 updated
As described by David Bailes, it should be std::locale nolocale("C");
2019-06-24 20:34:54 +01:00
Paul Licameli
3d5eec7929 CommonCommandFlags is free of cycles, 23 left in the big s.c.c. ...
... That was easy.  An #include in a new file just wasn't needed.
2019-06-24 14:48:08 -04:00
Paul Licameli
84e8d4b629 Rewrite AttachedVirtualFunction so MS compiler accepts it 2019-06-24 14:12:50 -04:00
Paul Licameli
e08a942ab8 Fix other cause of intermittent timing-dependent crash at shutdown...
... AudioIO holds a weak pointer to its listener so there is no dangling
pointer
2019-06-24 13:32:08 -04:00
Paul Licameli
b8838b38ed Free AudioIO from cycles, 24 files left in the big component 2019-06-24 13:09:47 -04:00
Paul Licameli
5627620b78 Remove dependency of AudioIO on Scrubbing.cpp ...
... though the demotion of the constant into AudioIO.h isn't wholly satisfactory
and there is still the scrubbing queue in AudioIO
2019-06-24 12:52:54 -04:00
Paul Licameli
d9b780b067 AudioIO does not depend directly on ControlToolBar ...
... use one more callback in the listener to change the ControlToolBar pause
state.
2019-06-24 12:43:08 -04:00
Paul Licameli
bcc90ee91a AudioIO does not need ProjectWindow 2019-06-24 12:43:08 -04:00
Paul Licameli
ed5c92450d CommitRecording out of ControlToolBar 2019-06-24 12:43:08 -04:00
Paul Licameli
1d6ff11fec Fix #include paths 2019-06-24 12:41:25 -04:00
Paul Licameli
433e2cf660 Fix an intermittent crash on exit cased by timer events 2019-06-24 11:19:24 -04:00
Paul Licameli
ba4fe34947 Free four effect-releated files from the big s.c.c. ...
... They are:
Effect
EffectManager, EffectRack (in a cycle of 2)
Nyquist

There is also one new file, RealtimeEffectManager.  Making AudioIO use that,
instead of the whole of EffectManager, was essential to this improvement of
the graph.
2019-06-24 01:04:08 -04:00
Paul Licameli
cd9e4e3987 RealtimeEffectState into RealtimeEffectManager...
... which doesn't need Effect.h then.

Freeing Effect and RealtimeEffectManager from cycles, leaving 25 in the big
s.c.c.
2019-06-24 01:04:03 -04:00
Paul Licameli
5caeaf520b RealtimeEffectState needs only EffectClientInterface, not Effect 2019-06-24 00:49:14 -04:00