Problem:
If a new version of Audacity introduces a new default shortcut, or changes an existing one, then this may be the same shortcut as a user has previously assigned to another command. Both commands will have the same shortcut, and the shortcut will only execute one of those commands.
Fix:
Check for any such duplicates when a user opens a version of audacity using an audacity.cfg file which was created with a different version.
For each duplicate found, remove the shortcut from the command which has a new or changed default.
If duplicates where found, open a message box informing the user of the removed shortcuts.
... such as Nyquist Workbench.
I don't fully understand why, but destroying the menu registry items very late,
during the destruction of static objects, causes a crash in memory deallocation,
at least on Mac.
So destroy the menu registry explicitly in application shut-down.
- The TCP cursor is indicating both selection and dragability, so we use the arrow (as UI for tabs does, which are selectable and draggable).
- When actually dragging, we use the clenched fist icon, not the new clenched fist with the fingers cut off icon (aka snowball icon).
Big Thanks to Steve for finding this and writing clear steps to reproduce when logging this bug in Bugzilla. Also thanks to Peter for confirming the same bug is present on Windows, i.e. is all platforms, not just Linux.
This is a minimal fix for this bug, and can be improved on in time. There is almost no error checking in the file read and write, so if you use a bad presets file, you won't be told (yet).
It does provide import and export for all effects that have presets.
The triangle showing where in the dock a toolbar will drop now takes into account that overly tall toolbars will be resized to 2 tbs once they are docked.
Mostly from suggestions, but there's a couple of other minor
fixes and additions:
Cmake not decides with SDK to use on Windows
All Audacity cmake options are not prefixed with "audacity_", but this
is configurable in audacity/CMakeLists.txt
Several other options have been marked advanced so they don't clutter
the CMake GUI
On Windows, multiple processors will now be used reducing build time
considerably
Quieted a couple of package messages that the user doesn't need to see
No longer tried to create aliases on Windows
No longer used precompiled headers if ccache is available
On Windows, only copies the needed wxWidgets and VC runtime libraries
to the bin directory
Currently AudioIoCallback::ScrubState::Get(), inserts a period of silence the first time it's called because at this time Scrubber::ContinueScrubbingPoll() has not been called, and so message.end has not been set to an appropriate value.
In the case of keyboard scrubbing and play-at-speed, the initial speed is already known, so message.end can be set to this value, removing the need for an initial silence.
The start of keyboard scrubbing and play-at-speed are now faster (the latter very much faster).
Currently the jitter in the playback cursor is worse when scrubbing backwards than forwards.
Fix:
In AudioIOBase::PlaybackSchedule::AdvancedTrackTime()
in the line:
time += realElapsed * speed;
realElapsed is negative when scrubbing backwards, so need fabs(speed) rather than just speed.
I'm sure there will be further minor updates, but this
should be the last major update and it should be ready
for testing.
Audacity specific cmake options (cmake -Doption=<yes|no>) include:
// Disable dynamic loading of ffmpeg libraries
disable_dynamic_ffmpeg:BOOL=OFF
// Disable dynamic loading of JACK libraries
disable_dynamic_jack:BOOL=ON
// Enable ffmpeg library
enable_ffmpeg:BOOL=ON
// Enable flac library
enable_flac:BOOL=ON
// Enable id3tag library
enable_id3tag:BOOL=ON
// Enable LADSPA plug-in support
enable_ladspa:BOOL=ON
// Enable lv2 library
enable_lv2:BOOL=ON
// Enable mad library
enable_mad:BOOL=ON
// Enable midi library
enable_midi:BOOL=ON
// Enable nyquist library
enable_nyquist:BOOL=ON
// Enable ogg library
enable_ogg:BOOL=ON
// Enable portmixer library
enable_portmixer:BOOL=ON
// Enable portsmf library
enable_portsmf:BOOL=ON
// Enable sbsms library
enable_sbsms:BOOL=ON
// Enable soundtouch library
enable_soundtouch:BOOL=ON
// Enable twolame library
enable_twolame:BOOL=ON
// Enable vamp library
enable_vamp:BOOL=ON
// Enable vorbis library
enable_vorbis:BOOL=ON
// Enable VST2 plug-in support
enable_vst:BOOL=ON
// Use system libraries if available
prefer_system_libs:BOOL=ON
// Enable the portaudio ALSA interface if available
use_pa_alsa:BOOL=ON
// Enable the portaudio CoreAudio interface if available
use_pa_coreaudio:BOOL=ON
// Enable the portaudio DirectSound interface if available
use_pa_ds:BOOL=ON
// Use the JACK audio interface if available
use_pa_jack:BOOL=ON
// Use the OSS audio interface if available
use_pa_oss:BOOL=ON
// Enable the portaudio WASAPI interface if available
use_pa_wasapi:BOOL=ON
// Enable the portaudio WMME interface if available
use_pa_wmme:BOOL=ON
// Use ffmpeg system library if available
use_system_ffmpeg:BOOL=ON
// Use flac system library if available
use_system_flac:BOOL=ON
// Use id3tag system library if available
use_system_id3tag:BOOL=ON
// Use lame system library if available
use_system_lame:BOOL=ON
// Use lv2 system library if available
use_system_lv2:BOOL=ON
// Use mad system library if available
use_system_mad:BOOL=ON
// Use midi system library if available
use_system_midi:BOOL=ON
// Use ogg system library if available
use_system_ogg:BOOL=ON
// Use portsmf system library if available
use_system_portsmf:BOOL=ON
// Use sbsms system library if available
use_system_sbsms:BOOL=ON
// Use sndfile system library if available
use_system_sndfile:BOOL=ON
// Use soundtouch system library if available
use_system_soundtouch:BOOL=ON
// Use soxr system library if available
use_system_soxr:BOOL=ON
// Use twolame system library if available
use_system_twolame:BOOL=ON
// Use vamp system library if available
use_system_vamp:BOOL=ON
// Use vorbis system library if available
use_system_vorbis:BOOL=ON
// Use wxwidgets system library if available
use_system_wxwidgets:BOOL=ON
Problem:
Validation of the length fails, because what should be the min and max are in fact the max and min.
Introduced by commit 1d32824, which got the min and max the wrong way round.
