1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-06 14:52:34 +02:00

9115 Commits

Author SHA1 Message Date
Paul Licameli
3f1d9ab8c1 P & R recording: change color of pin button, as for play indicator 2018-08-11 00:26:34 -04:00
Paul Licameli
0d9972b3e0 Some member functions of AudioIO can be const 2018-08-10 22:58:33 -04:00
Paul Licameli
f036700b09 Make PlaybackSchedule::mTime atomic and rename some functions...
... The variable ought to be atomic because it is read and written by different
threads.

Use local variables to avoid repeated reads of the atomic.
2018-08-10 21:30:14 -04:00
Paul Licameli
8a78ae280c Factor out a piece of the big callback 2018-08-10 17:33:18 -04:00
James Crook
ee2d8c11cb Bug 1928 - Export Multiple with a label track present defaults to export by tracks not labels 2018-08-10 19:25:21 +01:00
James Crook
2d28b2e7e1 Bug 1907 - Mac: Some buttons in effects dialogs have non-transparent background
It's not clear why this worked before.
- Mac was not clearing any backgrounds for the button bitmaps.
- There were no pressed buttons defined (on any platform).
2018-08-10 18:39:34 +01:00
James Crook
7f96f85676 Add some Right-To-Left language workarounds.
MixerBoard, LyricsWindow, Screenshot and most effects are now LTR in RTL locales.
Also added a pref so this can be overridden.  As RTL affects window creation, the language choice and this preference may only fully take effect after a restart of Audacity.
2018-08-10 18:39:33 +01:00
Paul Licameli
c95532012a Correctly update hot zones for quick-play cursor at button up 2018-08-10 12:05:25 -04:00
David Bailes
4bf28412db Manage Macros dialog: a couple of focus issues
1. For both the macros list and the steps list, when focus first moves to the list, an item is selected but not the focus.
2. After editing a step, focus is not returned to that step in the list.

Fix for 1: in the calls of SetItemState(), include the wxLIST_STATE_FOCUSED flag.

Fix for 2: The fix for 1 fixed 2. Not sure why.
2018-08-10 16:43:27 +01:00
James Crook
9d396e3315 Bug 1925 - Applying <macroname> to current project window: visual noise, and accessibility.
For accessibility, not showing the activity window is better.
2018-08-10 12:23:30 +01:00
James Crook
154f6d25d9 Bug 1923 - Enh: Help buttons for Export Audio 2018-08-10 09:40:00 +01:00
Paul Licameli
072b711353 Revert cc08cfc, it's unimportant to other work and it made scrub clicky 2018-08-09 19:34:33 -04:00
Steve Daulton
5dab364f15 Add Help button for Advanced Mixing Options 2018-08-09 21:25:29 +01:00
Steve Daulton
217c1267bd Add Help button to Export Multiple dialog 2018-08-09 20:49:44 +01:00
James Crook
3d6f3f1866 Fix our custom NumericText controls are scrambled in RTL layout.
Fix is to force them to be LTR (for now).
2018-08-09 19:01:45 +01:00
James Crook
ddd1494e75 Fix crash from following NULL pointer
GetControlToolBar() can return NULL when closing windows/projects.
2018-08-09 18:29:57 +01:00
Paul Licameli
8c486b50f6 Changes via History affect selection exactly as undo/redo...
... I don't know a good reason why they didn't before.  It was ancient (2010)
behavior.

This also means that RollbackState really will properly rollback the selection
too, even when there are redo items.

This simplifies away an odd special case.
2018-08-09 13:22:07 -04:00
Paul Licameli
af81dfa10b Bug1922: updating play indicator when looping with a time track 2018-08-09 13:18:53 -04:00
Paul Licameli
871bc65c8e Fix loop play again (error introduced at 46d7804) 2018-08-09 11:39:51 -04:00
Paul Licameli
6f7eaf7746 Fewer calls to GetActiveProject() in AudioIO.cpp 2018-08-08 17:30:43 -04:00
Paul Licameli
2472b128d3 Fix compilation of EXPERIMENTAL_AUTOMATED_INPUT_LEVEL_ADJUSTMENT 2018-08-08 17:08:54 -04:00
Paul Licameli
197122c7d5 Collect initialization of playback schedule into a function 2018-08-08 16:36:42 -04:00
Paul Licameli
6e4d11e5af Fix loop play 2018-08-08 14:26:32 -04:00
Paul Licameli
cc08cfc9fd Restart of Mixer is same as Reposition at t0 2018-08-08 14:16:17 -04:00
Paul Licameli
46d7804cdf Group some of the fields of AudioIO into PlaybackSchedule 2018-08-08 14:10:21 -04:00
James Crook
adb33f466e Bug 1494 - Strange Pause behaviour with seeking/scrubbing
Now instead of the (strange) Pause, we Stop.
2018-08-08 18:40:16 +01:00
James Crook
0fe2659a7b Bug 1916 - Play at Speed - scrub widget appears unnecessarily 2018-08-08 17:59:18 +01:00
Paul Licameli
175a471261 Remove " == true" 2018-08-08 12:34:47 -04:00
Paul Licameli
fc8783bc74 Put callback in a member function, remove many more gAudioIO-> 2018-08-08 12:30:10 -04:00
Paul Licameli
fc497368a5 Remove needless gAudioIO-> in member functions (AudioIO is singleton) 2018-08-08 12:30:10 -04:00
James Crook
3353780bf9 Bug 1918 - Right to Left (RTL) language cannot be undone using preferences. 2018-08-08 17:21:45 +01:00
James Crook
bf6b47dbb4 Bug 1918 - Left to right (LTR) language selection reverses elements that should not be reversed
This does not entirely fix LTR language support, but dramatically ameliorates the problems originally reported in bug 1918.
2018-08-08 16:33:00 +01:00
Steve Daulton
0162badeff Fix Adjustable Fade preview for stereo tracks 2018-08-07 16:40:55 +01:00
James Crook
0c73bc1356 Bug 1897 - Export corrupts/clears the Recent Files list 2018-08-07 15:53:09 +01:00
Paul Licameli
22f85f244b Bug1917: TrackPanel should keep focus after click or drag...
... though ruler won't, and if you start to drag in TrackPanel but abort it
with the ESC key, that too returns focus
2018-08-07 10:42:38 -04:00
Paul Licameli
3f0b3bf1b8 Try to flash the pin even less at extreme positions 2018-08-07 10:27:37 -04:00
James Crook
9eab948fb1 Bug 1905 - Labels with more than 260 characters fail to load (with no warning) 2018-08-07 11:46:21 +01:00
James Crook
0022e0c06c Bug 1844 - Nyquist effects move subsequent envelope points by selection's length
Also renamed Envelop::Paste to Envelope::PasteEnvelope, since it was hard to find
just its usages, given the many usages of WaveTrack::Paste.
2018-08-07 10:39:18 +01:00
Paul Licameli
511b810fdc Pinned play head can be dragged during transport; dbl-click recenters 2018-08-06 21:58:42 -04:00
Paul Licameli
54807caa1a Correct flashing of the pin when dragged to extreme left or right 2018-08-06 21:58:42 -04:00
Paul Licameli
27dc8ffead Draggable pinned play head, double click to re-center 2018-08-06 21:58:42 -04:00
Paul Licameli
616ff31d04 Allow full screen of negative timeline during pinned play/record...
... (Or when dragging the scrollbar when scrolling left of zero is enabled)
2018-08-06 21:58:42 -04:00
Paul Licameli
1c5e523a1e A preference governs where the pinned head goes, not always exact center 2018-08-06 21:58:42 -04:00
Paul Licameli
b502d88285 Better enum value name 2018-08-06 21:58:41 -04:00
Paul Licameli
3010d3aaa8 More conservative rewriting of status as mouse moves over panels 2018-08-06 21:52:47 -04:00
Paul Licameli
2c28af05e8 Don't hit any TrackPanel or Ruler cells when mouse is out of window 2018-08-06 21:52:46 -04:00
Paul Licameli
74efec9d39 Bug1756 (shouldn't lose record status message) refixed differently...
... Don't let the status message during recording, about remaining disk
capacity, get lost when mouse moves across TrackPanel hit targets or toolbar
buttons.

But, will show those other messages too, only for limited time if the
mouse stops moving; then restore the capacity message.

Needed to correct for unreliability of wxTimer in AudacityProject, as with the
TrackPanel timer, by restarting it sometimes.

The intention evident in previous code was to refresh messages once every 3
seconds.  Should be better realized now.

See also the prior fix at b49e467412337be1d2aa0a3b45ba830b04a625b7
2018-08-06 20:09:39 -04:00
James Crook
cf442759b4 Add AUDACITY_FILE_SUFFIX_EVENT to ExportPCM
This signals a change in the file suffix, and it is received by the Exporter.
However, there is currently no way to change the displayed filename in
the file selection dialog.

This was a step towards a fix for Bug 1355 - "Other uncompressed files" does not (visually) update target file extension according to the chosen "Header" type
2018-08-06 15:56:56 +01:00
James Crook
7a56858f38 Bug 1893 - spurious plug-in reg error message for VidPlayVST32 (and others) 2018-08-06 13:13:34 +01:00
James Crook
901d684c3d Add Max Maisel to contributors (in AboutDialog) 2018-08-06 11:02:57 +01:00