1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-24 08:28:04 +02:00

26 Commits

Author SHA1 Message Date
Pokechu22
8db7e65505 Get rid of SetStyle for sliders
It's no longer used, and the new set up for MixerTrackCluster makes them
unable to change the type of the slider (so it should also no longer need
to be used).
2017-05-02 00:37:31 -04:00
Paul Licameli
b2ab9b5087 Simplify MixerBoard.cpp using the PlayableTrack type 2017-03-29 13:42:51 -04:00
Paul Licameli
15004b1ade More uses of std::make_unique 2016-08-08 10:07:37 -04:00
Paul Licameli
71efb13161 Remove some naked new amd delete in: widgets 2016-08-08 07:51:26 -04:00
Paul Licameli
84c0337aba Fix TAB key navigation on Mac for all dialogs (not only for panels) 2016-07-10 17:12:27 -04:00
Paul Licameli
57788c8d7a Fix Mac tabbing to sliders and meters, analogously to buttons...
... And make sure they don't steal focus when clicked or double clicked
2016-06-25 16:08:38 -04:00
Paul Licameli
4c40a913b7 Bug1202, again: Sliders in toolbars don't steal focus! ...
... However there is some code in class ASlider meant to draw focus border.
But I verified that this had no effect on Mac, even in 2.1.1.

So, still no border.
2016-06-22 16:42:59 -04:00
Paul Licameli
56acdf684c Bug1202: Slider tooltips should not steal focus on Mac. 2016-06-22 11:28:03 -04:00
Paul Licameli
990080ae7d Replace virtual with override wherever possible; eliminate needless virtual...
... for functions in final classes.

override is like const -- it's not necessary, but it helps the compiler to
catch mistakes.

There may be some overriding functions not explicitly declared virtual and I did
not identify such cases, in which I might also add override.
2016-02-26 12:35:38 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)...
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
2016-02-24 20:58:30 -05:00
Paul Licameli
2efa24bc10 Sweep unnecessary wxString copies: widgets 2016-02-22 21:30:04 -05:00
Paul Licameli
56e7653343 "delete"->"DELETE" in comments, easier to find remaining naked operator delete 2016-02-14 18:50:45 -05:00
Leland Lucius
2d88ad63e0 Fix for bug #1191 2015-09-08 11:24:59 -05:00
Paul Licameli
d18553a3f0 Put Experimental.h (redundantly) in headers that rely on it 2015-08-31 17:53:12 -04:00
Leland Lucius
6a9dae20f5 Appearance on OSX is now back to normal or better
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Leland Lucius
3064f1715f Better tooltip for ASlider
This fixes the problem on GTK where the text was unreadable when
using a "dark" theme.

And fixes the double display of the real tooltip and the tip panel
being displayed at the same time on GTK and OSX.  It seems that
the "disabling/reenabling" of tooltips doesn't take affect right
away anymore...maybe it never did.
2015-08-09 06:03:42 -05:00
Leland Lucius
255be8cfe7 Reworked the TipPanel used with ASliders
It was producing "ghost" windows on OSX in wx3.  These were
supposed to be hidden, but they weren't any longer and after
reviewing TipPanel, I realized that there was a separate
code path for OSX entirely...must've gone back to some of the
earliest versions.

Now all platforms use the same bit of code.
2015-07-20 02:10:05 -05:00
benjamin.drung@gmail.com
277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
martynshaw99
4ce2643d5f Remove the
// Indentation settings for Vim and Emacs
etc. lines from all files, as Campbell's patch (except for other changes to Languages.cpp)
2013-09-24 00:14:37 +00:00
v.audacity
1ceb0ef660 Apply modified version Roger Dannenberg's patch to remedy some problems from commit r10680 and fix some bugs. 2011-10-19 23:06:53 +00:00
mchinen
1261f6ef62 Change TipPanel to be a shared, singleton instance.
Also make linux build use wxPopupWindow.
2010-11-28 00:23:27 +00:00
rbdannenberg
f3b91514d2 NoteTrack channel buttons have prettier graphics in down position which now means ON; VEL_SLIDER depends on EXPERIMENTAL_MIDI_OUT (not USE_MIDI); velocity slider changes are labeled as such to Undo manager; fixed an OS X bug where backing bitmap does not get yellow highlight and then highlight on screen gets clobbered when user moves gain sliders (!); Added a high-level overview of redraw to TrackArtist.cpp. 2010-10-28 17:34:35 +00:00
rbdannenberg
a1f0e5ed5b Extensive changes to improve NoteTrack display and (some) editing, NoteTrack playback via MIDI, and Midi-to-Audio alignment. 2010-09-18 21:02:36 +00:00
BusinessmanProgrammerSteve
f86dca89fc Improve comments surrounding my recent slider checkin. 2010-09-04 18:21:23 +00:00
BusinessmanProgrammerSteve
bf874133a0 Fix a low-hanging memory leak found by valgrind in slider code 2010-09-04 06:58:21 +00:00
ra
e74978ba77 Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches 2010-01-23 19:44:49 +00:00