1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-05 06:09:47 +02:00

4088 Commits

Author SHA1 Message Date
Paul Licameli
a41eb4422c Fix mistake in partial reuse of caches for drawing wave & spectrum...
... But this mistake probably had no visible consequences, if total width
in pixes was unchanged.
2016-10-01 10:07:29 -04:00
James Crook
74887abb70 Device ToolBar back to customary place (by default) 2016-09-30 09:13:30 +01:00
Steve Daulton
52b1c6e00f Update and rename Click Track as Rhythm Track 2016-09-29 21:03:27 +01:00
Paul Licameli
2e8ee5fe75 Bugs 868, 1196 again: Fix alt-f6 cycle but not changing button focus
Mac and Linux problem only.

See commits 58e3f3da839694ea8da6db4aa5dce8a439a1484d
and a00f866b5425572dbb8032d93ad2627fa07e1d08
2016-09-28 11:54:17 -04:00
windinthew
acedbb8640 Fix missing/conflicted access keys 2016-09-27 19:22:00 +01:00
Paul Licameli
09cf0a6be3 Bug1450: fix TAB key navigation in metadata dialog 2016-09-27 06:19:09 -04:00
David Bailes
6261bb5a9a Equalization effect: revert one of the changes in commit fcb6221
Revert change in commit fcb6221 which affected behaviour in draw mode.
2016-09-26 09:03:54 +01:00
David Bailes
fcb6221b2c Fix for bug #1517 - Equalization sliders bug
The bug was that when the Equalization effect opens in Graphics mode, the sliders are set to zero, and don't do the right thing. This was caused by my incorrect fix for bug #1346.

Fix is to call UpdateGraphic to set the sliders up. Call to UpdateDraw also added, which includes the appropriate calls to Show, rather than have these in PopulateOrExchange.
2016-09-24 09:26:46 +01:00
David Bailes
3bb2a8b170 Fix for bug #1346 - Equalization effect always opens in draw mode 2016-09-23 13:53:47 +01:00
James Crook
086ddb62c1 Fix compiler warning "unknown escape sequence".
Debugger shows that this change has zero effect on the string (and it fixes the warning too).
2016-09-22 19:29:52 +01:00
windinthew
950f62a548 Apply Mac fixes for bugs 868, 1196 to Linux 2016-09-22 18:56:26 +01:00
Steve Daulton
229781cc12 Tweak error message
Several users have stated confusion about the old message,
thinking that it meant 'changes to the imported file', whereas
it actually refers to the 'project'.
Also fix a couple of compiler warnings.
2016-09-21 14:54:59 +01:00
Paul Licameli
f993f1eadf Regularize casts as (int), so they are easier to find and review 2016-09-20 08:42:11 -04:00
Darrell Walisser
8e1b084f01 OpenMP TrackArtist::DrawSpectrum (#165)
- make 2nd loop parallelizable
- remove number scale from both loops, only calculate one time
- initialize Acolor::GetColorGradient separately
2016-09-20 07:15:18 -04:00
Paul Licameli
b17a14ccc2 Nested loop should use a different index variable...
... but there was not a bug here, because of the return.
2016-09-20 06:32:45 -04:00
Paul Licameli
94f327d99c fix build 2016-09-19 15:49:47 -04:00
James Crook
e8f5e3e084 Revert "Avoid wasteful Refresh() in stereo track spectrogram view.
Was believed to cause other problems, namely with ruler not lining up with selection.
2016-09-19 19:59:08 +01:00
Paul Licameli
9310c8ae9b Fix warning about missing field initializers 2016-09-19 11:47:48 -04:00
Paul Licameli
f9f95471b5 Don't compile unused static function 2016-09-19 11:47:48 -04:00
Paul Licameli
412e4955af Put braces around sub-object initializers 2016-09-19 11:47:47 -04:00
Paul Licameli
53936ac970 Fix some warnings for unused variables and labels...
... But not in cases where a return status is ignored.
2016-09-19 11:47:47 -04:00
Paul Licameli
54c993c4f5 Avoid unreachable code warning 2016-09-19 11:47:47 -04:00
Paul Licameli
0eb2f85bfb Use DBL_MAX, not arbitrary 1000000000.0, as "infinite" time interval 2016-09-19 10:38:42 -04:00
Mark Young
655d7596ab Assign mMessage to the first column wxStaticText control to allow non-TimerRecord usages to work correctly. 2016-09-18 22:15:54 +01:00
Gale Andrews
17afc51644 Typo in code comment 2016-09-18 18:56:34 +01:00
Paul Licameli
236a271ef5 Avoid dangling else warning 2016-09-18 10:36:55 -04:00
Paul Licameli
981020a8fc Avoid unused parameter warnings 2016-09-18 10:36:55 -04:00
Paul Licameli
7b87ca6ffd Make switches on enums exhaustive 2016-09-18 10:36:55 -04:00
Paul Licameli
0323cb8e38 be explicit about || and && precedence 2016-09-18 10:36:55 -04:00
Paul Licameli
b6dce3e842 don't implicitly convert string literal to non-const char * 2016-09-18 10:36:54 -04:00
Paul Licameli
3b7b7e1481 avoid bogus warning about C99 compound literals 2016-09-18 10:36:54 -04:00
Paul Licameli
5d5edecca5 Remove unnecessary semicolons 2016-09-18 10:36:53 -04:00
Paul Licameli
5d102136a2 Fix noise reduction 2016-09-17 15:38:55 -04:00
Steve Daulton
341e3e1207 Fix bug 1513
The error message is still a bit strange if trying to overwrite
a different project when the current project has been saved,
(why would you do that?), but probably not worth complicating
the message for such a fringe case.
2016-09-17 15:52:52 +01:00
Paul Licameli
ad04187a41 Change sampleCount arguments, variables, return values to size_t...
... whenever they really describe the size of a buffer that fits in memory, or
of a block file (which is never now more than a megabyte and so could be fit in
memory all at once), or a part thereof.
2016-09-15 21:03:17 -04:00
Paul Licameli
078ff056e2 Make many conversions sampleCount->size_t are explicit and checked...
... with run-time assertions.

I examined each place and reasoned that the narrowing was safe, and commented
why so.

Again, there are places where the sampleCount variable will later be changed
to have a different type, and they are not changed here.
2016-09-15 21:02:32 -04:00
Paul Licameli
78be459fa1 Convert sampleCount <-> floating or -> long long explicitly ...
... A non-narrowing conversion out to long long is a necessity, but the
conversions to float and double are simply conveniences.

Conversion from floating is explicit, to avoid unintended consequences with
arithmetic operators, when later sampleCount ceases to be an alias for an
integral type.

Some conversions are not made explicit, where I expect to change the type of
the variable later to have mere size_t width.
2016-09-15 21:02:31 -04:00
Paul Licameli
99dca62cff Assert that sampleCount doesn't narrow converting to 3d party types 2016-09-15 21:02:31 -04:00
Paul Licameli
26b5e77050 Define sampleCount as a class, not a type alias...
... Define lots of operators for disambiguation, but they will go away after
all conversions from sampleCount to built-in numerical types are forced
to be explicit.
2016-09-15 21:02:31 -04:00
Paul Licameli
fbfee42a00 Remove another C style cast, and an unnecessary track kind test 2016-09-15 16:10:18 -04:00
Paul Licameli
88611a4530 Fewer C-style pointer casts of tracks; comments justify static_cast 2016-09-15 12:12:43 -04:00
Paul Licameli
837173e9ad Mac screen reader speaks the tracks' types, as also on Windows 2016-09-15 09:45:33 -04:00
Paul Licameli
fa0a603804 Fix crash when sync-lock adjusting a note track 2016-09-15 08:33:15 -04:00
Paul Licameli
d783762737 Remove unnecessary std::move in return statements...
... and comment where it is necessary.
2016-09-15 07:39:46 -04:00
Paul Licameli
4b16705aa5 a little more const 2016-09-13 22:23:17 -04:00
Paul Licameli
39d514b183 Some more const, some stl idioms, remove unused declaration 2016-09-13 22:03:58 -04:00
Steve Daulton
740ec8b72b Remove redudant comment
Residual from previous commit
2016-09-13 00:48:44 +01:00
Steve Daulton
340c1ff9f0 Merge pull request #159 from tip2tail/Bug1403SplitMessage
Bug1403 Progress Dialog Split Message Fixes
2016-09-13 00:32:14 +01:00
James Crook
0f5260e600 Bug 1512 - Extended Import: Crash dragging an importer when there are no rules 2016-09-12 20:49:49 +01:00
tip2tail
56b1f2d2cb Bug 1403 - Message can now be displayed in multiple columns
Uses 'End-of-Transmission-Block' character to mark the column split(s)
and is defined as a static constant for ease of use.
2016-09-12 19:30:10 +01:00