For Light and Classic themes that use black text, we'll use the length/end buttons because Windows uses black for text.
For Dark and HiContrast themes that use a light colour for text, we'll use the length/end buttons IF the OS is set to use the exact same colour for text.
That for example happens if we use Microsoft's HiContrast2 and our HiContrast theme.
If the OS and theme text colour differ, then if we set blend theme colours option, which is the default, we might still use the OS colour for text in Audacity. That will happen if the OS colour has decent contrast to our theme's background colour. Decent is defined as more than 250 difference in RGB values. If we use the OS colour for text, then we get the proper length/end buttons.
Note that this adds a new feature to the theme blending, in that the text colour will often adapt. Useful when using custom text colours with HiContrast2. When the text colour adapts, we will continue to get proper length/end buttons.
Advice to users is to match OS and Audacity themes, and use the blend option. When themes don't match, it may be desirable to disable blending.
They had lost the focus/voice-over functionality because I added code to draw them in the
theme colour. Now I disable that code, IF recolouring is both set and active. This will happen
for example, if Hi-Contrast is used with the Hi-Contrast system theme.
Posterisation was caused by having a bright theme cache and using a darker theme (in linux) so the light colours 'got stretched' and showed up the relatively few distinct values there. So the Classic theme is now darker, and we expect (on Windows) that it will be recoloured to windows lighter colours.
The blue-hover-blobs are centred better, and the large one is filled in now. Select colour toned down a bit from cyan, and RMS colour made more distinctive (whiter). Slider pips now less fuzzy and have 'eye' effect to aid visibility. Mute/Solo button shapes and colours modified, and unselected version is no longer solid.
Now they are in the order they appear in the default interface and manual rather than alphabetic.
Also removed combined-meter option. Upgraders will potentially continue to have it, until they select one of the single meters. The die hards could also edit audacity.cfg if they really really want it enough.
Also added some comment lines in the ext menus to clarify structure.
Rearranged both View->Toolbars and Ext-Bar->
Enabling/disabling of ext menu items may not yet be exactly what we want, e.g. enabling cursor commands depends on tracks, but enabling selection commands does not. Not fixed, as it is not clear exactly what we want.
These commands all assumed they would be activated from a key press, and so take the key up/down state into account. This is not now the case, and there is no wxEvent to pass to them if they came via a menu item.
The new preference is in the view menu and on the Gui preferences page.
Also Ext Menus rearranged to more closely match default toolbar order.
Also F11 (a new menu command to show/hide maximised) now has a check mark.
This change needs testing on mac as mac is pickier about when menus are updated.
Even though it is a built-in Audacity effect, it is more logical in plug-ins, because the actual effect that will be run when the effect is applied is a plug-in. Makes the list of effects (sorted by type) more logical.
