1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-02 16:49:41 +02:00

6994 Commits

Author SHA1 Message Date
Paul Licameli
a9f7cb26e7 Move selection state into AudacityProject, out of TrackPanel 2017-06-11 10:40:55 -04:00
Paul Licameli
4da881d1db Define and use SelectionStateChanger 2017-06-11 10:40:50 -04:00
Paul Licameli
a594207265 Define class SelectionState; move some TrackPanel functions into it 2017-06-11 10:22:52 -04:00
Paul Licameli
986f158efa Update mixer board for selection state change if MIDI tracks too...
... when EXPERIMENTAL_MIDI_OUT defined
2017-06-11 09:26:58 -04:00
Paul Licameli
a3037b5734 Move drawing of snap guidelines out of TrackPanel.cpp 2017-06-10 20:48:02 -04:00
James Crook
198dbc4c2a Support screenshots of toolbar variants.
Slightly tidied up the code too.
2017-06-10 21:33:05 +01:00
Paul Licameli
06e51ba075 Remove recursion in DrawMuteSolo...
... its purpose was not clear.  Comment suggests state update is combined with
drawing, which isn't so and shouldn't be.

So far as I can tell, all it did was make the Mute button flicker, if you
clicked on it and dragged, while the Solo button was up, AND playback or
recording was in progress.  But why?
2017-06-10 14:27:58 -04:00
Paul Licameli
48ee622c1d i18n-hint comments were wrongly swapped! 2017-06-10 14:27:18 -04:00
Paul Licameli
991819bc28 Remove #includes 2017-06-10 14:27:17 -04:00
James Crook
500907ff87 Remove text explaining the 'Help Button'.
It is a button, not an icon, so it does not need explaining what it is.  Also this solves the issue of when the help button is deliberately removed after use.
2017-06-10 18:12:32 +01:00
Paul Licameli
9363432b76 Remove an #include 2017-06-10 12:00:42 -04:00
James Crook
1fb2deb593 Fix colours that were messed up by blending.
Some button down colours were wrong from using the blending option.
2017-06-10 11:41:44 +01:00
James Crook
4db2fc34da Fix small buttons too-intense problem.
Fixed by making the smaller buttons a much less strong blue, and using bevelling to make sure there is an edge.
Also reduced bevelling to a less pop-up look, less dark and 1px wide not 2px
Also slightly rounded the larger button corners.
2017-06-10 11:24:16 +01:00
James Crook
d8a71c40eb Tweak TCP minimize button Position
It now doesn't impinge on the bottom edge of the TCP, and it is left aligned flush with the left edge.
Minimum track height increased accordingly.
2017-06-10 10:10:38 +01:00
James Crook
cea3ed5f24 Tweaks to Light theme
- Darker button backgrounds in toolbars
- More contrast in hover effect, especially for small buttons.
- Mute/Solo have same colour whether track selected or not
- TimeText displays have lighter backgrounds.
2017-06-10 09:49:42 +01:00
James Crook
7341bff9e0 Disallow AutoSelect on dangerous commands.
Commands flagged with NoAutoSelect will not auto select, even if the user has asked for it.  This is used for Cut and 3 different kinds of delete.  We later might extend it to fades and repair.
2017-06-09 22:36:05 +01:00
James Crook
64a28861a0 Make light theme default.
Or as our RM said, 'Let it be Light'.
2017-06-09 19:40:29 +01:00
James Crook
adc7312954 Auto-Select off by default.
I've implemented three states for what to do if no selection:
0 - Grey out (no longer used)
1 - Auto-select
2 - Give the warning message and try again.
2017-06-09 19:40:28 +01:00
Paul Licameli
0d899b0163 compiler warning fixed 2017-06-09 13:14:41 -04:00
James Crook
c11fd1d63f Fix positioning of solo button.
- No longer jumps right when clicked.
- Right edge is now aligned with track name drop down right edge.
- When using just a mute button, the (larger) button is centered.
2017-06-09 14:28:38 +01:00
James Crook
cecb704abb Stop splash screen position jumping (on single monitor)
This is a new problem from Windows 10 Creator's update.  The fix fixes it on single monitors, but on dual monitor it may appear first on the main monitor and then jump across.
2017-06-09 14:28:37 +01:00
Paul Licameli
3d54d912c0 some i18n-hint comments 2017-06-08 16:02:28 -04:00
Paul Licameli
010217d83c some i18n-hint comments 2017-06-08 15:41:29 -04:00
Paul Licameli
65c7beff99 Move mAdjustSelectionEdges from TrackPanel to ViewInfo 2017-06-08 15:30:52 -04:00
Paul Licameli
c300c33901 Remove a few unused members from class TrackPanel, and an unused #include 2017-06-08 15:30:31 -04:00
Paul Licameli
333c9aa91d Fix the test for removability of envelope points...
... Which went wrong in some examples of an effect applied to part of an
envelope that contains only one point; the correct result should have
a level 1 in the selection and unchanged levels left and right of it, no
matter whether the sole point was before, in, or after the selection.

Simplification may still remove that sole point yet still leave the levels
outside the selection correct.
2017-06-08 14:37:15 -04:00
Paul Licameli
a33ec61ddf Move code for toggling spectral selection (Q key) out of TrackPanel 2017-06-08 12:48:28 -04:00
Paul Licameli
a4f0a8c39a Remove some unused members 2017-06-08 12:48:28 -04:00
Paul Licameli
3255ab6c5b Remove some unused members 2017-06-07 21:57:42 -04:00
windinthew
cb039c200a Wiki wording changes
a) 'Ends to Zero Crossings' to 'At Zero Crossings' and move from Region submenu to
root because this is not only a region command and to aid finding and easy access

b) Draw Tool error message recognises again that the tool works in Waveform (dB)
2017-06-08 01:57:30 +01:00
James Crook
3cfe3eee4f Fix effects screenshot filenames. 2017-06-07 18:08:57 +01:00
Paul Licameli
05f1a03cb4 Do not HandleInterruptedDrag for ESC key, it would be redundant 2017-06-07 12:22:29 -04:00
Paul Licameli
01450e8db0 Fix pasting into envelope with only one point...
... as reported by Steve, when applying a Nyquist effect.
2017-06-07 11:13:59 -04:00
James Crook
8f66c3603d Screen capture preference panels too. 2017-06-07 15:59:25 +01:00
Paul Licameli
7bf7815c75 Move HideTopItem into class TrackInfo, for later use 2017-06-07 10:39:47 -04:00
Paul Licameli
1e7c51f1d4 Fix crash in Windows debug runtime 2017-06-07 09:16:22 -04:00
James Crook
1ce97b9d26 Shorter Grayscale Spectrum preferences text. 2017-06-07 10:48:10 +01:00
windinthew
2323e8d222 Shorter preferences 2017-06-07 10:24:10 +01:00
Paul Licameli
acce480a76 Mac: shift WaveTrack status text down one more; others: don't shift 2017-06-07 00:07:03 -04:00
Paul Licameli
2fe5731de7 More fixes for track controls layouts
Compute default WaveTrack height analogously to NoteTrack...
  Default MIDI track height is enough to display velocity slider...
  Make gain slider again visible in default sized WaveTrack
  EXPERIMENTAL_MIDI_OUT off -- then no invisible channel buttons...
2017-06-06 22:45:11 -04:00
Paul Licameli
84b5fd6075 Compute default WaveTrack height analogously to NoteTrack...
... though in fact this comes to the same 150 pixels as before, given the
present layout table.
2017-06-06 22:39:30 -04:00
Paul Licameli
f0c149b890 Default MIDI track height is enough to display velocity slider...
... It is computed from the layout table, and in fact comes to 158 pixels,
versus 150 for other tracks.
2017-06-06 22:39:30 -04:00
Paul Licameli
0204cd80c5 Make gain slider again visible in default sized WaveTrack 2017-06-06 22:39:30 -04:00
Paul Licameli
8d517bd3bd EXPERIMENTAL_MIDI_OUT off -- then no invisible channel buttons...
... They were still clickable before this commit.
2017-06-06 21:49:39 -04:00
Paul Licameli
191eeaf19e Rewrite drawing routines equivalently without kTrackInfoWidth...
... using rect.width instead; and making no changes in appearance.

Some routines, like that for the sync lock icon, are pleasingly simplified.

But see comments about some questionable things that may have been based
on the misunderstanding that kTrackInfoWidth was the width between bounding
lines, when in fact, that width was 5 less.
2017-06-06 18:28:35 -04:00
Paul Licameli
64a0d788a5 Rewrite the unused DrawBordersWithin...
... Remembering inclusivity of the endpoints in AColor::Line, and avoiding
use of the constant kTrackInfoWidth
2017-06-06 15:44:26 -04:00
Paul Licameli
ad4d6d148a Fix unintended one-pixel change in width of title button 2017-06-06 14:16:50 -04:00
Paul Licameli
6b44839e7c Fix more unclarities in the drawing code; no changed appearances
Change some names in TrackArtist to match terminology in TrackPanel
  Exclude left, top, bottom margins from rectangles describing TCP
  Exclude bottom margin from vruler rectangle reported from FindCell...
  Fix a confusion in argument names.  No change in behavior
  Explanatory comments in TrackPanel drawing; fewer magic numbers
2017-06-06 13:34:12 -04:00
Paul Licameli
ceaa050a24 Change some names in TrackArtist to match terminology in TrackPanel 2017-06-06 13:29:33 -04:00
Paul Licameli
24858dcb90 Exclude left, top, bottom margins from rectangles describing TCP 2017-06-06 13:29:28 -04:00