1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-19 09:30:06 +02:00

Remove recursion in DrawMuteSolo...

... its purpose was not clear.  Comment suggests state update is combined with
drawing, which isn't so and shouldn't be.

So far as I can tell, all it did was make the Mute button flicker, if you
clicked on it and dragged, while the Solo button was up, AND playback or
recording was in progress.  But why?
This commit is contained in:
Paul Licameli 2017-06-10 13:32:18 -04:00
parent 48ee622c1d
commit 06e51ba075

View File

@ -4968,7 +4968,6 @@ void TrackPanel::HandleMutingSoloing(wxMouseEvent & event, bool solo)
GetProject()->DoTrackMute(t, event.ShiftDown());
}
SetCapturedTrack( NULL );
// mTrackInfo.DrawMuteSolo(&dc, rect, t, false, solo);
Refresh(false);
}
}
@ -9697,12 +9696,6 @@ void TrackInfo::DrawMuteSolo(wxDC * dc, const wxRect & rect, Track * t,
SetTrackInfoFont(dc);
dc->GetTextExtent(str, &textWidth, &textHeight);
dc->DrawText(str, bev.x + (bev.width - textWidth) / 2, bev.y + (bev.height - textHeight) / 2);
if (solo && !down) {
// Update the mute button, which may be grayed out depending on
// the state of the solo button.
DrawMuteSolo(dc, rect, t, false, false, bHasSoloButton);
}
}
// Draw the minimize button *and* the sync-lock track icon, if necessary.