1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-02 16:49:41 +02:00

7073 Commits

Author SHA1 Message Date
Paul Licameli
941ad55140 Update expat sources 2017-06-28 21:16:42 -04:00
Gale Andrews
138c188fb4 Message now says merge to match with Undo History 2017-06-29 01:31:29 +01:00
James Crook
2f3530e1f8 Fix verbosity in status message. 2017-06-29 00:00:50 +01:00
James Crook
a9cbebcb0f Reduce number of shortcuts provided by default.
The full list of shortcuts, the maxList, is still available, and can be set in KeyboardPreferences.
2017-06-28 23:00:02 +01:00
Gale Andrews
17b705f2d8 Status bar help for selecting from a split line
Any ideas for shortening the new message welcome. Sometime, status bar messages want transforming to sentence case as intended.
2017-06-28 17:50:20 +01:00
David Bailes
27f706bb2c TrackPanelAx::SetFocus - minor fix
Fix for bug introduced by commit fb18f6a: mFocusedTrack needs to be updated before the focus event is sent to ensure that when TrackPanelAx::GetState is called, mFocusedTrack is the focused track.
2017-06-28 11:48:09 +01:00
David Bailes
69ab49c3a4 Fix for Audacity crashing when running Jaws on Windows 10 1703
Problem: On Windows 10 1703, with the Jaws screen reader running, additional paint messages are sent to Audacity compared with when Jaws is not running. My assumption is this is probably a Jaws bug. In particular, when a project is closed, ToolDock::OnPaint, and AdornedRulerPanel::OnPaint are called.

Fix: changes ensure that these OnPaint functions can be called without causing a crash.
2017-06-28 10:42:13 +01:00
David Bailes
d8930f00b5 Fix Windows build - simple fix 2017-06-28 09:57:00 +01:00
Paul Licameli
4c2a69cc1e More uses of shared_ptr and weak_ptr to Tracks and TrackPanelCells 2017-06-28 01:47:59 -04:00
Paul Licameli
e424f8e54e TrackPanel::mpClickedTrack is a safe weak_ptr 2017-06-28 01:46:59 -04:00
Paul Licameli
6684c7b9b0 More careful use of weak pointers to tracks in UIHandles 2017-06-28 01:46:59 -04:00
Paul Licameli
e2f0a16839 TrackButtonHandle keeps weak_ptr to the cell 2017-06-28 01:46:58 -04:00
Paul Licameli
b0c6a67c33 TrackPanelMouseEvent stores shared_ptr to cell; some handles too...
... those handles that force a simulated button-up when play interrupts drag,
and can assume that pointers to tracks remain nonNULL and part of the current
project state (not the undo history).

Also pass shared_ptr to Track into more hit test routines.
2017-06-28 01:46:56 -04:00
Paul Licameli
708d84ac22 CommonTrackPanelCell::FindTrack returns shared_ptr 2017-06-27 23:09:35 -04:00
Paul Licameli
b3208ab12d Restore status message "Click and drag to select audio" 2017-06-27 22:35:19 -04:00
Paul Licameli
1c0af82903 Changed hit test priorities; message, cursor for text box mouse-over 2017-06-27 08:34:51 -04:00
Paul Licameli
bce3571372 Redo hit test priorities in TrackPanel...
Zoom tool takes precedence;

Otherwise do special hits appropriate to the track subclass -- and only
WaveTrack here uses Tools toolbar state, and now disallows clicks on things
when they are not drawn because the view is spectrogram;

Finally, default to right button zooming in Multi tool, or to time shift in
that tool, or to selection adjustment in Multi or in Select tool.
2017-06-27 08:26:07 -04:00
Paul Licameli
9e0010ec5f Time track editing requires click on the curve in multi tool...
... and it will also work so, later, in all tools besides Zoom.
2017-06-27 08:26:07 -04:00
Paul Licameli
24ebf27bb6 Cursor change and status message for mouse over label text boxes 2017-06-27 08:16:09 -04:00
Paul Licameli
828d9c3ccd Simplify label track hit tests 2017-06-27 08:16:09 -04:00
Paul Licameli
34da6e6ad3 Mouse-over highlighting of slider thumbs in toolbar & mixer board 2017-06-27 06:38:53 -04:00
Paul Licameli
adf4c61052 New highlighed slider thumb images, distinct only in Classic theme 2017-06-27 06:38:53 -04:00
James Crook
7358c12e23 Default spectrum FFT size now 1024 (was 256) 2017-06-26 22:48:54 +01:00
James Crook
6dc52c3d7a Fix Windows build. 2017-06-26 22:47:38 +01:00
Paul Licameli
f0f4f03b42 Manage all TrackPanelCell objects by shared_ptr 2017-06-26 17:16:32 -04:00
Paul Licameli
f8b74db76e Iterators over TrackPanelCell give shared_ptr 2017-06-26 17:14:33 -04:00
Paul Licameli
58fea6d520 null check uses of CommonTrackPanelCell::FindTrack 2017-06-26 16:39:14 -04:00
Paul Licameli
28b40e02fb Manage TrackPanelResizerCell by shared_ptr, no singleton 2017-06-26 16:39:07 -04:00
Paul Licameli
35ce499ce1 Manage TrackControls and TrackVRulerControls by shared_ptr; ...
... they are not singletons; and the back-pointers to their Tracks are weak.
2017-06-26 16:34:10 -04:00
Paul Licameli
c355b82dc6 Remove a comment 2017-06-26 16:03:15 -04:00
Paul Licameli
2806b509e2 Fix crashes in repainting, and update first visible track correctly 2017-06-26 15:20:35 -04:00
James Crook
30ec8a1c90 Overdub off by default only in DA. 2017-06-26 19:44:39 +01:00
Paul Licameli
bbab89b52c Cut then paste has no net effect on envelope in some more cases...
... whereas before, some incorrect disconituities could remain near the start
of the selection.

To find reproducible cases before this commit might involve varying the left
edge of the selection by small amounts, because this problem depended on
little roundoff errors.
2017-06-26 12:04:21 -04:00
Paul Licameli
6373a5085c Select, cut, paste, undo: selection should be a point as after cut 2017-06-26 11:13:53 -04:00
James Crook
869de7d6f4 Overdub off by default.
Confused many new users in the past.  Experienced users can be expected to find it in preferences (or on menu) and turn it on, if they need it.
2017-06-26 15:31:11 +01:00
Paul Licameli
44a081c7a0 Fix pasting of envelope from expanded cutline 2017-06-26 10:23:34 -04:00
Paul Licameli
d6e09e142f more build fixes 2017-06-25 21:11:33 -04:00
Paul Licameli
8349888460 Permute the list of source files in XCode project 2017-06-25 16:16:26 -04:00
Paul Licameli
f79a4c3c4f Revert "XCode project won't forgive missing return values"
This reverts commit a2192b3734565002dbfbee52371561a76d218cf6.
2017-06-25 16:00:48 -04:00
Paul Licameli
d635535241 Fix another error in Mac build 2017-06-25 16:00:30 -04:00
Paul Licameli
a5d718f79a Fix error in Mac build uncovered by the previous 2017-06-25 15:36:32 -04:00
Paul Licameli
a2192b3734 XCode project won't forgive missing return values 2017-06-25 15:32:12 -04:00
Paul Licameli
52322da695 Fix Windows build again 2017-06-25 15:26:30 -04:00
Paul Licameli
d3c9a1decb JAWS fix?: Now do the delay of event handling...
... Queue, don't immediately process, TrackList events, and if listeners want
to hold pointers to tracks, let them use weak_ptr or shared_ptr
2017-06-25 13:35:17 -04:00
Paul Licameli
fb18f6a812 JAWS fix?: Make things safe to delay TrackList event handling...
... Re-fixing by different means the problem mentioned in commit
721faf89c63f3623a17d69c3c16eedd98a9daeec

* 'shared_ptrs' (early part):
  Use weak_ptr in track selection state
  weak_ptr not events to avoid dangling track pointers in UIHandles
  Use weak_ptr to remember focused track, don't ask for trouble
  Accessor for shared pointer to track, given only a bare pointer
  Remove oudated comment
2017-06-25 13:35:16 -04:00
Paul Licameli
4ac40d12c0 Use weak_ptr in track selection state 2017-06-25 13:35:16 -04:00
Paul Licameli
fa5a742e22 weak_ptr not events to avoid dangling track pointers in UIHandles 2017-06-25 13:35:15 -04:00
Paul Licameli
321919301e Use weak_ptr to remember focused track, don't ask for trouble 2017-06-25 13:35:15 -04:00
Paul Licameli
bd5d2bf114 Accessor for shared pointer to track, given only a bare pointer 2017-06-25 13:35:15 -04:00
Paul Licameli
1fce8b54f2 Remove oudated comment 2017-06-25 13:35:14 -04:00