Paul Licameli
6ca721b03a
Fix a string again...
...
... This string appears when you enter a positive, invalid value for peak
amplitude in the Normalize effect. It didn't look right with periods (a space
was left before the first period). Let's use parentheses instead.
2018-10-15 12:59:02 -04:00
Paul Licameli
ef97ce88ca
Correct more double spaces
2018-10-15 12:54:44 -04:00
scootergrisen
b4f7946e9b
Remove some double space
2018-10-14 10:42:01 +01:00
James Crook
e20a98588c
Replace pointless looping by 'if'
...
The for loop was only to test if *some* track was selected, and its body only needs to be executed once.
Note that an empty IteratorRange is false and one with something in it is true.
2018-10-11 12:04:43 +01:00
James Crook
7e5a716e65
Fix C4458 Warnings
...
C4458 is 'Declaration hides class member'
2018-10-10 19:46:25 +01:00
James Crook
657159d542
Fix C4189 and C4100 Warnings
...
C4189 is 'Local variable initialised but not used'
C4100 is 'Unreferenced parameter'
Fixed some other warnings, e.g. about empty if, too.
2018-10-10 19:46:24 +01:00
James Crook
5fd95dd131
Fix C4456 Warnings.
...
"C4456 declaration hides previous local declaration."
These arise from repeated declarations of the same name.
2018-10-10 17:28:50 +01:00
Paul Licameli
14fe11f4d4
Bug2008: There was error in stereo Contrast calculation, at aee4005
2018-10-07 10:29:58 -04:00
Paul Licameli
90e2da7f14
Fix uses of TrackList::GroupChannels in Mix and effect preview
2018-10-04 11:34:14 -04:00
Paul Licameli
df1103822e
Don't crash in Nyquist tools with mOutputTracks undefined
2018-10-04 10:56:03 -04:00
Paul Licameli
beebe648fb
Remove more uses of Track::SetLinked() and Track::SetChannel()
2018-10-01 13:42:36 -04:00
Paul Licameli
4aa990e835
Remove GetLink(ed) in various other places
2018-10-01 13:42:33 -04:00
Paul Licameli
22c85dd99c
Rewrite GetLink(ed) in SBSMS
2018-10-01 13:42:31 -04:00
Paul Licameli
48ae1eb3c9
Rewrite GetLink(ed) in SoundTouch
2018-10-01 13:42:31 -04:00
Paul Licameli
518df314eb
Rewrite GetLink(ed) in vamp effects
2018-10-01 13:42:30 -04:00
Paul Licameli
4c75175e41
Remove GetLink(ed) in Normalize effect...
...
... It's much simpler and should be easy to generalize, but what would be
appropriate messages?
2018-10-01 13:42:29 -04:00
Paul Licameli
aee4005044
Rewrite many iterations over tracks and channels in src/effects
2018-10-01 11:24:04 -04:00
Paul Licameli
b6a6b8e73e
Rewrite iterations over sync-lock groups
2018-10-01 11:09:20 -04:00
Paul Licameli
bb3aa00f50
Effect::CopyInputTracks was only called with two values...
...
So now it simply takes a bool.
2018-10-01 11:06:31 -04:00
Paul Licameli
2e11844f6a
Effect::inputTracks() now gives only const access
2018-10-01 10:59:48 -04:00
Paul Licameli
1be3187b99
Use TrackIterRange::Visit
2018-10-01 10:59:24 -04:00
Paul Licameli
51842fc78b
Use TypeSwitch and track_cast
2018-10-01 10:58:47 -04:00
Paul Licameli
89748cbe3c
Remove "skiplinked" argument of old track iterators
2018-10-01 10:35:46 -04:00
Paul Licameli
6930b63192
Redo track kind as an enum class defined at global scope
2018-09-29 21:41:47 -04:00
Paul Licameli
af06691982
casting of Track* to WaveTrack* happens at lower level in OD manager
2018-09-29 12:46:45 -04:00
Paul Licameli
03dc815aee
Pointer downcasts should use static_cast not reinterpret_cast
2018-09-29 12:46:19 -04:00
Paul Licameli
9481587fa8
Move menu handling functions out of class AudacityProject
2018-09-29 12:10:27 -04:00
James Crook
fd21a0f6fd
Bug 1943 - Nyquist prompt loses data when Audacity is closed
2018-09-17 21:56:28 +01:00
Paul Licameli
f61989e922
Part fixes for compilation of EXPERIMENTAL_SCOREALIGN
2018-09-05 13:25:41 -04:00
James Crook
8ed0edd599
Fix two problems with Nyquist translation.
...
1. The 'Select a File' button (which comes from wxFileSelectorPrompt) was not being translated.
2. rhythmtrack.ny was missing an (_ ) on one string.
2018-08-31 22:51:20 +01:00
James Crook
792fddbd22
Bug 1962 - Nyquist effect dialog labels not translated
2018-08-31 10:51:10 +01:00
Olivier Humbert
ac87eddd60
Update VampEffect.h
2018-08-29 23:07:37 -04:00
James Crook
0ea4ff1395
Add internationalization hints.
2018-08-28 16:35:06 +01:00
James Crook
e31fe6b242
Make AUD-DO return T or NIL as result status.
...
Previously it was returning 1 or NIL
2018-08-27 10:25:53 +01:00
Steve Daulton
70467e1523
Enable (most) Nyquist property lists for tool scripts
...
The global *TRACK* variable and its properties remain unavailable for
;type tool scripts.
2018-08-26 16:47:00 +01:00
Steve Daulton
f296f42392
Fix misleading error message
...
We are testing specifically for a selection in an 'audio' track.
2018-08-25 12:41:29 +01:00
Paul Licameli
c86a46dc99
fix Mac build
2018-08-24 17:59:18 -04:00
James Crook
66df5786de
Make AUD-DO return a cons.
...
This is simple parsing of the response from AUD-DO. The first part is the string message, the second 1 or NIL depending on if scripting reported OK or not. Note that illegal scripting options often don't produce a 'Failed' but are silently substituted with valid ones.
2018-08-24 18:45:09 +01:00
James Crook
9b84deb43b
Bug 1946 - Nyquist ;type tool effects crash if returning labels from Nyquist
2018-08-24 16:53:34 +01:00
Steve Daulton
e1ae057806
Disable experimental loudness normalizing
2018-08-22 20:45:50 +01:00
Steve Daulton
4ec1393c27
Error if Nyquist Prompt requires track election
2018-08-21 16:28:59 +01:00
Steve Daulton
94b3bf3c22
Remove superfluous log message
2018-08-21 14:09:56 +01:00
Steve Daulton
b9ec43433e
Bug 1934 residual
...
Allow generate type plug-ins spawned from Nyquist Prompt to create
a new track if none selected.
This commit also fixes preview in generators when there is no selection.
2018-08-21 14:02:48 +01:00
Steve Daulton
5be7f7db0b
White space changes
...
The Objective C++ syntax '[[' used in a couple of places (Mac only),
breaks the parser in kdevelop. As suggested by Paul, a space between the
brackets fixes the problem.
Also removed some trailing spaces.
2018-08-15 11:29:12 +01:00
Steve Daulton
8eef6dc3ef
Fix bug 1938
...
Nyquist / Adagio variable 'S' should have the value 0.25 in all but
legacy process and analyze effects.
2018-08-13 16:45:21 +01:00
Steve Daulton
0d9cd4b024
Fix bug 1937
...
';type tool' effects cannot return audio from Nyquist.
2018-08-13 14:28:33 +01:00
James Crook
3480f5aa3a
Bug 1934 - Generate audio from Nyquist prompt crash
...
We now default to Effect (EffectTypeProcess), if no type was specified.
2018-08-13 12:29:31 +01:00
James Crook
2d28b2e7e1
Bug 1907 - Mac: Some buttons in effects dialogs have non-transparent background
...
It's not clear why this worked before.
- Mac was not clearing any backgrounds for the button bitmaps.
- There were no pressed buttons defined (on any platform).
2018-08-10 18:39:34 +01:00
James Crook
7f96f85676
Add some Right-To-Left language workarounds.
...
MixerBoard, LyricsWindow, Screenshot and most effects are now LTR in RTL locales.
Also added a pref so this can be overridden. As RTL affects window creation, the language choice and this preference may only fully take effect after a restart of Audacity.
2018-08-10 18:39:33 +01:00
James Crook
233b1677dd
Bug 1914 - Enh: Clean install needed to update effect/generate/analyze/tools menu for changed plug ins
...
This code now does the clean out of pluginregistry.cfg.
Nicer for the user would be to preserve the list of hand-added plug-ins. But a clean restart is easier.
2018-08-03 19:08:40 +01:00