ShuttleGUI::AddWindow has a new argument now: positionFlags. This argument does not change the default behavior.
StartWrapLay/EndWrapLay are added, so wxWrapSizer can be used from the ShuttleGUI.
List of commands that were executed in the `src directory`:
* sed -i 's/Audacity: A Digital Audio Editor/Tenacity/g' *.h
* sed -i 's/Audacity: A Digital Audio Editor/Tenacity/g' *.cpp
Signed-off-by: Panagiotis Vasilopoulos <hello@alwayslivid.com>
... the intention being, that no string literal for a path, or its default
value, shall ever occur twice in the code, relying on long-distance coincidence
of literal values. Instead, a named Setting object is constructed once, then
read and written.
For now, the Tie... functions in ShuttleGuiBase will take references to
implicitly constructed temporary Setting objects. But all should later be
made static objects, and the constructors made explicit.
... Force you to pass bool now. Break compilation in case you pass literal
"false", rather than implicitly converting it to bool true !
See commit 7766d9a192a9d28f8207c95cdd7ce08464116525 which was in 2.3.2
But Max merged later at d9608cddea49cb33815fd9475f2b4f822913b772 in 2.4.0, with
his effect apparently written analogously with the old code in Normalize from
before that, and this quetly compiled with the wrong effects.
... Because:
1 They weren't used
2 The branches selected by them were wrongly passing user-visible prompt strings
to DoDataShuttle, which elsewhere takes a preference path (this is an error that
could have been detected and avoided if there weren't naked wxString arguments)
3 Without those branches, the affected Tie... functions become more parallel to
other ShuttleGui member functions, which might later be unified into fewer
functions
... And corrected improper connections in HistoryWindow and ContrastDialog,
improper because they got called with the wrong this pointer, to
the control instead of the dialog. But that was harmless anyway because the
handlers did not use this.
