1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-23 16:08:07 +02:00

3597 Commits

Author SHA1 Message Date
David Bailes
72c397112f Fix that the Device toolbar can be higher than it should be.
This happens on Windows 7 if the display scaling factor is set to 125% (and probably higher). This also happens on Windows 10, but only if in addition to the high scaling factor, the display scaling at high DPI is disabled on the compatibility tab of audacity.exe's properties dialog. (The behaviour on Windows 8.1 wasn't checked.) The effect of the toolbar becoming higher, is that on a row of a tooldock, no other toolbar can be in front of the Device toolbar.

In void DeviceToolBar::RepositionCombos(), the desired size of the combo boxes was set to the best size.

The fix is only use the x value of the best size, and leave the y value unchanged. Note that this may not be the only problem in the code which causes this problem, and so this problem may resurface in the future.
2016-06-13 17:50:12 +01:00
Gale Andrews
94249f1ea2 Captialization fixes.
Also renamed "Post Timer Recording Action" to "Action after Timer Recording" for
greater clarity.
2016-06-13 15:51:13 +01:00
Paul Licameli
1409c9507d Fix crashes when opening track control panel menu 2016-06-13 10:06:20 -04:00
Paul Licameli
c3437b1d6e Fix Windows build, and some compilation warnings 2016-06-13 09:42:24 -04:00
Steve Daulton
78e16f6e20 include <algorithm> to fix Linux build 2016-06-13 08:38:54 +01:00
Paul Licameli
c101f4acdb Enable yet more docking positions by wrapping the cofiguration 2016-06-12 20:21:09 -04:00
Paul Licameli
de17c1ac3a Toolbar placements can push other bars down as well as right 2016-06-12 20:21:09 -04:00
Paul Licameli
37962dd9a8 Visitors unify layout routines; now any bar can stick at lower left 2016-06-12 20:20:51 -04:00
Paul Licameli
3df50f8184 Define the default toolbar configuration (as a tree) 2016-06-12 19:32:52 -04:00
Paul Licameli
65b3d32894 Tool bar configuration stores a tree structure, not a simple sequence 2016-06-12 19:18:56 -04:00
Paul Licameli
7f920ecd0d Starting to make ToolBarConfiguration::Position more general 2016-06-12 12:41:52 -04:00
Paul Licameli
ffb681e658 Delegate reading and writing of toolbar configuration to new class 2016-06-12 10:55:47 -04:00
Paul Licameli
3c13c6eaa6 ToolDock::OnPaint assumes less about configuration details 2016-06-12 10:29:45 -04:00
Paul Licameli
b46e263afb Abstract ToolBarConfiguration further, with an iterator class 2016-06-12 10:27:54 -04:00
Paul Licameli
dd327cd304 More abstract toolbar positioning types, to be generalized later 2016-06-12 10:27:51 -04:00
Paul Licameli
036c13149b The two toolbar positioning functions are simpler and more similar 2016-06-12 08:25:45 -04:00
Paul Licameli
1b1b0ba5e7 Remove forward declaration of nonexistent type 2016-06-12 08:24:27 -04:00
Paul Licameli
0e0df1f2ff Edit toolbar tooltips mention shortcut keys 2016-06-12 00:00:04 -04:00
Paul Licameli
c1a22816f8 Tooltip for Transcription play button mentions the shortcut...
... but only for the version without shift or ctrl modifier key.

Should it mention those others too?  It might get too long.
2016-06-12 00:00:04 -04:00
Paul Licameli
1f72f8db18 Tools toolbar buttons mention shortcuts in status messages 2016-06-12 00:00:04 -04:00
Paul Licameli
e844b07a46 All Toolbars define RegenerateTooltips; invoke during project init...
... and UpdatePrefs
2016-06-12 00:00:04 -04:00
Paul Licameli
16933363fe Update ruler button status messages if changed by keystroke and...
... pointer is in it
2016-06-12 00:00:04 -04:00
Paul Licameli
bb7dba2b67 Shortcut keys can appear as intended in Track Control Panel menus...
... Delayed construction of the menus was needed.

So far this only affects the four menu items that move tracks up and down.
2016-06-12 00:00:04 -04:00
Paul Licameli
9d33d12423 Ruler button tooltip can use Mac special chars 2016-06-12 00:00:03 -04:00
Paul Licameli
5f8fad4a48 Transport button tooltips with shortcuts use Mac special chars 2016-06-12 00:00:03 -04:00
Paul Licameli
8dfaa4dcf8 Implement translation of shortcut key names to Mac special chars 2016-06-11 20:31:03 -04:00
Paul Licameli
de8d0e9918 Define Internat::Parenthesize, for good of right-to-left languages 2016-06-11 18:23:36 -04:00
Paul Licameli
203ddfd1a1 Center toolbar dock indicator triangles on edge of rectangle 2016-06-11 16:32:24 -04:00
Paul Licameli
64ad732aee Removed some unused members, made some members const 2016-06-11 16:31:38 -04:00
Paul Licameli
82cf9b3ab6 Don't increase width when a toolbar is repeatedly docked and undocked 2016-06-11 16:29:25 -04:00
Gale Andrews
9e74613a8e Disc > Disk (Bug 1400)
Also capitalize "Timer Recording" in the message because it is a unique Audacity entity.
2016-06-11 17:12:33 +01:00
Paul Licameli
df0e4945de Remove scrolling left of zero check mark from Tracks menu...
... Less need now to make it more discoverable, because we override an "off"
setting during transport with a pinned play head, thus removing some
inconsistency and confusion.
2016-06-08 18:33:02 -04:00
Paul Licameli
a610070038 May always scroll before zero during transport when head is pinned...
... regardless of preferences, but if the Tracks preference is not checked,
don't stay scrolled left of zero after stopping.
2016-06-08 18:33:02 -04:00
Paul Licameli
f21ad1ce49 Pinned playhead for recording is once again always center, not right 2016-06-08 18:08:51 -04:00
Steve Daulton
fca6285315 Add #include <algorithm> for Windows 2016-06-07 11:23:11 +01:00
David Bailes
78d7ce8aa7 Fix toolbar grabbers being in tab traversal
In commit 89e33da, the override of AcceptsFocus() was removed from the Grabber class so that ESC could cancel the dragging of a toolbar. However this meant that the toolbar grabbers were included in the tab traversal of the toolbars.

The fix is to override AcceptsFocusFromKeyboard, rather than AcceptsFocus().
2016-06-07 09:27:02 +01:00
Paul Licameli
d0d28143f7 Do not change selection when stopping non-scrub play 2016-06-06 14:18:47 -04:00
Steve Daulton
685300457c Bass and Treble update residual changes
Just a bit that got left out of the last update commit
2016-06-06 18:40:47 +01:00
Steve Daulton
e9dcf3e5e2 Add real time preview to Bass and Treble 2016-06-06 18:29:10 +01:00
Paul Licameli
d1fe0a89b5 Scrub play button becomes a stop button when pressed...
... also the corresponding menu command can stop as well as start the scrub
or seek
2016-06-06 02:12:31 -04:00
Paul Licameli
fd9d6a8fcf Set selection whenever scrub/seek stops by any means besides ESC key 2016-06-06 01:45:54 -04:00
Paul Licameli
8dab37de01 Scrub menu check items change pushed state of scrub toolbar buttons 2016-06-06 00:48:50 -04:00
Paul Licameli
fe335f3a2b Status is "Scrubbing" or "Seeking" not "Playing" at button down 2016-06-05 10:51:55 -04:00
Paul Licameli
f5c4c85653 New scrubbing toolbar; remove ruler pushbuttons. 2016-06-05 01:03:24 -04:00
Paul Licameli
0e09f2ce04 Seek, scrub images have wider gap between the triangles 2016-06-04 20:04:09 -04:00
Paul Licameli
bbfc730399 No more left-click to seek 2016-06-04 20:04:09 -04:00
Paul Licameli
39d03424d0 Better tooltip messages for scrub bar...
"Click or drag to begin scrubbing"
or
"Click or drag to begin seeking"

before the button down,

"Move to scrub"
or
"Move to seek"

after the button down,

which also appear in the status bar
2016-06-04 20:04:09 -04:00
Paul Licameli
7d0517a9c9 Don't busy-wait (excess CPU usage) after stopping scrub 2016-06-03 08:34:39 -04:00
Paul Licameli
7efb1c7303 Fix crash at startup in Mac release build 2016-06-03 08:16:42 -04:00
Paul Licameli
ef62bc4e2a Fix checkmarks and Start item in scrub handle context menu 2016-06-02 16:20:15 -04:00