1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-08-07 15:49:42 +02:00

1161 Commits

Author SHA1 Message Date
Paul Licameli
5fef82dccf Define Setting classes, bundling config path with settings value...
... the intention being, that no string literal for a path, or its default
value, shall ever occur twice in the code, relying on long-distance coincidence
of literal values.  Instead, a named Setting object is constructed once, then
read and written.

For now, the Tie... functions in ShuttleGuiBase will take references to
implicitly constructed temporary Setting objects.  But all should later be
made static objects, and the constructors made explicit.
2021-05-17 08:46:08 -04:00
Paul Licameli
406b23cae7 More uses of AUDACITY_DLL_API...
... in many places where the function call will later need to be between
modules (or libraries, or the executable) and the annotation will be a necessity
to keep the linkage working on Windows.

That's all that this sweeping commit does.
2021-05-10 10:46:55 -04:00
Paul Licameli
fbfccf1393 Delete or un-inline some constructors, assignments, others...
... Which will be needed for various reasons for Windows builds of certain
modularizations, which will otherwise complain that they can no longer
generate them as inlines.

In one case, deleted copies require explicitly defaulted moves, but they will
work as generated inline.
2021-05-10 10:46:55 -04:00
Paul Licameli
c5ebc396eb Audacity.h has shrunk to nothing, now remove it! 2021-05-10 00:05:23 -05:00
Paul Licameli
e6cd0b88bc Don't forward declare wxWindow in Audacity.h 2021-05-10 00:05:23 -05:00
Paul Licameli
f2b53c82eb Move definition of AUDACITY_DLL_API into src/CMakeLists.txt 2021-05-10 00:05:23 -05:00
Paul Licameli
e653b4aaf8 Eliminate Experimental.h, configure compile options instead...
... This makes it impossible to forget to include the EXPERIMENTAL definitions
(such as when cutting and pasting code) and so get unintended quiet changes of
behavior.

The EXPERIMENTAL flags are now specified instead in new file Experimental.cmake
2021-04-27 12:40:07 -04:00
James Crook
d47264accf Fix compilation with llvm 11.0.1 2021-04-19 12:59:36 +01:00
Leland Lucius
853e6e9fe7 Fix build when FFmpeg is disabled 2021-04-08 02:11:58 -05:00
Leland Lucius
e22af714af Bug 2736 - Recent files list can be replaced by ExportCL commands 2021-04-08 20:11:42 -05:00
James Crook
df5c8d41fb Fix build (missing include file) 2021-04-05 10:43:21 +01:00
Leland Lucius
6450495426 Bug 2211 - Mac: keyboard navigation problem in Libraries preferences dialog 2021-04-05 03:37:36 -05:00
Leland Lucius
811065cff4 Bug 2694 - Coloring of tracks in Mixer Board are awry 2021-04-02 01:11:44 -05:00
Leland Lucius
988e90ea54 Change to a KEY_DOWN event instead of CHAR event
This should prevent pasting and backspace as well.
2021-04-01 20:29:35 -05:00
Leland Lucius
e47f27b106 Prevent keyboard navigation from being blocked on Mac
Readonly or non-editable text controls block keyboard navigation
on the Mac, so make them normal text controls, but block any edits.
2021-04-01 20:01:39 -05:00
Leland Lucius
392a060389 Bug 2700 - "Failed to open the project database" 2021-04-01 01:13:15 -05:00
James Crook
ae5e768023 Bug 2726 - Enh: Some preference changes are not written until Audacity exits
Also fixed a bug with GetPreferences, where uninitialised pointers
could be used that were only meant for use when editing values
(in which path they would be initialised).
2021-03-31 16:15:51 +01:00
Leland Lucius
0a085daa92 Fix build 2021-03-29 00:05:44 -05:00
Leland Lucius
7ad50cb0ca Bug 2703 - Mac: EGAT preview dialog is hidden behind the EGAT dialog 2021-03-28 23:01:20 -05:00
Leland Lucius
895c527b6a Bug 2703 - Mac: EGAT preview dialog is hidden behind the EGAT dialo 2021-03-28 22:56:57 -05:00
Leland Lucius
fe3dfe6774 Bug 2716 - Cleared "Recent Files" are restored on next launch 2021-03-25 02:20:16 -05:00
Leland Lucius
5357161238 Adding comments to explain the stack trace when using FileDialog 2021-02-17 14:28:08 -06:00
Leland Lucius
182878caae Bug 2386 - Win/Linux: Toolbar grabber gets stuck pushed 2021-02-15 09:59:42 -06:00
Leland Lucius
fd0f24e5ff Bug 761 - Linux: VST presets correct extension no longer offered in file name/no longer added if omitted 2021-02-15 02:24:21 -06:00
Leland Lucius
217ba2bbec Handle VEL_SLIDER in SliderDialog 2021-02-14 15:55:08 -06:00
Leland Lucius
7356c735ae Bug 1982 - Numeric entry in Play-at-Speed dialog allows entries not supported by the slider or the PAS functionality 2021-02-14 15:47:19 -06:00
Leland Lucius
d21b13a8e1 Bug 2351 - Selection toolbar displays incorrect number of samples beyond 2^31 -1 2021-02-13 12:42:41 -06:00
Leland Lucius
77f3cc5506 Bug 2416 - Mac: Grabbers of other toolbars get "pushed" when dragging another toolbar over them 2021-02-11 22:27:28 -06:00
Leland Lucius
cd359768a6 Bug 2473 - Linux: Numbers on meters have opaque backgrounds 2021-02-11 19:48:32 -06:00
Leland Lucius
11076f00e0 Bug 2446 - ENH: ultra-wide toolbars (Play-at-Speed & Mixer) with reticules and no numbers look far too sparse 2021-02-10 22:46:09 -06:00
Leland Lucius
a7197d7d14 Bug 1901 - Status bar message does not update when Recording or Playback sliders are moved 2021-02-10 13:43:06 -06:00
Leland Lucius
31c0196bb4 Bug 2636 - No thousands separator in Spectral Selection toolbar 2021-02-01 23:22:05 -06:00
Leland Lucius
005ceb31fc Add missing include 2021-01-31 23:43:44 -06:00
Leland Lucius
b9eb3c3b0e Can now retry read protected configuration files
Allow us to have a single error dialog for all cases.
2021-01-31 21:57:18 -06:00
Leland Lucius
da49fe63da Wrap overly long messages 2021-01-31 17:57:32 -06:00
Paul Licameli
ef2c0fca9a Fix assertion violation on shutdown after commit 21296b0 2021-01-31 13:45:34 -05:00
Paul Licameli
3480317ecd Move FileConfig::Warn() into AudacityFileConfig as an override 2021-01-31 11:28:12 -05:00
Paul Licameli
c853450ce0 Hide two-phase construction of AudacityFileConfig in factory function 2021-01-31 11:22:48 -05:00
Paul Licameli
030ba78c5f Demote Get/SetVersionKeysInit from AudacityPrefs into FileConfig 2021-01-31 11:00:34 -05:00
Paul Licameli
05d5f2677c Fix comments, remove unnecessary #include 2021-01-31 08:51:31 -05:00
Leland Lucius
21296b0cf1 New wrapper for wxFileConfig to fix several bugs
Bug 2135 - Audacity crashes if launched with a locked pluginregistry.cfg file
Bug 2651 - If pluginregistry.cfg gets locked while Audacity is active the Plug-in Manager is blocked - with no help
Bug 2650 - Virgin launch fails with no pluginregistry.cfg file created
Bug 1264 - Writing to locked audacity.cfg not reported to user
Bug 2649 - Launching Audacity with a locked audacity.cfg file gives not one but three error messages - and no help
Bug 2652 - User is not warned if they launch Audacity with a locked pluginsettings.cfg file
2021-01-31 04:24:35 -06:00
Paul Licameli
23f32a8319 Remove some unnecessary #include directives 2021-01-30 12:37:47 -05:00
David Bailes
6c44b4fdc0 Bug 2648: Grid accessibility: location can be incorrect.
The focus location provided to assistive technology by GridAx::GetLocation() does not take into account horizontal or vertical scrolling. So if there is any scrolling in either the Metadata or Labels editor, the focus location provided to assistive technology is not the same as the focus location shown by wxWidgets.
2021-01-29 16:25:26 +00:00
Leland Lucius
3e8e5aa1f5 Ensure selected cell in visible 2021-01-27 10:03:33 -06:00
Leland Lucius
e5bb95d6f2 Bug 2083 - Labels Editor has confusing selection interface - can cause wrong labels to be deleted 2021-01-26 12:18:51 -06:00
Leland Lucius
3d632d397d Ensure row selection mode is used in grids 2021-01-25 12:57:33 -06:00
Leland Lucius
0fcf9ffb52 Bug 2083 - Labels Editor has confusing selection interface - can cause wrong labels to be deleted 2021-01-25 01:13:02 -06:00
luzpaz
7a3bdcf3f2
Fix typos (user facing and non-user facing) (#727)
Found via `codespell v2.1.dev0`  
`codespell -q 3 -S *.po,./lib-src -L parm,parms,toke`
2021-01-24 09:46:08 +00:00
Leland Lucius
4b07fbaa8a Bug 2642 - Metadata Editor: Cut and paste does not work 2021-01-23 17:27:31 -06:00
Leland Lucius
50e803a974 Rework of commit b4a0be9
See comments 6-9 in bug #2642 for the problem it caused.
2021-01-22 15:16:38 -06:00