1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-13 15:38:56 +02:00

623 Commits

Author SHA1 Message Date
lllucius
8d4fb73452 When libid3tag encounters the "TYER" tag, it converts it to a
"ZOBS" (obsolete) tag and adds a "TDRC" tag at the end of the
list of tags using the first 4 characters of the "TYER" tag.
Since we write both the "TDRC" and "TYER" tags, the "TDRC" tag
will always be encountered first in the list.  We want use it
since the converted "TYER" tag may have been truncated.
2011-03-02 08:47:45 +00:00
lllucius
60af76d2b3 Bugs 188 and 225
Refer to bugzilla for discussion, but, to summarize, this removes any writing of ID3V1 tags.  ID3V1 tags will still be imported, but they will be written as ID3V2 tags.
2011-03-01 07:06:58 +00:00
lllucius
031a9e0af3 Bug 265 fix for MP2 files. 2011-03-01 06:56:50 +00:00
mchinen
5e4250e302 bug 26 - add modeless warning dialog for missing aliased files during playback. 2011-03-01 01:29:03 +00:00
lllucius
17f8ef9d5a Fixes ANSI build...sorry about that. 2011-02-27 18:34:03 +00:00
lllucius
2d7b81145c This should fix bug #265 by writing both old and new year to tags. Since ID3v2 allows for unrecognized tags, there's no reason not to write both the old (TYER) and new (TDRC) tags. This should provide the year to apps using ID3v2.3 or ID3v2.4. 2011-02-27 03:52:36 +00:00
v.audacity
880b1b8c4b Bug 258 (P2) - Mixer Board: max peak and clipping lines removed
Update comments to reflect sticking with this fix, per http://bugzilla.audacityteam.org/show_bug.cgi?id=258#c13.
2011-02-26 23:19:19 +00:00
v.audacity
0526b8c98a Adjust some comments. 2011-02-26 23:17:26 +00:00
v.audacity
9bbfeceea7 Upgrade some log message calls. 2011-02-26 01:51:44 +00:00
v.audacity
20f37df3ec Bug 258 (P2)- Mixer Board: max peak and clipping lines removed
Moved updates for Mixer Board meters back to TrackPanel::OnTimer() to see if it helps Mac performance issues reported by Bill (http://bugzilla.audacityteam.org/show_bug.cgi?id=258#c9).
2011-02-26 01:50:49 +00:00
v.audacity
2362aca9a6 Remove wxLogNull declaration from LoadModule(wxString fname) as it obviated subsequent calls to wxLogDebug().
Add call to wxLog::FlushActive() to end of AudacityApp::OnInit() so calls to wxLog*() in Load*() calls get written to log.
2011-02-25 05:29:17 +00:00
v.audacity
f48d2ad721 In AudacityApp::OnInit(), move creation of mLogger = new wxLogWindow() earlier, so that messages in LoadModules(), among others, are not lost in the log. 2011-02-25 05:14:36 +00:00
v.audacity
812bc6bf65 Add comment about possible thread problems, MixerTrackCluster::UpdateMeter(), first "if" statement:
// Vaughan, 2011-02-04: Now that we're updating all meters from audacityAudioCallback, 
      //    this causes an assert if you click Mute while playing, because ResetMeter() resets 
      //    the timer, and wxTimerbase says that can only be done from main thread -- 
      //    but it seems to work fine.
2011-02-25 05:08:59 +00:00
mchinen
4c766b2714 bug 11: fix bad index typo. may fix bug 11 issues on win 7. 2011-02-24 17:59:05 +00:00
lllucius
85b0e44e2e Add missing include. 2011-02-24 04:38:40 +00:00
lllucius
07661c186f Fixes detection problems on Mac and possibly Windows (Bug #290)
This should fix the detection problems on the Mac and may even help with issues
on Windows and Linux.

On any of the platforms, the main issue is the search path for libraries and
how absolute path names are handled.  The Mac seems to be especially
susceptible since there isn't one concrete location where libraries are stored.

Windows handles absolute paths differently and allows runtime updates to the
environment variables (and if push comes to shove, provides the
SetDllDirectory() function), so if problems still exist, they should be easy to
circumvent.

This patch does three things:

1)  It adds a shell script on OSX that takes care of starting Audacity after
reassigning and clearing the DYLD_LIBRARY_PATH environment variable.  This will
allow loading of libraries from their absolute path rather than searching
DYLD_LIBRARY_PATH first.  This script should be transparent to the user, but it
will affect people running Audacity with gdb as they will have to specifically
target Audacity.app/Contents/MacOS/Audacity instead of the Audacity.app bundle.
 Not big deal really.  If ppl no enough to use gdb from the command line, they
should be able to figure it out.

2)  It corrects detection of a monolithic FFmpeg library.  This is one where
avformat, avcodec, and avutil have all been linked into one large library.  The
main issue here was that under OSX and Linux, looking for symbols that should
reside in avutil and avcodec, would always succeed since dlsym() on these
platforms not only scans the requested library, but any dependent libraries as
well.  And when avformat was loaded, it would pull in it's dependent libraries
as well.

Another issue here was the if it was determined that the library was not
monolithic, the library was never unloaded, so those dependent libraries may
have come from the wrong location since they would have been loaded via the
normal search paths and not by absolute path name.

3)  It adds a method to FileNames which returns the full path name of a loaded
module that contains an address.  In the case of FFmpeg, it is used to verify
that a routine from a specific library is actually being used from that library
or not.  It is also used to show (in Help->Show log) the directory from which a
library was actually loaded.
2011-02-23 01:41:40 +00:00
v.audacity
6c147de4ab Bug 113 (P2) - Dependencies dialogue not safe against user error
Fix for resize improvement per http://bugzilla.audacityteam.org/show_bug.cgi?id=113#c42. File size column is now always 120px. The rest, less 8px for border, is for file name.
2011-02-22 08:57:13 +00:00
mchinen
e68767cd04 re-add and update device preferences to match new device model.
also restores portaudio device defaults functionality when the device can't be found.
2011-02-19 21:53:22 +00:00
v.audacity
77b1be7f3d Bug 113 (P2) Dependencies dialogue not safe against user error
Make dependencies dialog resizable.
2011-02-17 01:26:57 +00:00
mchinen
96390e5170 fix linux build from last commit 2011-02-13 23:27:59 +00:00
james.k.crook
207b3c6941 Reverted changes to wxPathOnly as it requires a more comprehensive change throughout Audacity. Doing half of it will break projects in Linux with '\' in their filename. (comments in Bug 120, comment #3.) 2011-02-13 23:11:51 +00:00
mchinen
4a762fc936 bug 29/11 - add rescan capability for devices.
This is a workaround for the portaudio issue where changing the default device in xp will corrupt the portaudio device indecies.
This combined with the portmixer fix (earlier today) should address bug 29.
2011-02-13 23:00:43 +00:00
james.k.crook
271c4b0112 Consistency: wxFileNameFromPath replaced by GetFullName() [related to fixes to bug 120]. 2011-02-13 22:44:21 +00:00
james.k.crook
aca8734795 Possible-Fix: Linux path separator issue, believed caused by wxGetPathOnly(). Only tested under Windows. (Bug 120). 2011-02-13 22:25:18 +00:00
mchinen
b6ee2bf9f5 add missing files from last commit 2011-02-13 18:59:02 +00:00
mchinen
fe570ac355 add singleton device manager to refactor and minimize portaudio change bugs. Adds rescan functionality which will address some bugs but not added to menu yet. will add files to mac and windows build soon 2011-02-13 18:57:43 +00:00
james.k.crook
fd9ac6bf09 Fix: slowdown with many labels caused by LyricsWindow. (Bug 144) 2011-02-12 18:33:49 +00:00
mchinen
8c805c03dd DeviceToolBar.cpp: better redraw on change host.
Also fixes an issue where the combo boxes on other project's device toolbars wouldn't resize when the active projects device toolbar changed the host.
2011-02-12 18:25:06 +00:00
james.k.crook
0d6197b2a8 Fix: Regression - Region save can save a cursor position again, now. (Bug 273) 2011-02-12 17:13:07 +00:00
james.k.crook
31c10bd86a Restore safety files (.bak) sooner. The aim is to be back in a good state before we show the error dialog. 2011-02-12 14:37:00 +00:00
james.k.crook
6bdfb13b45 Fix: "\" in file name gives disk full error. Now we complain about a non-existent directory instead. (Bug 120). 2011-02-12 14:25:51 +00:00
james.k.crook
91b1124a39 Completion of fix for bug 229, so that we check against changes in progress rather than the master list. 2011-02-12 12:40:49 +00:00
james.k.crook
01c8c239d0 Fix: Same hot-key configurable to multiple commands. (Bug 229) 2011-02-12 12:13:32 +00:00
v.audacity
ca35e29a0f Remove unused var. 2011-02-11 00:33:55 +00:00
james.k.crook
73b7d4dba3 Patch to fix menu hot-key conflicts on mac, fixing bug 88, (adapted from patch by Gale) 2011-02-10 21:16:14 +00:00
richardash1981
5304bbf19a Warning supression patch from Benjamin Drung 2011-02-07 20:28:20 +00:00
richardash1981
2a7c7de30d Commit a warnings removal patch from Benjamin Drung to correct a string of minor misdemeanors. 2011-02-07 20:24:04 +00:00
mchinen
22b64149de DeviceToolBar.cpp: Make all projects' device toolbar reflect the changes when made in another project. 2011-02-07 00:41:51 +00:00
mchinen
a9437f795b DeviceToolBar.cpp: Better event handling -
Make OnChoice only do the action associated with the combo box being interacted with.
Also refactor associated input and output device code into new function.
2011-02-06 23:34:32 +00:00
mchinen
046593405f bug 11 followup: DeviceToolBar - for Win DirectSound and MME don't allow input source lookup for the mapper devices.
This is kind of a hack that relies upon portaudio to make the first index the mapper for these apis.  I verified this for MME in portaudio src, but could not for DirectSound, so this may need to be reverted.
Should address gale's issues on win xp.
2011-02-05 19:07:02 +00:00
mchinen
fff977b942 ToolBar.cpp: remove excessive drawing on reset (as well as other resizing/positioning functions.)
Was causing an issue with the DeviceToolBar (discussed in bug 11,) but this change will speed up redraw of other toolbars as well.
2011-02-05 14:16:44 +00:00
mchinen
9e5cb8f6af DeviceToolbar.cpp: better fit for resize and fix overspilling of channels combo when toolbar is very small. 2011-02-05 13:37:31 +00:00
mchinen
500b3a32df DeviceToolBar.cpp: fix possible index out of bounds case 2011-02-05 10:04:29 +00:00
v.audacity
7a507aca95 Bugs 255 and 148 (P3)
Commented out some code. Since Roger's fix is to not use r, no reason to declare or calculate it, or link.
2011-02-04 22:02:10 +00:00
v.audacity
205a384e93 Bug 255 (P3) - Spurious drawing in wave tracks/focus border when manipulating gain sliders
Bug 148 (P3) - Label keystrokes painted at playback position 

Roger's patch for Bug 255 is to Refresh the whole TrackPanel. He says this should also fix Bug 148.

We'll see if it's too much of a performance hit.
2011-02-04 21:52:33 +00:00
james.k.crook
fa8d42e664 Restructure to a switch statement (John Clark) 2011-02-03 12:35:31 +00:00
mchinen
df6e56a57e DirManager.cpp: refactor near identical methods Move/CopyToNewProjectDirectory to use the same code 2011-02-02 20:42:43 +00:00
mchinen
3abd32a98b DirManager.cpp: remove old cruft comments and return an false on error 2011-02-02 20:11:42 +00:00
v.audacity
63f391ba46 Minor changes to comments. 2011-02-02 00:43:00 +00:00
v.audacity
39adb7b552 Fix bug in WarningDialog where dismissing via the close box made "don't show again" checkbox always stored as true, because EndModal() was called not via WarningDialog::OnOK() and the return value was 5101. So the prefs file had 5101, which is later read as "true", regardless of the actual setting of the checkbox.
Various other cleanup.
2011-02-01 22:30:10 +00:00