1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-12-27 15:08:39 +01:00
Commit Graph

5755 Commits

Author SHA1 Message Date
Paul Licameli
498747269c Correct test of equality of hash maps 2018-01-09 01:00:11 -05:00
Paul Licameli
bec6f237bc Fix compilation warnings on Mac 2018-01-08 19:09:13 -05:00
Paul Licameli
cb403954fa Use std::[tr1::]unordered_(set|map), not the wxWidgets container macros 2018-01-08 18:22:51 -05:00
Paul Licameli
cd8ec5e6a8 Try another fix for AppVeyor. 2018-01-08 16:44:59 -05:00
Paul Licameli
57c68d144e Revert "A more elegant fix of an (incorrect) MSVC compiler warning..."
Because it might be what make AppVeyor choke.

This reverts commit 2c3331424b.
2018-01-08 15:20:48 -05:00
Paul Licameli
6967925e48 Redo CommandManager::DescribeCommandsAndShortcuts with pairs...
... Later we may make other types for the members of that pair.
2018-01-08 14:14:22 -05:00
James Crook
21192a7e7b ZoomToggle - Changes from user feedback.
- Enable ZoomToggle Button by default.
- Set less extreme defaults.
- Repurpose 'Z' shortcut (from Zero Crossings)
2018-01-08 12:51:16 +00:00
Paul Licameli
8a074770e8 IdentInterface::GetDescription() returns a translated string...
... See commit 3b90538b84 which removed the
only use of the untranslated strings.

Also follows better i18n guidelines for composing the VSTEffect description.
2018-01-07 21:16:26 -05:00
James Crook
bf30c6198c Improve mouse wheel zooming
Zooming with mouse was virtually unusable before this fix, as the location of interest would move
around too much on a zoom in.
2018-01-07 18:28:42 +00:00
James Crook
0cc9c6bc3b Zoom Toggle
Added preferences for Zoom-Toggle and put into menus.
New helper functions for determining zoom scaling.

Optional EXPERIMENTAL_ZOOM_TOGGLE_BUTTON added, and Light theme updated.
Not enabled for 2.2.2.
2018-01-07 17:14:33 +00:00
James Crook
f57fdc99d7 Fix MSVC Build
SIGTRAP is not defined for MSVC.
2018-01-07 17:14:31 +00:00
Richard Ash
499c6b4f36 Fix building without libid3tag (#230)
* Fix building without libid3tag

* Fix building without libid3tag

Extend the pull Audacity#214 from torto9 to fix building
with twolame but without libid3tag
2018-01-07 12:06:33 -05:00
Paul Licameli
70167a80fe Make _ force crash in debug build, if used in static initializer 2018-01-06 21:07:29 -05:00
Paul Licameli
c6696f1b49 Move definition of _ and related into Internat.h 2018-01-06 21:03:32 -05:00
Paul Licameli
e37d701bc0 WXINTL_NO_GETTEXT_MACRO defined in compiler options...
... so even if you neglect to include Audacity.h, it applies
2018-01-06 20:56:51 -05:00
Paul Licameli
6f7739464e Fix line endings 2018-01-06 20:15:51 -05:00
Paul Licameli
2c3331424b A more elegant fix of an (incorrect) MSVC compiler warning...
... that the structure can never be instantiated.
2018-01-06 19:26:52 -05:00
Paul Licameli
5358e41510 indentation 2018-01-06 18:41:33 -05:00
Paul Licameli
ebc1092c4c One of the compilation warning patches in f463eda36c made a bug...
... the variable bin may indeed be sometimes negative:  see the test that
follows.
2018-01-06 18:33:06 -05:00
James Crook
27d2b7c51b Add AutomationCommands class
- AutomationCommands replaces GetAllMenuCommands, and can provide
information about menus, buttons and toolbars to a script.
- BatchCommands can now return textual results to a script.
- There's a new GUID for mod-script-pipe and it is included in the .sln.
2018-01-06 19:27:45 +00:00
José Manuel Ferrer Ortiz
f332b9e3cf Obtain file extension starting from the last . (rather than the first) on Export command 2018-01-06 19:50:11 +01:00
José Manuel Ferrer Ortiz
4f76a4b5e1 On GetTrackInfo command, return end time (a double) with all its decimals
It's needed when we try to end a selection - with Select command - at the end of a track, because the value returned by GetTrackInfo was rounded, and therefore Select command would sometimes fail with "End time is after end of track!" error.
2018-01-06 19:35:44 +01:00
James Crook
5e761f2245 Fix Record button pops up when clicked and it is down. 2018-01-06 16:15:04 +00:00
James Crook
d2fe7b1757 Clean up most remaining MSVC warnings. 2018-01-06 13:03:48 +00:00
Paul Licameli
c6bbe4c3da Fix subtle error revealed by the previous commit ...
... A "translated" effect family string, plus "/Enable",  was used as a
registry key for lookup!  It is wrong to key on a translation.

But in fact exhaustive search for "/Enable" shows that the only such strings
for which a written (by EffectsPrefs) registry value could be found were

AudioUnit
Ladspa
LV2
Nyquist
VAMP
VST

And none of these was actually a msgid in audacity.pot.  So nothing bad can
really have happened in other locale settings.
2018-01-05 18:39:43 -05:00
Paul Licameli
cafbff9ff8 Separate plugin accessors for translated and unstranslated strings...
... because I want to make a type distinction later.

Replace calls to GetXXX() without argument, with GetTranslatedXXX() --
this reveals a subtle error, see next commit.
2018-01-05 18:30:35 -05:00
Paul Licameli
91b0e82c11 PluginDescriptor versions are in fact untranslated; make that clear...
... though the version (like the description) really wasn't yet used for
anything but to write and read again from the registry, still keep writing it.

Because it is appropriate to write untranslated strings to the registry, and
perhaps the values in old registries really will find a future use.
2018-01-05 18:24:22 -05:00
Paul Licameli
3b90538b84 Remove description from PluginDescriptor...
... it was simply written to registry and read again, serving no other
purpose.

But still write a blank to registry for backwards compatibility of the .cfg
file.

This makes it irrelevant whether the value of IdentInterface::GetDescription()
ought to be localized (registry values should probably not be).

Therefore IdentInterface::GetDescription can return localized, and it's all
right that the return be computed (as in VST effects), rather than
an unlocalized msgid that we rely on as an internal identifier.
2018-01-05 18:24:10 -05:00
Paul Licameli
1320879ab4 Reimplement multi-column format of TimerProgressDialog...
... Specify an array of arrays of strings.  Don't pack it all as a single
string that is parsed.  This makes the setup clearer.

It also avoids some concatenations of localized strings (which I want to
make uncompilable some day), and also removes the need for translators to
count the \n's and replicate precisely.
2018-01-05 16:20:33 -05:00
Paul Licameli
e19a4fa943 Timer record exits Audacity more gracefully...
... the direct call to exit(0) caused SIGABRT for me during shutdown on Mac.
2018-01-05 16:20:31 -05:00
Paul Licameli
78aca8c133 Remove inclusions of Menus.h 2018-01-05 09:27:31 -05:00
Paul Licameli
ab6de1181d No more functor objects; all command handler functions take same args 2018-01-05 09:27:29 -05:00
Paul Licameli
77c392d29c AudacityProject::OnEffect wraps new function DoEffect 2018-01-05 09:27:28 -05:00
Paul Licameli
6dead232f2 Pair CommandHandlerFinder with functor everywhere, but not used yet 2018-01-05 09:27:25 -05:00
Paul Licameli
d263eaa97b Remove the special PopupFunctor, redo it by other means...
... it was only used, so far, by the scrubber.
2018-01-05 09:27:23 -05:00
Paul Licameli
1e3ab82a01 Effect commands store PluginID in CommandEntry parameter, not functor 2018-01-05 09:27:21 -05:00
Paul Licameli
05984e8bfb CommandEntry stores a string parameter, passed in CommandContext 2018-01-05 09:27:19 -05:00
Paul Licameli
0a711d8b26 define CommandContext 2018-01-05 09:27:17 -05:00
Paul Licameli
aa5c3f12a3 easy change key bindings 2018-01-05 09:27:11 -05:00
Paul Licameli
1f7b62f056 AudacityProject::RebuildAllMenuBars is static 2018-01-05 09:19:07 -05:00
Paul Licameli
3769fdea0e fix build 2018-01-05 01:00:14 -05:00
Paul Licameli
b53e7d7a8a change a comment 2018-01-05 00:54:13 -05:00
Paul Licameli
c66eae1a46 Fix uses of wxPLURAL and update audacity.pot ...
so that
(1) we really get msgid_plural entries in the .pot
(2) i18n-comments get extracted too (needs workaround of xgettext bug)
2018-01-05 00:35:04 -05:00
Paul Licameli
baec816142 Rewrite the composition of clip messages in i18n-friendly way 2018-01-04 09:43:25 -05:00
Paul Licameli
def1d52505 Substitute, don't concatenate, when composing localized strings...
... Avoid English syntax bias.
2018-01-04 04:30:46 -05:00
Paul Licameli
fa7f1a455b Correct self-names for the two Chinese locales 2018-01-03 19:33:04 -05:00
Paul Licameli
e051de0b68 Abandon the drag-and-drop of plug ins for now. 2018-01-03 18:43:06 -05:00
Paul Licameli
815a80846d String literals for UTF-8 language names using octal escapes only...
... Leaving absolutely no doubt about the portability.

New Perl script in locale emits the required C++ source when LanguageNames.txt
is updated.
2018-01-03 18:01:47 -05:00
Paul Licameli
0df94faad8 The message is not in fact a format 2018-01-03 16:55:46 -05:00
Paul Licameli
50d6e75185 null checks -- fix Linux crash in drag-dropping files onto app icon? 2018-01-03 15:35:49 -05:00