Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-06-24 16:20:05 +02:00
Code Issues Releases Wiki Activity

PluginDescriptor versions are in fact untranslated; make that clear...

Browse Source 
... though the version (like the description) really wasn't yet used for
anything but to write and read again from the registry, still keep writing it.

Because it is appropriate to write untranslated strings to the registry, and
perhaps the values in old registries really will find a future use.
This commit is contained in:
Paul Licameli 2018-01-05 17:32:20 -05:00
parent 3b90538b84
commit 91b0e82c11
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/PluginManager.cpp
View File

@ -1150,9 +1150,9 @@ wxString PluginDescriptor::GetName(bool translate) const
return translate ? wxString(wxGetTranslation(mName)) : mName;
}
wxString PluginDescriptor::GetVersion(bool translate) const
wxString PluginDescriptor::GetUntranslatedVersion() const
{
return translate ? wxString(wxGetTranslation(mVersion)) : mVersion;
return mVersion;
}
wxString PluginDescriptor::GetVendor(bool translate) const
@ -2206,7 +2206,7 @@ void PluginManager::SaveGroup(wxFileConfig *pRegistry, PluginType type)
pRegistry->Write(KEY_PATH, plug.GetPath());
pRegistry->Write(KEY_SYMBOL, plug.GetSymbol());
pRegistry->Write(KEY_NAME, plug.GetName(false));
pRegistry->Write(KEY_VERSION, plug.GetVersion(false));
pRegistry->Write(KEY_VERSION, plug.GetUntranslatedVersion());
pRegistry->Write(KEY_VENDOR, plug.GetVendor(false));
// Write a blank -- see comments in LoadGroup:
pRegistry->Write(KEY_DESCRIPTION, wxString{});

3
src/PluginManager.h
View File

@ -62,9 +62,10 @@ public:
const wxString & GetPath() const;
const wxString & GetSymbol() const;
wxString GetUntranslatedVersion() const;
// These return translated strings (if available and if requested)
wxString GetName(bool translate = true) const;
wxString GetVersion(bool translate = true) const;
wxString GetVendor(bool translate = true) const;
bool IsEnabled() const;
bool IsValid() const;