When compiling with CMake and MinGW, I got these two errors:
audacity/lib-src/mod-script-pipe/PipeServer.cpp:18:29: warning: ISO C++ forbids converting a string constant to 'LPTSTR' {aka 'char*'} [-Wwrite-strings]
18 | LPTSTR pipeNameToSrv= _T("\\\\.\\pipe\\ToSrvPipe");
audacity/lib-src/mod-script-pipe/PipeServer.cpp:32:32: warning: ISO C++ forbids converting a string constant to 'LPTSTR' {aka 'char*'} [-Wwrite-strings]
32 | LPTSTR pipeNameFromSrv= __T("\\\\.\\pipe\\FromSrvPipe");
The solution is to replace LPTSTR and convert these two pointers into two const objects.
Bug 2062 - Export as WAV does not remember the previously used setting
Bug 1355 - "Other uncompressed files" does not (visually) update target
file extension according to the chosen "Header" type
Bug 1356 - "Other uncompressed files" forces the default extension for
the format in the exported file
Bug 1381 - Export other uncompressed formats incorrectly assumes max 255
channels
(and possibly others...not the best bugzilla searcher)
When upgrading portaudio to the r1966 revision back in
March of 2016, the pa_unix_oss.h file was lost. This
is an Audacity specific/provided file.
Doubtful that the OSS interface is used on Linux much,
but it could be used on other Unix-like systems.
It's still has some work, but it successfully builds on
all 3 main platforms. Some of the outstanding items
include:
Install target testing (mostly important for Linux)
CMakeList clean up and comments
Debug and Release build verification
Audit of compile/link options
Need a Mac signed and notarized build
(and probably more)
These are ancient and "configunix.h" was being pulled in
via Types.h. Nothing major, but they were generated for
a 32-bit system and "may" cause problems when used on
64-bit systems.
(That's unlikely though since they haven't all this time.)
... Problem with static initialization order of ReservedCommandFlags, caused
wrong enablement of menu items (at least on Mac), such as Plot Spectrum or
Contrast enabled when there was no selection
Author: Paul Licameli <paul.licameli@audacityteam.org>
Date: Mon Feb 26 11:18:22 2018 -0500
Use casts with function pointers to quiet compilation warnings in Nyquist
Author: Leland Lucius <github@homerow.net>
Date: Wed Oct 2 10:17:00 2019 -0500
Possible fix for bug #590
This change reduces the risk of LADSPA plugins referencing
Audacity symbols by using the RTLD_DEEPBIND flag when loading
the plugins.
It also addresses an issue specific to the "blop" plugins where
they load their own libraries (without RTLD_DEEPBIND).
A much better solution would be to change Audacity's default
symbol visibility to "hidden" which would expose ONLY symbols
specificially marked as visible.
Author: Paul Licameli <paul.licameli@audacityteam.org>
Date: Tue Nov 13 08:36:22 2018 -0500
lib-src/libnyquist: fix warning about always-false comparison...
... but this raises questions about the intention to catch negative values,
which if they ever happened, were just mis-cast to unsigned at call sites
Author: Paul Licameli <paul.licameli@audacityteam.org>
Date: Tue Feb 27 13:51:10 2018 -0500
Changes to make xlisp.h usable in C++ code...
1) #include guard
2) "C" linkage for all function declarations
3) some uses of const
and a1dc8305f0a369b97b6a9f44d4e97197f1983872
Author: Paul Licameli <paul.licameli@audacityteam.org>
Date: Thu Feb 22 01:02:15 2018 -0500
Fix mistake in commit a1dc830 and add a comment
Author: Paul Licameli <paul.licameli@audacityteam.org>
Date: Wed Feb 21 15:46:18 2018 -0500
A function to extend XLisp's table of function bindings dynamically
Author: James Crook <james.k.crook@gmail.com>
Date: Sun Jun 26 08:35:19 2016 +0100
Bug1223: (correction). Fix new potential crash in following pointer.
With recent changes to the Nyquist code for freeing blocks, the pointer 'next' could be uninitialised when 'list' points to the zero chain. So Audacity would follow a rogue pointer. We'd get away with it if the uninitialised value happened to be zero.
Author: Mojca Miklavec <mojca.miklavec.lists@gmail.com>
Date: Fri Feb 26 15:11:55 2016 +0100
comment out extra tokens at end of #endif directive to avoid compiler warnings [-Wextra-tokens]
Author: Julien Nabet <serval2412@yahoo.fr>
Date: Sat Nov 7 22:47:34 2015 +0100
cppcheck: fix 2 reports
[lib-src/libnyquist/nyquist/nyqsrc/sndwritepa.c:249]: (style) Same expression in both branches of ternary operator
[lib-src/libnyquist/nyquist/nyqsrc/f0.cpp:137]: (error) Mismatching allocation and deallocation: results
