The main point of this is not to ask for overcrowded rulers.
We already handle overcrowded rulers well, by not showing the minor ticks.
This change means that we are more likely to ask for a spacing that works.
In turn that means that we are less likely to have anomalies where numbers disappear due to overcrowding and reappear again as you resize the ruler.
Modification to commit 7ab4b8c. The first non-zero digit only becomes the focus on the first visit to the control. On subsequent visits, the focus is the previous focus. Example use case: modifying start and end times by a tenth of a second. The user can move between the controls without loosing his "place".
The name of the button was not being read as "help" by NVDA due to its built in appmodule for audacity. This meant that the empty label was being read rather than the accessibility name.
Fix: Call SetLabel. In addition, with the label being set, an accessible does not need to be set, because we can just let windows set the accessibility name from the label.
Prefs dialog can now be more compact, but the tree control gains scrollers which look poor. So a height of at least 480px, if no height was set by the user, is used. This way also the key config prefs have reasonable height.
Doesn't set the min size. On small screens, users can scrunch the dialog up tightly if they really want to.
... This may make a difference and breadk compatibility only for Sliding Time
Scale/Pitch Shift, the one effect for which those were different.
Using a locale-independent internal string in a config file is the Right
Thing To Do.
The third argument of ASlider constructors already provided suitable accessibility names. So removed the unnecessary calls to SetName which set unsuitable names.
... Allow recording stereo into non-adjacent mono tracks, if they are selected.
Prefer the earliest-starting set of tracks in the track list, among either
selected tracks, or else among all tracks.
Therefore if selection contains a mono, a stereo, and a mono in that order,
the two monos may be chosen to record new stereo.
The worst symptoms of this are fully fixed.
1: The device info now uses all the space in the toolbar, no matter how the toolbar is resized.
2: The undocked toolbar can now be moved around repeatedly without changing size at all.
There is a small residual - a much toolbar size change of a few pixels on docking. The contents though still fit nicely. The 'incredible' part of this bug is gone. I'd like us to close this bug as the residual of a few pixels change in the toolbar size on repeated docking and undocking scarcely matters.
