Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-08-05 06:39:26 +02:00
Code Issues Releases Wiki Activity
4,773 Commits 23 Branches 23 Tags
Commit Graph

3245 Commits

Author SHA1 Message Date
Paul Licameli
6a3d99a8e6 travis 2016-02-24 21:14:19 -05:00
Paul Licameli
7824e94030 Harmlessly qualify classes as final (or explicitly comment not)... 
... Should have no effect on generated code, except perhaps some slight faster
virtual function calls.  Mostly useful as documentation of design intent.

Tried to mark every one of our classes that inherits from another, or is a
base for others, or has abstract virtual functions, and a few others besides.
 2016-02-24 20:58:30 -05:00
Paul Licameli
e2f7e5f6f6 travis 2016-02-24 20:45:49 -05:00
Paul Licameli
e815090139 travis 2016-02-24 20:30:26 -05:00
Paul Licameli
88eeebcb8b Undoing and redoing of Tags... 
Use reference counting (in std::shared_ptr) to avoid replicating Tags with each
Undo state.
 2016-02-24 19:25:39 -05:00
Paul Licameli
e12a060751 Define UndoState 2016-02-24 19:10:40 -05:00
Paul Licameli
a5b6c9fd8f Add some const qualifiers; define TrackListConstIterator 2016-02-24 19:10:39 -05:00
Paul Licameli
ffe9989f7c Don't use an internal iterator in Tags 2016-02-24 19:10:38 -05:00
Paul Licameli
a1c7b396b3 UndoStackElem has proper constructor and destructor; use std::vector 2016-02-24 19:10:36 -05:00
Paul Licameli
cd9bd79d83 Use an enumeration for UndoManager::PushState 2016-02-24 19:10:35 -05:00
Paul Licameli
73ced7b93f Remove UndoManager.h from other headers 2016-02-24 19:10:34 -05:00
Paul Licameli
0c182c3c0b Shrink the command functor objects by using more subclasses... 
... Let virtual function dispatch do the work, don't write our own dispatch!
 2016-02-24 15:17:06 -05:00
Paul Licameli
09b4dfc5a2 travis 2016-02-24 13:52:21 -05:00
Paul Licameli
c98b090182 Rename SyncLockTracksIterator::First to StartWith to be consistent 2016-02-24 12:59:28 -05:00
Paul Licameli
9bf098c7d9 Sweep unnecessary wxString copies: rest 2016-02-23 02:15:56 -05:00
Paul Licameli
6597575f6a Sweep unnecessary wxString copies: blockfile 2016-02-23 01:40:29 -05:00
Paul Licameli
923a6ce4af Sweep unnecessary wxString copies: commands 2016-02-23 01:40:21 -05:00
Paul Licameli
99f161c36c Sweep unnecessary wxString copies: effects 2016-02-22 22:31:47 -05:00
Paul Licameli
83e8a80f61 Sweep unnecessary wxString copies: export 2016-02-22 22:22:25 -05:00
Paul Licameli
d21c0aa478 Sweep unnecessary wxString copies: import 2016-02-22 22:13:50 -05:00
Paul Licameli
0ce4fe0b83 Sweep unnecessary wxString copies: prefs 2016-02-22 21:30:42 -05:00
Paul Licameli
2efa24bc10 Sweep unnecessary wxString copies: widgets 2016-02-22 21:30:04 -05:00
Paul Licameli
4961006f1b Sweep unnecessary wxString copies: xml 2016-02-22 21:26:31 -05:00
Paul Licameli
cf3daebff6 Reviewed allocations of wxMenuBar items. 2016-02-20 20:23:54 -05:00
Gale Andrews
af16636fe2 More accurate label for track name display 
Feel free to tweak, but it was messing up docs to suggest it did not display in Spectrograms,
 2016-02-19 23:52:25 +00:00
Paul Licameli
8e995d66d0 Avoid extra indirection in FormatList 2016-02-19 10:59:51 -05:00
Paul Licameli
00db530c9b Don't eliminate indirection for CommandListEntry. Explain why. Use unique_ptr 2016-02-19 10:49:50 -05:00
Paul Licameli
9e5d31d347 More changes to Audacity.h to hide new and delete from code sweeps... 
... changed some comments, and hid  = delete in a macro.

That is a new C++11 feature that lets you stipulate that a class suppresses an
otherwise inherited or generated name.
 2016-02-19 10:46:23 -05:00
Paul Licameli
d9c2ff6dc2 fix compilation 2016-02-19 01:39:44 -05:00
Paul Licameli
8b7266fe2e fix compilation 2016-02-19 01:37:27 -05:00
Paul Licameli
1758f85451 No extra indirection accessing SnapPoint 2016-02-18 20:19:48 -05:00
Paul Licameli
e0c88b1e53 Remove needless indirection for more little structures, in CommandManager... 
... Also use std::shared_ptr for functors to simplify resource management
 2016-02-18 20:19:27 -05:00
Paul Licameli
1c07741d57 Sizers are owned by wxWindow objects when added, so use safenew, or... 
... use unique_ptr in the interim between building them and adding.

This checks eliminates some naked news, which were not paired with deletes.
 2016-02-18 18:58:38 -05:00
Paul Licameli
c7d3ff7299 Merge branch 'sizers' 2016-02-18 14:51:17 -05:00
Paul Licameli
4d78e353c3 Revert "sizers" 
This reverts commit 84c0a0b6663a1210be502a76ab9c48dd330b3919.
 2016-02-18 14:50:52 -05:00
Paul Licameli
143e3b0ce1 Fix bug in Track > Resample 2016-02-18 08:23:15 -05:00
Paul Licameli
97a69e9ccc A few more safenew 2016-02-18 07:17:26 -05:00
Paul Licameli
84c0a0b666 sizers 2016-02-18 02:54:50 -05:00
Paul Licameli
30f161f5c4 Fix bug when Split New with selection that extends past end of track... 
... but I think there may be some other off-by-one bugs (that existed before my
changes) in treatment of the last sample of a selected range.  Need to
look more closely.
 2016-02-17 21:45:42 -05:00
Paul Licameli
f6e3c26535 XMLFileReader uses std::vector 2016-02-17 18:19:40 -05:00
Paul Licameli
dbaa811577 Stack-allocate where possible! ... 
... Removed many unnecessary naked news and deletes.
 2016-02-17 18:15:57 -05:00
Paul Licameli
55d85f1b25 Remove more uses of at(); use a std::vector of bare pointers, not wx array 2016-02-16 09:35:03 -05:00
Paul Licameli
7988e814bd Define make_unique properly, use in at least one commonly visited place... 
Which is file opening.

So we can be sure it compiles and works on all platforms.
 2016-02-15 14:30:41 -05:00
Steve Daulton
dad346ec23 Fix build for Debian Stable 2016-02-15 15:54:11 +00:00
Paul Licameli
df6a7c5464 More uses of safenew for classes we derive from wxWindow classes... 
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
 2016-02-14 20:39:28 -05:00
Paul Licameli
3f237daddc Use macro safenew for many allocations of wxWindow subclasses 2016-02-14 20:20:19 -05:00
Paul Licameli
6052b5f9be Throw by value, catch by reference: don't use pointers... 
... that's what the better books on C++ recommend.
 2016-02-14 19:36:17 -05:00
Paul Licameli
7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343 "delete"->"DELETE" in comments, easier to find remaining naked operator delete 2016-02-14 18:50:45 -05:00
Paul Licameli
6706b19af8 Define macro safenew and template functions std::make_unique 2016-02-14 13:20:52 -05:00