Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-10 16:43:33 +02:00
Code Issues Releases Wiki Activity

Sweep unnecessary wxString copies: xml

Browse Source
This commit is contained in:
Paul Licameli
2016-02-22 21:15:35 -05:00
parent cf3daebff6
commit 4961006f1b
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/xml/XMLTagHandler.cpp
View File

@@ -62,7 +62,7 @@ bool XMLValueChecker::IsGoodFileName(const wxString & strFileName, const wxStrin
return (fileName.IsOk() && fileName.FileExists());
}
bool XMLValueChecker::IsGoodFileString(wxString str)
bool XMLValueChecker::IsGoodFileString(const wxString &str)
{
return (IsGoodString(str) &&
!str.IsEmpty() &&
@@ -97,7 +97,7 @@ bool XMLValueChecker::IsGoodPathName(const wxString & strPathName)
return XMLValueChecker::IsGoodFileName(fileName.GetFullName(), fileName.GetPath(wxPATH_GET_VOLUME));
}
bool XMLValueChecker::IsGoodPathString(wxString str)
bool XMLValueChecker::IsGoodPathString(const wxString &str)
{
return (IsGoodString(str) &&
!str.IsEmpty() &&

4
src/xml/XMLTagHandler.h
View File

@@ -32,10 +32,10 @@ public:
static bool IsGoodString(const wxString & str);
static bool IsGoodFileName(const wxString & strFileName, const wxString & strDirName = wxEmptyString);
static bool IsGoodFileString(wxString str);
static bool IsGoodFileString(const wxString &str);
static bool IsGoodSubdirName(const wxString & strSubdirName, const wxString & strDirName = wxEmptyString);
static bool IsGoodPathName(const wxString & strPathName);
static bool IsGoodPathString(wxString str);
static bool IsGoodPathString(const wxString &str);
/** @brief Check that the supplied string can be converted to a long (32bit)
* integer.