... note the swap of target_link_libraries lines in src/CMakeLists.txt,
needed to build at least on macOS, becuase FFT.h must be looked up first in
lib-math, not in lib-src/twolame
Also making a dependency cycle of SampleFormat and Dither! But we will tolerate
that within one small library.
... It mentions some wxWidgets types in its interface, but these are in the
acceptable utility subset of wxBase that we still consider GUI toolkit-neutral.
... An elaborate way to hold a wxWindow* as parent of a window, but avoiding
mention of wxWindow* in the member functions of BasicUI::Services, to be defined
next
...so direct uses of wx/app.h may later be removed. That header is one of the
files that is in wxBase, but is not acceptable in "toolkit neutral" code,
which should not directly use any version of an event loop.
... but none of the methods is defined yet.
The intention is to inject dependencies on wxWidgets (or other) toolkit so that
lower-level files have less build dependency on wxCore classes or on the
event loop.
... in particular so that warnings on exit in the debug build on Windows are
suppressed.
Maybe it's not important to suppress them. Or maybe they suggest all is not
correct in the MSVC implementation of this C++17 feature?
... Fixing many conditional operators with explicit construction of wxString
instead of simple string literals;
And fixing allocation of more strictly aligned structures on Mac, without need
for 10.14 as the minimum SDK, by means of some class-specific operators new
and delete.
* Update UnusedStrings.h
Added translatable strings for crash/error reporting and the new spectrogram colour preferences (https://github.com/audacity/audacity/pull/830)
* Update UnusedStrings.h
updated as per guidance from Paul
* Update UnusedStrings.h
Commented out Paul's examples, updated the spectogram settings as per Steve's/Peter's suggestion - Color (Default) and Color (Classic)
* New crash reporter strings; access keys; context strings
* Added "Unknown assertion" and more context strings
* Added comments about shortcut keys
* Choice control items do NOT need & characters, choice label does
Co-authored-by: Paul Licameli <paul.licameli@audacityteam.org>
Adds a small library to generate UUID values. This library will be used in Sentry error reporting
Replace constructor cast with static_cast
Removes a noexcept sneaked in
Adds documentation and some code review fixes
Fixes doxygen