1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-05-01 16:19:43 +02:00

10008 Commits

Author SHA1 Message Date
Paul Licameli
2faa24c96b Move ProjectFSCK out of DirManager...
... which makes DirManager.cpp not depend on MissingAliasFileDialog.cpp
2019-05-18 15:06:50 -04:00
Paul Licameli
e5c7e5a21f Three new files in the build, still empty 2019-05-18 14:57:24 -04:00
Paul Licameli
f4703bbd1f ViewInfo doesn't need Project.h 2019-05-18 14:57:24 -04:00
Paul Licameli
597cdb7428 AudacityApp.cpp and some others freed from cyclic link dependencies 2019-05-17 16:30:05 -04:00
Paul Licameli
6e3ebc0938 ScriptCommandRelay.cpp is not link dependent on AudacityApp.cpp ...
... Let it send an event to the application instead of calling the handler
directly.
2019-05-17 16:29:41 -04:00
Paul Licameli
b04387a21d Move AudacityApp::GenerateCrashReport to its own files 2019-05-17 16:29:31 -04:00
Paul Licameli
8da6529329 Remove AudacityApp::GetLogger() & HelpActions::DoShowLog() 2019-05-17 16:29:04 -04:00
Paul Licameli
e845bd9544 Move AudacityApp::MacActivateApp out of WindowMenus.cpp 2019-05-17 16:29:04 -04:00
Paul Licameli
e4a8d6c3fc Don't call AudacityApp::OnMenuAbout directly from HelpMenus.cpp 2019-05-17 16:29:04 -04:00
Paul Licameli
6cde697a8e Don't call QuitAudacity directly from src/menus...
... This cuts link dependency on AudacityApp.cpp, and allows the function to
be private to that file
2019-05-17 16:29:04 -04:00
Paul Licameli
187e3be0d6 Move SaveWindowSize to Project.cpp & it no longer needs AudacityApp.h 2019-05-17 16:29:04 -04:00
Paul Licameli
d4b0fd1b83 AudacityProject.cpp does not need gIsQuitting from AudacityApp.h 2019-05-17 16:29:04 -04:00
Paul Licameli
4a4f8ebe4e Move language setting and event from AudacityApp.h to GUIPrefs.h 2019-05-17 16:29:04 -04:00
Paul Licameli
236c8ed51e Move version keys from AudacityApp to AudacityPrefs 2019-05-17 16:29:04 -04:00
Paul Licameli
a1ff74b5bb Move AudacityPathList & utilities from AudacityApp.h to FileNames.h 2019-05-17 16:29:03 -04:00
Paul Licameli
757d90d3b9 Move default temporary directory from AudacityApp.h to FileNames 2019-05-17 16:29:03 -04:00
Paul Licameli
a047fa6e7a Missing alias file tracking out of AudacityApp, into new files...
... which reduces the need for including AudacityApp.h
2019-05-17 16:28:50 -04:00
Paul Licameli
0ab29d21e9 Some naming consistency...
Prefer "MissingAliasFiles" not other permutations of the words
2019-05-17 06:47:53 -04:00
Paul Licameli
2d8c287384 Do not require AudacityApp.h when using global file history 2019-05-17 06:47:53 -04:00
Paul Licameli
d4f71c2c64 Move an event type definition out of AudacityApp.h 2019-05-17 06:47:53 -04:00
Paul Licameli
338d7cd164 A class encapsulating the global clipboard 2019-05-17 06:47:53 -04:00
David Bailes
ca13f08ff8 Grid accessibility: incorrect focus can be read
Problem: this affects NVDA and Narrator, but not Jaws. If a user moves to the Delete button and presses it to delete a label, a label is incorrectly read as the new focus - the focus remains on the Delete button.
GridAx::SetCurrentCell() can be called when the Grid is not the focus, and send a focus event.

Fix: In GridAx::SetCurrentCell() only send an focus event if the Grid is the focus.
2019-05-17 11:06:49 +01:00
David Bailes
be55d891db Trackpanel accessibility: incorrect focus can be read
Problem: If the initial focus is a control in a toolbar, then after applying an effect such as amplify, then the focus is read as being a track, not the control in the toolbar.
TrackPanelAx::SetFocus() can be called when the TrackPanel is not the focus, and send a focus event.

Fix: In TrackPanelAx::SetFocus(), only send a focus event if the TrackPanel is the focus.
2019-05-17 09:56:01 +01:00
David Bailes
6da84b0adc Keyboard prefs accessibility: Narrator can misread the radio buttons.
Problem. If an item in the list is selected, then if a different view by radio button is selected, Narrator reads the selected item rather than the radio button.
KeyViewAx::SetCurrentLine(int line) can be called when the KeyView is not the focus, and send a focus event.

Fix: In KeyViewAx::SetCurrentLine(int line), only send focus event if the KeyView is the focus.
2019-05-17 08:33:33 +01:00
Paul Licameli
ddaadfb7e7 Remove NumericTextCtrl.h from other headers or comment why you can't 2019-05-16 19:01:00 -04:00
Paul Licameli
ced9be588b Remove ImageRoll.h from other headers or comment why you can't 2019-05-16 18:30:22 -04:00
Paul Licameli
6c57948d8f Remove unnecessary #include-s from .cpp files...
... Unnecessary because transitively included.

But each .cpp file still includes its own .h file near the top to ensure
that it compiles indenendently, even if it is reincluded transitively later.
2019-05-16 17:21:00 -04:00
Paul Licameli
548192fcf3 Remove redundant #include-s from .h files...
Redundant, because transitively implied.  But don't do this for inclusions of
Audacity.h or Experimental.h.
2019-05-16 14:58:34 -04:00
Paul Licameli
56f51d8176 Revert "Remove redundant #include-s from .h files..."
This reverts commit b7fe62d17067b4441530dd36b25052cea3ad44b5.
2019-05-16 14:33:55 -04:00
Paul Licameli
b7fe62d170 Remove redundant #include-s from .h files...
Redundant, because transitively implied.  But don't do this for inclusions of
Audacity.h or Experimental.h.
2019-05-16 14:15:05 -04:00
Paul Licameli
31a80fb4d1 Fix Windows build 2019-05-16 13:44:48 -04:00
Paul Licameli
a7469ad674 Some progress using wrappers of wxString to make type distinctions 2019-05-16 12:30:30 -04:00
Paul Licameli
9bf29f5582 CommandManager keys by CommandId, not plain wxString 2019-05-16 12:30:29 -04:00
Paul Licameli
19bf094893 Change CommandManager terminology: "Numeric id" not just "Id" ...
... because I will use CommandId for string identifiers instead, and those
are the really persistent identification
2019-05-16 12:30:29 -04:00
Paul Licameli
11c8377460 NormalizedKeyString redefined as TaggedIdentifier 2019-05-16 12:30:29 -04:00
Paul Licameli
172c8abe03 Miscellaneous changes 2019-05-16 12:30:28 -04:00
Paul Licameli
3eeb91f23a Define class Identifier and template TaggedIdentifier...
... Identifier holds strings used for internal purposes and not shown to users;
TaggedIdentifier generates subclasses of Identifier for different purposes,
which won't implicitly (that is, inadvertently) interconvert as function
arguments.
2019-05-16 12:30:28 -04:00
Paul Licameli
c09edbb18a Define and use const version of WaveTrack::GetAllClips 2019-05-16 12:30:27 -04:00
Paul Licameli
3e5bfa0c12 Make sure HistoryWindow does space usage update if hidden then shown again 2019-05-16 12:30:27 -04:00
Paul Licameli
7ad6897598 Move class ShuttleGuiGetDefinition near its only point of use 2019-05-16 12:30:27 -04:00
Paul Licameli
5be54c5612 ModuleManager::CreateProviderInstance returns more specific type 2019-05-16 12:30:26 -04:00
Paul Licameli
961882838f Move definition of std::hash< wxString > 2019-05-16 12:30:26 -04:00
Paul Licameli
74128156bf ModuleInterface::GetFileExtensions() returns const reference...
... avoiding repeated array allocation
2019-05-16 12:30:23 -04:00
Paul Licameli
bf005c0dec PrefsPanel::Factory is a specialization of std::function...
... We don't need to define a class for it
2019-05-16 12:14:51 -04:00
Paul Licameli
8117ca8823 Remove an unnecessary #include directive 2019-05-16 11:44:42 -04:00
Paul Licameli
d90a827e03 Remove unneeded #include-s of AudacityApp.h 2019-05-15 15:58:00 -04:00
Paul Licameli
f6adeed47b Remove some unnecessary #include directives 2019-05-15 14:14:18 -04:00
Paul Licameli
eeb290aeb6 New script graph.pl to analyze dependencies...
... To use it, first install graphViz.  Then change to the scripts directory
and run ./graph.pl .  Then view the resulting image file in a browser.

See an acyclic graph, each node labeled with the list of .cpp files in
one strongly connected component of the linkage dependencies as determined
by scanning the #include directives in the sources.

It worked for me in macOS.
2019-05-15 14:06:06 -04:00
James Crook
88dc11f525 Fix 'Set Track Name' input box too short.
This was a regression relative to Audacity 2.0.3
2019-05-15 13:38:16 +01:00
James Crook
30dda4fe97 Update Version number for 2.3.3 development. 2019-05-13 18:09:58 +01:00