1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-08-07 07:39:29 +02:00

143 Commits

Author SHA1 Message Date
James Crook
3ffcc29bf6 Add code to capture command List
Capture the commands and key bindings to debug channel:
a) From the menus
b) from the preferences.
2017-03-23 18:42:54 +00:00
Paul Licameli
abbe9276f0 Exception safety in: CommandManager 2017-03-21 14:11:21 -04:00
James Crook
c6b4e2fffe Add code to capture menus
So far, this only walks the menus, printing out their contents to debug.
2017-03-20 17:06:29 +00:00
James Crook
8f71aa67df Allow same command more than once in the menus.
Pause appears in both Record and Play, and we want the P shortcut to work.
2017-03-19 19:32:35 +00:00
Paul Licameli
b81cdee7e3 Comment where xml writing functions may throw 2017-03-18 11:45:05 -04:00
Paul Licameli
a8a2598ba3 Intercept exceptions in command script, report failure. 2017-03-17 17:53:02 -04:00
Paul Licameli
6525bb18cf Translate exceptions to error codes in callback functions...
... That is what the library protocols allow, and libraries may be written
in C and might corrupt their state if C++ exceptions pass through them.
2017-03-17 17:53:01 -04:00
Paul Licameli
e6db1a57a3 Remove naked new[] in: blockfile and commands 2017-03-17 17:52:46 -04:00
Paul Licameli
5036583549 Fewer inclusions of AudacityApp.h 2017-03-17 17:52:24 -04:00
Paul Licameli
81285ee0c1 More const and override 2017-03-17 17:52:20 -04:00
Gale Andrews
ed503c35e5 Address issue posted on Wiki Wording page 2016-10-27 06:23:05 +01:00
Paul Licameli
09a3854256 Use unique_ptr more properly in the fix for building mod-nyq-bench 2016-10-02 09:46:48 -04:00
Leland Lucius
2ab0c13101 Fix build of Nyquist Workbench 2016-10-01 14:05:53 -05:00
Paul Licameli
78be459fa1 Convert sampleCount <-> floating or -> long long explicitly ...
... A non-narrowing conversion out to long long is a necessity, but the
conversions to float and double are simply conveniences.

Conversion from floating is explicit, to avoid unintended consequences with
arithmetic operators, when later sampleCount ceases to be an alias for an
integral type.

Some conversions are not made explicit, where I expect to change the type of
the variable later to have mere size_t width.
2016-09-15 21:02:31 -04:00
Paul Licameli
d783762737 Remove unnecessary std::move in return statements...
... and comment where it is necessary.
2016-09-15 07:39:46 -04:00
Paul Licameli
39d514b183 Some more const, some stl idioms, remove unused declaration 2016-09-13 22:03:58 -04:00
James Crook
65c7e8051a ThomasFeher - Unused parameters clean up. 2016-09-11 20:31:49 +01:00
Paul Licameli
67cec5ad83 Make many counts of tracks and channels unsigned...
... And in some places where a library uses signed types, assert that
the reported number is not negative.

What led me to this, is that there are many places where a size_t value for
an allocation is the product of a number of channels and some other number.
2016-09-07 10:11:41 -04:00
Paul Licameli
8e42f8a61a Fix progress indicator again: must do a floating-point division...
... or else just get zero!
2016-08-26 12:42:22 -04:00
Paul Licameli
fd2b050d6f Type agnosticism for some other variables that were not sampleCount...
... in some cases, this fixes narrowings.
2016-08-24 14:50:45 -04:00
Paul Licameli
b5e410d987 Fix Windows build differently 2016-08-24 12:13:53 -04:00
James Crook
781de82d02 Workaround build breakers. Needs review.
These changes fix a broken build in Windows.
#include <algorithm> needed for min/max to be in std.
decltype(+name) was declaring a const variable, that could not be incremented.  Changed to auto.
2016-08-23 21:46:12 +01:00
Paul Licameli
1281f1b14b Common function limits buffer size to sampleCount known to be small 2016-08-23 12:46:10 -04:00
Paul Licameli
2969336258 Fix bug in update of progress in CompareAudioCommand 2016-08-21 09:52:10 -04:00
Paul Licameli
41efaeeef0 Fix Windows build 2016-08-14 09:35:04 -04:00
Paul Licameli
b6241c46d3 Remove a few more naked new in CommandManager.cpp 2016-08-13 10:37:52 -04:00
Paul Licameli
57afa1399e Remove some naked new amd delete in: commands 2016-08-08 07:53:29 -04:00
Paul Licameli
c3e53ea26e Remove some naked new amd delete in: overrides of CommandType::BuildSignature 2016-08-08 07:53:29 -04:00
Paul Licameli
81228eac0e Improve the fix for the Ctrl+F6 cycle 2016-06-30 11:00:56 -04:00
Paul Licameli
e9cf0a8335 Bug1252: Ctrl-f6 cycle works on Mac even when combo has focus 2016-06-23 10:35:45 -04:00
James Crook
6bc7924b16 Bug 1378 - Screenshot Tools images are mostly white background only.
Use 24 bit bitmap rather than default which is 32 bit.  Seems to be a wxWidgets 3.0.2 bug with ScreenDC.
2016-06-23 11:33:58 +01:00
Paul Licameli
8dfaa4dcf8 Implement translation of shortcut key names to Mac special chars 2016-06-11 20:31:03 -04:00
Paul Licameli
f5c4c85653 New scrubbing toolbar; remove ruler pushbuttons. 2016-06-05 01:03:24 -04:00
Paul Licameli
0d9d8a057d Revert "Disable scrubbing when pause button is down."
This reverts commit 97fdce5f85e884cbe6f161963789694015cdf328.
2016-05-06 11:32:56 -04:00
Paul Licameli
97fdce5f85 Disable scrubbing when pause button is down. 2016-05-05 22:48:23 -04:00
Paul Licameli
014d5ab93c Type safety in the use of command flags, and make enum wide, allowing more bits 2016-05-05 20:02:13 -04:00
Paul Licameli
3d222bcd87 Context menu for scrubbing in the ruler 2016-04-26 12:12:06 -04:00
Paul Licameli
bc80ffe766 Windows build fixes 2016-04-24 01:12:42 -04:00
Paul Licameli
367b2c1011 Move command functors to a new header file, and generalize with templates...
... so that member functions of other than AudacityProject may be called.

Will use this new generality soon for scrubbing menu items.
2016-04-23 02:05:36 -04:00
Paul Licameli
ce95bce85a Bug991: Pause button and command should be disabled during scrubbing...
... and they will be as soon as ctrl-mouse down.
2016-04-18 21:49:27 -04:00
Paul Licameli
185d5e132d Avoid some wxString copies 2016-04-17 13:58:21 -04:00
Paul Licameli
f9da767cbd Remove a friend declaration from Project, privatize a pointer member...
... and make implementation of that pointer a smart one.
2016-04-11 14:42:57 -04:00
Paul Licameli
70bd46b8ad travis 2016-04-09 22:55:15 -04:00
Paul Licameli
fd8fa69c62 Singleton CommandDirectory used to leak! 2016-04-06 16:06:32 -04:00
Paul Licameli
3481e678ea Manage the members of CommandOutputTarget with smart pointers 2016-04-06 16:06:12 -04:00
Paul Licameli
e8ad90b3c9 Manage Commands and CommandOutputTarget objects with smart pointers 2016-04-06 16:05:28 -04:00
Paul Licameli
f4441d7476 Command validator cloners return smart pointers, and...
... defined DefaultValidator so Validator can be abstract, as the comment for
Clone() stongly implies it should be.

But this is virtual is unused except in comments.
2016-04-06 16:05:21 -04:00
Paul Licameli
83e9e7de97 Clone functions required by wxWidgets base classes can use safenew 2016-04-06 14:08:43 -04:00
Paul Licameli
de75a00c10 Define movable_ptr and make_movable, use __AUDACITY_OLD_STD__ in fewer places 2016-03-25 20:27:25 -04:00
Leland Lucius
9dc9348127 Fixes bug #1344 (mac build)
In addition, the Xcode project can now build against the 10.6
or 10.7 SDKs.  All that is needed is to change the SDK version
and the other settings will change automatically.
2016-03-07 00:29:26 -06:00