The short-circuit evaluation of flags ONLY generated the NotMinimized flag, and all others were set to zero, when short-circuit evaluation happened. This change remembers and preserves the other flags, so they don't get set to zero.
Previously this could/would fail to create a temporary directory if the earlier
components in the path did not exist. The user would then be prompted
unnecessarily for a location to store temporary files.
Also now disallow blank as a temporary directory name.
Also no longer search entire dmg for plug ins. Just search the app itself.
I have done as suggested in the bug comments, and used:
Windows: Users\username\Documents
Unix/Mac: ~/Documents .
We could though use GetLocalizedResourcesDir() and could use Music rather than Documents.
Opening Audacity can give a project window that straddles screens (if that is what the user wants and had last time they closed).
New windows created from menu item new will still start out initially all on one screen.
Works by un-full-screening before closing. Patching wxWidgets was needed to
make that work correctly after full-screening by clicking on the green circle
in the title bar, but that fix is not needed for full screen after command+/
... To short selections (under 1/100 second), at the start of the second of
two separated clips, in a project with a high sampling rate of 192000.
Symptom was that the audio moved so it was pasted to the end of the first clip.
Other uses of the constant WAVETRACK_MERGE_POINT_TOLERANCE should be
reviewed too but this is a conservative fix made close to release time.
... Partial reversion of commit 2e8ee5fe75789d60869b19fe1986c8d47cf0b995
Now, if you open an effect dialog, Return key will apply it. But, if you
cycle among windows with alt+f6, then the focus moves among the controls in
the effect dialog, and I don't know how to prevent that.
At least so it is in Mac. I have not verified it with Linux.
Problem was that when these commands were used when playback was stopped, the tracks did not automatically scroll to make sure that the label that had been moved to was visible.
Fix: call TrackPanel::ScrollIntoView().