The problem was that the end time was set to prohibit changes that brought it
before the start time. However an update to start time could update the end time
before the end time updated its legal range.
The prohibition on going backwards in time is only for user interaction with
that control, so we now clear the legal range before update and then recreate it.
This change also fixes:
Bug 1978 - Windows: Timer Record - a "debugging check" dialog is shown to the user
In passing I also noticed that the controls were being updated every 50ms.
This is totally pointless as they only show the nearest second. So I set the granularity
for control updates to 1s. (1000ms).
... A double-height bar can now insert left of two stacked single-height bars.
For instance you can un-dock the Tools toolbar from the default setup, then
drag it back, and now get the same result as you started with.
... Use correct symbolic constants in three places (no effect);
use proper theme color for the two pixels per track that are left of and
above the shadow (small effect when not Classic theme)
This revised fix:
- No longer attempts to drive "Default sample rate" from the selection toolbar.
- No longer drives 'Project rate' direct from prefs. It's usual it comes from the project.
- Instead 'Project rate' in the project might change if 'Default sample rate' pref is updated, but ONLY if the project has no tracks.
- When 'Project rate' in the project is updated, that is now always signaled to the selection toolbar. Previously it wasn't.
This change is inspired by the plan to eliminate GetLinked() in 2.3.1. Logically we shouldn't be exposing a boolean 'linked' in scripting, but instead a channel count.
The Project Rate in the Selection Toolbar and in the Preferences dialog are now the same thing. They ALMOST were before, causing confusion, and this bug.
This means that the fancy mechanism to set 'other' rates in Preferences is moot, since the Selection Toolbar bar does not have that option. 49000 will be overridden by 48000 for example.
This is not a proper fix, as we do not fully understand the problem - which is in release builds only.
It may be enough though to get us through to release.
