1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-14 15:48:21 +02:00

133 Commits

Author SHA1 Message Date
Paul Licameli
60bcd7aea2 Fix warnings for unused variables and functions 2016-02-26 14:56:26 -05:00
Paul Licameli
dbaa811577 Stack-allocate where possible! ...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Paul Licameli
ad586b3e69 Bug36, partial: Redraw mixer board when meter range preference changes 2016-01-21 10:22:24 -05:00
Leland Lucius
48c5c47214 Fix for bug #1219 2015-10-05 23:43:00 +01:00
Leland Lucius
2f9c7d1567 Fix for bug #1190 2015-09-16 13:04:26 -05:00
Paul Licameli
1278b9644a Uniform naming of symbols in Experimental.h 2015-08-31 17:55:56 -04:00
Leland Lucius
6a9dae20f5 Appearance on OSX is now back to normal or better
Some additional wx3 cleanup as well.
2015-08-23 20:25:01 -05:00
Paul Licameli
e0621819ed Move ENV_DB_RANGE out of Envelope.h; that file can be included in fewer places. 2015-07-28 11:55:52 -04:00
Paul Licameli
cab89f6fb4 Remove Envelope.h from other headers 2015-07-28 10:02:09 -04:00
Steve Daulton
df8ddde874 Added dB - linear amplitude conversion macros. 2015-07-24 21:59:34 +01:00
Paul Licameli
e70f91c64e Removed ShuttleGui.h from other headers 2015-07-19 12:31:03 -04:00
David Bailes
d5ea9a678e Fix for translations of strings for screen readers in MeterAx::GetName. The translations of strings which had a leading space did not always preserve this leading space, resulting in merged words. Therefore separate spaces were added, and the original strings left unchanged so that no new translation work is required. 2015-06-10 14:09:56 +01:00
David Bailes
cc9ac9804f Meters: fix indication of clipping for screen readers. 2015-06-10 13:56:47 +01:00
David Bailes
f458df1c7b Changes to a number of dialogs so that the NVDA screen reader can read the titles. Missed these in my last patch. The accessibility name of the dialog is set to the title. 2015-05-18 13:57:05 +01:00
Leland Lucius
8fbfa460c4 Migrating the remaining effects
This brings the builtin, LV2, and VAMP effects inline with the
Audio Units, LADSPA, and VST effects.  All effects now share
a common UI.

This gives all effects (though not implemented for all):

User and factory preset capability
Preset import/export capability
Shared or private configuration options

Builtin effects can now be migrated to RTP, depending on algorithm.
LV2 effects now support graphical interfaces if the plugin supplies one.
Nyquist prompt enhanced to provide some features of the Nyquist Workbench.

It may not look like it, but this was a LOT of work, so trust me, there
WILL be problems and everything effect related should be suspect.  Keep
a sharp eye (or two) open.
2015-04-16 23:36:28 -05:00
Leland Lucius
21c2e5f994 Meter refresh rate not updated when leaving preferences. 2015-04-08 03:03:44 -05:00
lllucius
3d420e019c Applied accessibility patch from David that I missed.
From David's message:

   "solution to the problem of getting jaws to read the updated
   name after choosing start/stop monitoring on the menu"
2015-01-19 17:47:39 +00:00
lllucius
dbe7e0280c Well r13875 was pretty dumb...try again 2015-01-10 20:41:49 +00:00
lllucius
e33cf84e35 Reduce accessibility chattiness in meters 2015-01-10 20:33:57 +00:00
lllucius
d87c6942cd A couple more accessibility changes 2015-01-09 16:07:24 +00:00
lllucius
a6ace4a606 Ignore the key up events after showing the context menu (on Windows only) 2015-01-09 15:27:58 +00:00
lllucius
5e46430d80 Update keyboard and a11y usage based on DB's suggestions 2015-01-05 16:36:17 +00:00
lllucius
4e8b794452 Fix a conflict between the backported number validator and formatter
When building for wx3 on Linux, the backported number validators
and formatter conflicts with the wx3 version because I never
renamed them.  Crashes during termination would occur because
the wx3 version and our version had different vtables.

I was thinking that we would just be able to delete the
backported version when upgrading to wx3, but since
we've made Audacity specific changes to them we can't
simply start using the real wx3 versions anymore.

Therefore, I needed to rename then to prevent the crashes.
2015-01-04 21:17:16 +00:00
lllucius
8bef14df36 Addresses meter accessibility mentioned in bug #33
And also corrects the missing focus rectangle display on
the toolbar buttons on Linux.
2015-01-04 09:24:26 +00:00
lllucius@gmail.com
3a23757e2e All the menu to be opened from the keyboard on the Mac as well. 2015-01-04 02:25:56 +00:00
lllucius@gmail.com
e33723d0e4 Figures Linux uses a differnet keycode for the context menu 2015-01-04 01:05:23 +00:00
lllucius
c9cde48f21 Open popup menu under icon when using context menu key 2015-01-03 09:29:42 +00:00
lllucius@gmail.com
c3c458e3fa Compact meters under GTK have same antialiasing issue as OSX 2015-01-03 07:00:39 +00:00
lllucius
bec5866653 Persist meter state across toolbar resets and fix clipping indicator
This will fix the clipping indicator turning on after a toolbar reset
and, as a bonus, the timers now only run if playing, capturing, or
monitoring.  Will (slightly) reduce the CPU consumption.
2015-01-01 23:29:08 +00:00
lllucius
055b40c3f2 Fix wx3 build 2014-12-29 03:46:57 +00:00
lllucius
a30f8398aa Let's try narrower icons...
...to see if it removes enough "gray" space on the left
of the vertical meter to be bareable.
2014-12-28 23:48:01 +00:00
lllucius
e47bb71b08 Re-adds the ability to reset peaks while recording
It also disables the "start/stop monitoring" menu item 
while recording.  Not really necessary, but...
2014-12-28 21:06:58 +00:00
lllucius
4126acac6b Fixes missing recent peak value
And re-introduces double buffering on Windows.
2014-12-28 20:49:37 +00:00
lllucius
97251986ed Set preferences dialog title based on meter type 2014-12-28 06:25:16 +00:00
lllucius
a3786dd78a Both input meters should track monitoring/capture status
So you can switch between the combined and independent 
recording meters at will.
2014-12-28 06:15:09 +00:00
lllucius
6a3ef5565c Independent meters with combined menu/icon
Many other changes including:

1)  Independent preferences
2)  Automatic layout separated from vertical/horizontal orientation choices 
3)  Combined menu and icon which saves space
4)  Click to start monitoring label no longer covers peak hold line completely
5)  Click to start monitoring label now adjusts label based on available width
6)  Click to start monitoring label now appears on vertical meter (not sure about this one...)
7)  Reduced width of vertical meter by moving icon to left of meters
8)  Includes a compact vertical meter now
9)  Clipping indicator is easier to see
10) All 1-off drawing issues resolved (99.9% sure...I challenge you to find some ;-))
11) Bevels around meters are no longer overlaid by meter updates
12) "Old" menu handling code removed
13) Though not perfect since some non-English characters are taller/wider than the meters, non-English text is now handled better
14) Clicking play meter resets indicators as appropriate
15) Indicators on meters now stick around until the meter is clicked
16) Ugly flashing while resizing is now gone
17) There should be NO magic numbers in the code.  Every +1 or -2 is explained in comments...
18) Size of L/R labels are recalculated now when preferences are updated (to pull in locale changes)
2014-12-28 03:18:00 +00:00
lllucius@gmail.com
f00932a7ff Fix vertical meter not working on Mac...broken by r13802 2014-12-24 02:31:21 +00:00
lllucius@gmail.com
b942e8085f Fix display corruption on Mac when using compact meter 2014-12-22 21:16:51 +00:00
james.k.crook@gmail.com
cf1a7a849a Fixed problem where clicking on recording meter menu drop-down could also toggle monitoring on/off state.
The code was using Evt.LeftIsDown() so movement (with the mouse down) could toggle state.  Changed to only respond on the down event, i.e. Evt.LeftDown().
2014-12-22 15:10:14 +00:00
lllucius@gmail.com
e2bced3a0a Start metering on left click...ignoring double click time 2014-12-20 20:03:04 +00:00
lllucius
9bbc261321 Attempt #2 at taming the meter toolbars
It corrects several "multiple project" problems with the
meter toolbars and meters.

In addition, there was a "multiple project" issue where
the transport buttons didn't disable properly in the
non-active project.
2014-12-19 16:38:56 +00:00
lllucius
d978d99fde Part 2 of fix from r13782 and monitoring fix
This fixes the monitoring fix Bill described here:

http://audacity.238276.n2.nabble.com/First-go-at-the-meter-toolbars-committed-tp7566196p7566209.html
2014-12-18 08:00:18 +00:00
lllucius
02539ea792 Missed one in the last commit... 2014-12-17 19:22:23 +00:00
lllucius
fe42e881a5 First stab at taming the meter toolbars
This should correct at least a couple of the reported
issues.  And it also has some fixes in for multiple
project support.
2014-12-17 19:16:08 +00:00
lllucius
e752848d5e Fixes meter orientation problems as described here:
http://audacity.238276.n2.nabble.com/Problems-with-recording-meter-when-changing-vertical-horizontal-orientation-tt7565895.html
2014-12-11 08:51:18 +00:00
james.k.crook@gmail.com
94c243cb2e No disabled state for meters. Monitoring can be on or off. Input meter now has prompt when monitoring off.
I haven't got rid of the preferences for disabled/enabled.
2014-11-29 21:10:44 +00:00
james.k.crook@gmail.com
bce372bfee Tooltip on recording meter toolbar now changes with meter on/off 2014-11-13 16:29:08 +00:00
stevethefiddle@gmail.com
c061d3cf4f Fix corruption of menu arrow on single height rms meter. 2014-11-10 14:52:54 +00:00
james.k.crook@gmail.com
a09d3717fa Added experimental LED style for meters. 2014-11-09 17:54:49 +00:00