Benjamin Drung
a20d7898f3
Fix redeclaration of isinf()
...
Commit 9e78a41 declared isinf() as std::isinf(), because isinf() was not
declared on Ubuntu 16.04. But now the builds fail on Ubuntu <= 15.10,
because isinf() is declared there:
effects/Contrast.cpp:61:12: error: ‘constexpr bool std::isinf(double)’ conflicts with a previous declaration
using std::isinf;
^
In file included from /usr/include/features.h:364:0,
from /usr/include/assert.h:35,
from /usr/include/wx-3.0/wx/debug.h:14,
from /usr/include/wx-3.0/wx/defs.h:695,
from /usr/include/wx-3.0/wx/event.h:14,
from /usr/include/wx-3.0/wx/window.h:18,
from /usr/include/wx-3.0/wx/nonownedwnd.h:14,
from /usr/include/wx-3.0/wx/toplevel.h:20,
from /usr/include/wx-3.0/wx/dialog.h:14,
from effects/Contrast.h:12,
from effects/Contrast.cpp:13:
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:201:1: note: previous declaration ‘int isinf(double)’
__MATHDECL_1 (int,isinf,, (_Mdouble_ __value)) __attribute__ ((__const__));
Thus use std::isinf() directly instead of declaring isinf() as
std::isinf().
2016-05-16 13:33:22 +02:00
Benjamin Drung
9e78a41faf
Use std::isinf() instead of isinf()
...
Audacity fails to build on Ubuntu 16.04 with g++ 5.3.1 (using C++11),
because isinf() is not defined. Thus use std::isinf() instead.
2016-05-15 09:04:35 +02:00
Benjamin Drung
13630dc91d
Use portable wxIsNaN() instead of isnan()
...
isnan() is not defined when compiling with g++ 5.3.1 on Ubuntu 16.04. It
is called std::isnan() in C++11 instead. Therefore use wxIsNaN() instead
which already defines the correct name.
2016-05-14 00:05:22 +02:00
Steve Daulton
15fe07638e
Fix bug 1316
...
Improve effect descriptions for tone and chirp generator.
2016-05-09 09:20:06 +01:00
Paul Licameli
db137ddf76
wxWindow takes ownership of its wxAccessible, so we can use safenew.
2016-05-06 21:03:37 -04:00
Paul Licameli
014d5ab93c
Type safety in the use of command flags, and make enum wide, allowing more bits
2016-05-05 20:02:13 -04:00
Gale Andrews
df3003fe62
Use same term as used in the Manual.
2016-04-29 16:09:18 +01:00
Paul Licameli
1bdd1a07ab
Similarly for Equalization: avoid assertion in debug build, if you ESC...
...
... while dragging a point in "Draw Curves".
2016-04-25 01:04:38 -04:00
Paul Licameli
08eb840f32
You could get an assertion, on Mac debug build at least, ...
...
if you hit ESC during drag in the Autoduck dialog. This fixes that.
2016-04-24 23:56:15 -04:00
Paul Licameli
f2c6fbfc1b
Bug1318 fixed again so that generators and effects on Windows still work
2016-04-24 10:32:20 -04:00
Paul Licameli
879ecefdaa
Bug1318: ESC key or red close button should not leave the app unresponsive...
...
... I don't fully understand why this fixes it, but I could figure out what
was different between ESC and Cancel button which did not have the problem.
2016-04-23 08:49:11 -04:00
Paul Licameli
d5915491b3
Bug1342: Loop-play (and other things) before scrub (and other things)...
...
... should not disable auto-scrolling of the window during playback.
2016-04-18 17:50:17 -04:00
Paul Licameli
2d7e21536e
Sweep for filename copying: prefs and effects
2016-04-10 22:25:49 -04:00
Paul Licameli
59af732763
Mac build fixes; and implement deleters for our imitation unique_ptr
2016-04-10 14:15:51 -04:00
Paul Licameli
2696da89cb
One more use of smart pointer object SampleBuffer, in Nyquist.h...
...
...Leaving no "naked" DeleteSamples. Only SampleBuffer::Free now calls it
directly, and SampleBuffer calls Free in its destructor.
2016-04-10 00:07:21 -04:00
Paul Licameli
9f3e4213ec
Partial compilation fixes for EXPERIMENTAL_EQ_SSE_THREADED plus __AVX_ENABLED
2016-04-07 14:37:08 -04:00
Gale Andrews
7f3edc2523
Bug 1312 Further consistency fix for description
...
Don't start description with an object, per consistency with Manual.
2016-04-07 03:40:47 +01:00
Gale Andrews
b7aabee96a
Bug 1317 Further consistency fix for description
...
Don't start description with an object, per consistency with Manual.
2016-04-07 03:35:01 +01:00
Paul Licameli
e0476b5e71
Module interfaces managed by smart pointers
2016-04-06 16:06:30 -04:00
Paul Licameli
54402bf00d
Effects managed with smart pointers
2016-04-06 16:06:29 -04:00
Paul Licameli
a9afad17ca
Plugin instances managed without naked new and delete
2016-04-06 16:06:27 -04:00
Paul Licameli
df45886d6b
Bug1340: sync-lock should work when generating audio
2016-04-05 17:06:24 -04:00
Paul Licameli
f0cbda835e
Bug1257: Crash when enabling VST effect Amplio2...
...
... Suspected a threading bug in the library itself, which Audacity can
compensate with a short delay: see code comments.
The other part of the complaint in 1257 -- that the play button would crash --
was a separate problem, fixed previously for bug 1242.
2016-04-05 15:09:07 -04:00
Paul Licameli
3ced1503ee
Make EXPERIMENTAL_EQ_SSE_THREADED compilable, at least on Windows.
2016-04-03 11:37:18 -04:00
Paul Licameli
2e5d24ab02
Make EXPERIMENTAL_EFFECTS_RACK compilable
2016-04-03 09:42:16 -04:00
Paul Licameli
8ae361d415
Fix some of the compilation breakage in EXPERIMENTAL_SCOREALIGN...
...
... But some of the header files and functions just don't exist any more.
2016-04-02 15:46:56 -04:00
Paul Licameli
8e447493eb
Make old Noise Removal effect compilable again
2016-04-02 13:04:53 -04:00
Paul Licameli
b279325d76
Mac build
2016-04-01 14:46:40 -04:00
Paul Licameli
13595620cf
Fix mac build
2016-03-30 23:24:39 -04:00
Paul Licameli
a6ca36cdab
TrackList holds smart pointers to tracks, Add() only takes rvalue refs to such
2016-03-26 15:41:31 -04:00
Paul Licameli
c5a70126eb
TrackList always deletes tracks on destruction or when cleared
2016-03-26 15:41:29 -04:00
Paul Licameli
bc5519a0e2
TrackList::Remove and TrackListIterator::RemoveCurrent always delete the track
2016-03-26 15:41:26 -04:00
Paul Licameli
4edc960acd
Redo Effect::ReplaceProcessedTracks without RemoveCurrent
2016-03-26 15:41:25 -04:00
Paul Licameli
c4fc7e2bf0
MixAndRender returns unique_ptr results (in a std::pair)
2016-03-26 11:50:14 -04:00
Paul Licameli
3015a9c8d9
Track cut and copy functions return a unique_ptr argument...
...
... Because they are factory functions.
2016-03-26 11:50:13 -04:00
Paul Licameli
5ef4dd46a5
TrackFactory functions return std::unique_ptr, although some callers...
...
... release() them for now.
2016-03-26 11:50:12 -04:00
Paul Licameli
f42a953752
Track duplication methods return unique_ptr, although some callers...
...
... simply release() them for now.
2016-03-26 11:50:10 -04:00
Steve Daulton
85bd752de7
Fix for bug 1364
2016-03-24 15:49:46 +00:00
Steve Daulton
ff6a82ae8c
Goodbye to magic number in Contrast.cpp
...
Also added several TODO and FIXME comments for ongoing fixes.
2016-03-24 13:05:03 +00:00
Steve Daulton
4b070725f1
Fix for bug 512
2016-03-24 13:05:03 +00:00
Paul Licameli
f87433ac53
Bug1084: Restore the fix, while also keeping the crash bug 1242 fixed.
2016-03-22 13:21:36 -04:00
Paul Licameli
6f4c198771
Bug1242: fixed crash using VST plugin Ambience...
...
... Problem was a mismatch between a chunk retrieved for program only, but
then copied to slave effect as for a bank. Plug-in choked on the GIGO.
Fix makes chunk for bank both ways.
2016-03-22 12:39:34 -04:00
Steve Daulton
7464f49a66
Fix for bug 513
2016-03-22 00:45:48 +00:00
Steve Daulton
3cab059038
Tweak EQDefaultCurve update path
...
and add log message to aid testing.
2016-03-21 11:59:41 +00:00
Paul Licameli
911513fefe
Fix new TruncateSilence -- be sure to iterate over the correct track list
2016-03-14 11:30:03 -04:00
Paul Licameli
74dc49a9e9
Fix new TruncateSilence -- be sure to iterate over the correct track list
2016-03-14 11:29:34 -04:00
Steve Daulton
919712e3f7
Fix default EffectTypeProcess for Nyquist Prompt
...
Nyquist Prompt did not default to process type if a previous script
in the current session set a different type.
2016-03-14 09:22:25 +00:00
Gale Andrews
311a471286
Less scary message if can't update effect settings
2016-03-09 21:20:54 +00:00
Steve Daulton
7d5e54e364
Fix some assert error in EQ curves
...
Selected EQ curves in Draw mode should now retain their name
when they are selected.
2016-03-08 21:55:07 +00:00
Leland Lucius
9dc9348127
Fixes bug #1344 (mac build)
...
In addition, the Xcode project can now build against the 10.6
or 10.7 SDKs. All that is needed is to change the SDK version
and the other settings will change automatically.
2016-03-07 00:29:26 -06:00