Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-09-19 09:30:52 +02:00
Code Issues Releases Wiki Activity

ModuleManager::mLibs never becomes non-empty. Remove it.

Browse Source
This commit is contained in:
Paul Licameli 2021-05-13 16:26:27 -04:00
parent bd6fb75886
commit dcdddcb7f2
2 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/ModuleManager.cpp
View File

@ -485,13 +485,6 @@ void ModuleInterfaceDeleter::operator() (ModuleInterface *pInterface) const
if (pInterface) if (pInterface)
{ {
pInterface->Terminate(); pInterface->Terminate();
auto &libs = ModuleManager::Get().mLibs;
auto iter = libs.find(pInterface);
if (iter != libs.end())
libs.erase(iter); // This causes unloading in ~wxDynamicLibrary
std::unique_ptr < ModuleInterface > { pInterface }; // DELETE it std::unique_ptr < ModuleInterface > { pInterface }; // DELETE it
} }
} }

4
src/ModuleManager.h
View File

@ -120,10 +120,6 @@ private:
// ComponentInterface objects for each path: // ComponentInterface objects for each path:
ModuleMap mDynModules; ModuleMap mDynModules;
// Dynamically loaded libraries, each one a factory that makes one of the
// (non-built-in) providers:
LibraryMap mLibs;
// Other libraries that receive notifications of events described by // Other libraries that receive notifications of events described by
// ModuleDispatchTypes: // ModuleDispatchTypes:
std::vector<std::unique_ptr<Module>> mModules; std::vector<std::unique_ptr<Module>> mModules;