From dcdddcb7f227761b5200538c593205d2c8da93da Mon Sep 17 00:00:00 2001 From: Paul Licameli Date: Thu, 13 May 2021 16:26:27 -0400 Subject: [PATCH] ModuleManager::mLibs never becomes non-empty. Remove it. --- src/ModuleManager.cpp | 7 ------- src/ModuleManager.h | 4 ---- 2 files changed, 11 deletions(-) diff --git a/src/ModuleManager.cpp b/src/ModuleManager.cpp index ae1d35616..ff0c67205 100755 --- a/src/ModuleManager.cpp +++ b/src/ModuleManager.cpp @@ -485,13 +485,6 @@ void ModuleInterfaceDeleter::operator() (ModuleInterface *pInterface) const if (pInterface) { pInterface->Terminate(); - - auto &libs = ModuleManager::Get().mLibs; - - auto iter = libs.find(pInterface); - if (iter != libs.end()) - libs.erase(iter); // This causes unloading in ~wxDynamicLibrary - std::unique_ptr < ModuleInterface > { pInterface }; // DELETE it } } diff --git a/src/ModuleManager.h b/src/ModuleManager.h index 8773b4251..0acf96960 100644 --- a/src/ModuleManager.h +++ b/src/ModuleManager.h @@ -120,10 +120,6 @@ private: // ComponentInterface objects for each path: ModuleMap mDynModules; - // Dynamically loaded libraries, each one a factory that makes one of the - // (non-built-in) providers: - LibraryMap mLibs; - // Other libraries that receive notifications of events described by // ModuleDispatchTypes: std::vector> mModules;