Autres/audacity
1
0
Fork 0
mirror of https://github.com/cookiengineer/audacity synced 2025-10-26 00:03:52 +02:00
Code Issues Releases Wiki Activity

Add error check comments.

Browse Source 
These are places where we don't properly handle error returns.
This commit is contained in:
James Crook
2016-07-09 21:20:35 +01:00
parent c8d5905bd3
commit 763485b0dc
19 changed files with 50 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Sequence.cpp
View File

@@ -1026,6 +1026,7 @@ XMLTagHandler *Sequence::HandleXMLChild(const wxChar *tag)
}
}
// Throws exceptions rather than reporting errors.
void Sequence::WriteXML(XMLWriter &xmlFile)
{
unsigned int b;
@@ -1542,6 +1543,7 @@ bool Sequence::Append(samplePtr buffer, sampleFormat format,
blockFileLog != NULL),
lastBlock.start
);
// FIXME: TRAP_ERR This could throw an exception that should(?) be converted to return false.
if (blockFileLog)
static_cast<SimpleBlockFile*>(newLastBlock.f)->SaveXML(*blockFileLog);
@@ -1567,6 +1569,7 @@ bool Sequence::Append(samplePtr buffer, sampleFormat format,
blockFileLog != NULL);
}
// FIXME: TRAP_ERR This could throw an exception that should(?) be converted to return false.
if (blockFileLog)
static_cast<SimpleBlockFile*>(pFile)->SaveXML(*blockFileLog);