1
0
mirror of https://github.com/cookiengineer/audacity synced 2025-07-31 07:59:27 +02:00

Fix unreported bug in AudioUnit effects...

... When locale is not English (and translation is complete enough, as in
French) then the switching from Generic to Full interface in Options... did not
work.

(Locales lacking translations of the strings "Full" and "Generic" didn't have
this problem.)

(AudioUnit effects still don't implement a "Basic" interface distinct from
"Generic" regardless of locale.  That's another matter.)
This commit is contained in:
Paul Licameli 2019-12-26 15:15:09 -05:00
parent 3a453126e8
commit 744f4b626c
2 changed files with 1 additions and 5 deletions

View File

@ -1049,8 +1049,6 @@ bool AudioUnitEffect::SetHost(EffectHostInterface *host)
mHost->GetSharedConfig(wxT("Options"), wxT("UseLatency"), mUseLatency, true);
mHost->GetSharedConfig(wxT("Options"), wxT("UIType"), mUIType, wxT("Full"));
mUIType = wxGetTranslation(mUIType);
bool haveDefaults;
mHost->GetPrivateConfig(mHost->GetFactoryDefaultsGroup(), wxT("Initialized"), haveDefaults, false);
if (!haveDefaults)
@ -1868,8 +1866,6 @@ void AudioUnitEffect::ShowOptions()
// Reinitialize configuration settings
mHost->GetSharedConfig(wxT("Options"), wxT("UseLatency"), mUseLatency, true);
mHost->GetSharedConfig(wxT("Options"), wxT("UIType"), mUIType, wxT("Full"));
mUIType = wxGetTranslation(mUIType);
}
}

View File

@ -200,7 +200,7 @@ private:
EffectUIHostInterface *mUIHost;
wxWindow *mParent;
wxDialog *mDialog;
wxString mUIType;
wxString mUIType; // NOT translated, "Full", "Generic", or "Basic"
bool mIsGraphical;
AudioUnitEffect *mMaster; // non-NULL if a slave